* Re: [gnus git] branch master updated: =1= message.el (message-subject-trailing-was-regexp): Fix default value. [not found] <E1PFdVw-0007jE-00@quimby.gnus.org> @ 2010-11-09 7:44 ` Sven Joachim 2010-11-09 8:16 ` [gnus git] branch master updated: =1= message.el (message-subject-trailing- Katsumi Yamaoka 2010-11-09 17:52 ` [gnus git] branch master updated: =1= message.el (message-subject-trailing-was-regexp): Fix default value Andreas Schwab 0 siblings, 2 replies; 4+ messages in thread From: Sven Joachim @ 2010-11-09 7:44 UTC (permalink / raw) To: ding On 2010-11-09 03:00 +0100, Katsumi Yamaoka wrote: > diff --git a/lisp/message.el b/lisp/message.el > index 9b5f63c..035ba1c 100644 > --- a/lisp/message.el > +++ b/lisp/message.el > @@ -341,14 +341,14 @@ It is okay to create some false positives here, as the user is asked." > :type 'regexp) > > (defcustom message-subject-trailing-was-regexp > - "[ \t]*\\((*[Ww][Aa][Ss]:[ \t]*.*)\\)" > + "[ \t]*\\((*[Ww][Aa][Ss][ \t]*.*)\\)" > "*Regexp matching \"(was: <old subject>)\" in the subject line. This looks suspicious. The new value of message-subject-trailing-was-regexp matches neither the docstring nor what message-change-subject inserts when you change subject. I would suggest an optional colon both here and in message-subject-trailing-was-ask-regexp: --8<---------------cut here---------------start------------->8--- diff --git a/lisp/message.el b/lisp/message.el index 035ba1c..3dd4464 100644 --- a/lisp/message.el +++ b/lisp/message.el @@ -326,7 +326,7 @@ used." :group 'message-various) (defcustom message-subject-trailing-was-ask-regexp - "[ \t]*\\([[(]+[Ww][Aa][Ss][ \t]*.*[\])]+\\)" + "[ \t]*\\([[(]+[Ww][Aa][Ss]:?[ \t]*.*[\])]+\\)" "*Regexp matching \"(was: <old subject>)\" in the subject line. The function `message-strip-subject-trailing-was' uses this regexp if @@ -335,13 +335,13 @@ the variable is t instead of `ask', use `message-subject-trailing-was-regexp' instead. It is okay to create some false positives here, as the user is asked." - :version "22.1" + :version "24.1" :group 'message-various :link '(custom-manual "(message)Message Headers") :type 'regexp) (defcustom message-subject-trailing-was-regexp - "[ \t]*\\((*[Ww][Aa][Ss][ \t]*.*)\\)" + "[ \t]*\\((*[Ww][Aa][Ss]:?[ \t]*.*)\\)" "*Regexp matching \"(was: <old subject>)\" in the subject line. If `message-subject-trailing-was-query' is set to t, the subject is --8<---------------cut here---------------end--------------->8--- Cheers, Sven ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [gnus git] branch master updated: =1= message.el (message-subject-trailing- 2010-11-09 7:44 ` [gnus git] branch master updated: =1= message.el (message-subject-trailing-was-regexp): Fix default value Sven Joachim @ 2010-11-09 8:16 ` Katsumi Yamaoka 2010-11-09 17:52 ` [gnus git] branch master updated: =1= message.el (message-subject-trailing-was-regexp): Fix default value Andreas Schwab 1 sibling, 0 replies; 4+ messages in thread From: Katsumi Yamaoka @ 2010-11-09 8:16 UTC (permalink / raw) To: ding Sven Joachim wrote: > On 2010-11-09 03:00 +0100, Katsumi Yamaoka wrote: >> (defcustom message-subject-trailing-was-regexp >> - "[ \t]*\\((*[Ww][Aa][Ss]:[ \t]*.*)\\)" >> + "[ \t]*\\((*[Ww][Aa][Ss][ \t]*.*)\\)" > This looks suspicious. The new value of > message-subject-trailing-was-regexp matches neither the docstring nor > what message-change-subject inserts when you change subject. I would > suggest an optional colon both here and in > message-subject-trailing-was-ask-regexp: Thanks. I'll apply the patch later. (I must go home right now. ;-) ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [gnus git] branch master updated: =1= message.el (message-subject-trailing-was-regexp): Fix default value. 2010-11-09 7:44 ` [gnus git] branch master updated: =1= message.el (message-subject-trailing-was-regexp): Fix default value Sven Joachim 2010-11-09 8:16 ` [gnus git] branch master updated: =1= message.el (message-subject-trailing- Katsumi Yamaoka @ 2010-11-09 17:52 ` Andreas Schwab 2010-11-09 18:11 ` Lars Magne Ingebrigtsen 1 sibling, 1 reply; 4+ messages in thread From: Andreas Schwab @ 2010-11-09 17:52 UTC (permalink / raw) To: ding Sven Joachim <svenjoac@gmx.de> writes: > (defcustom message-subject-trailing-was-ask-regexp > - "[ \t]*\\([[(]+[Ww][Aa][Ss][ \t]*.*[\])]+\\)" > + "[ \t]*\\([[(]+[Ww][Aa][Ss]:?[ \t]*.*[\])]+\\)" ^ That backslash looks suspicious, because it is effectively ignored. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [gnus git] branch master updated: =1= message.el (message-subject-trailing-was-regexp): Fix default value. 2010-11-09 17:52 ` [gnus git] branch master updated: =1= message.el (message-subject-trailing-was-regexp): Fix default value Andreas Schwab @ 2010-11-09 18:11 ` Lars Magne Ingebrigtsen 0 siblings, 0 replies; 4+ messages in thread From: Lars Magne Ingebrigtsen @ 2010-11-09 18:11 UTC (permalink / raw) To: ding Andreas Schwab <schwab@linux-m68k.org> writes: >> + "[ \t]*\\([[(]+[Ww][Aa][Ss]:?[ \t]*.*[\])]+\\)" > ^ > That backslash looks suspicious, because it is effectively ignored. I've now removed it. -- (domestic pets only, the antidote for overdose, milk.) larsi@gnus.org * Lars Magne Ingebrigtsen ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-09 18:11 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <E1PFdVw-0007jE-00@quimby.gnus.org> 2010-11-09 7:44 ` [gnus git] branch master updated: =1= message.el (message-subject-trailing-was-regexp): Fix default value Sven Joachim 2010-11-09 8:16 ` [gnus git] branch master updated: =1= message.el (message-subject-trailing- Katsumi Yamaoka 2010-11-09 17:52 ` [gnus git] branch master updated: =1= message.el (message-subject-trailing-was-regexp): Fix default value Andreas Schwab 2010-11-09 18:11 ` Lars Magne Ingebrigtsen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).