Gnus development mailing list
 help / color / mirror / Atom feed
* new nnimap: marks with no flags (patch)
@ 2010-09-20 11:37 David Edmondson
  2010-09-20 15:18 ` Ted Zlatanov
  2010-09-20 15:51 ` Lars Magne Ingebrigtsen
  0 siblings, 2 replies; 4+ messages in thread
From: David Edmondson @ 2010-09-20 11:37 UTC (permalink / raw)
  To: ding

If a Gnus mark has no corresponding IMAP flag an error results in
nnimap-request-set-mark. Suggested patch:

diff --git a/lisp/nnimap.el b/lisp/nnimap.el
index b3a9e5b..7e870b5 100644
--- a/lisp/nnimap.el
+++ b/lisp/nnimap.el
@@ -530,7 +530,8 @@ textual parts.")
 				(mapconcat #'identity flags " ")))))))
 	;; Wait for the last command to complete to avoid later
 	;; syncronisation problems with the stream.
-	(nnimap-wait-for-response sequence)))))
+	(when sequence
+	  (nnimap-wait-for-response sequence))))))
 
 (deffoo nnimap-request-accept-article (group &optional server last)
   (when (nnimap-possibly-change-group nil server)

dme.
-- 
David Edmondson, http://dme.org



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: new nnimap: marks with no flags (patch)
  2010-09-20 11:37 new nnimap: marks with no flags (patch) David Edmondson
@ 2010-09-20 15:18 ` Ted Zlatanov
  2010-09-20 15:52   ` Lars Magne Ingebrigtsen
  2010-09-20 15:51 ` Lars Magne Ingebrigtsen
  1 sibling, 1 reply; 4+ messages in thread
From: Ted Zlatanov @ 2010-09-20 15:18 UTC (permalink / raw)
  To: ding

On Mon, 20 Sep 2010 12:37:16 +0100 David Edmondson <dme@dme.org> wrote: 

DE> If a Gnus mark has no corresponding IMAP flag an error results in
DE> nnimap-request-set-mark. Suggested patch:

DE> diff --git a/lisp/nnimap.el b/lisp/nnimap.el
DE> index b3a9e5b..7e870b5 100644
DE> --- a/lisp/nnimap.el
DE> +++ b/lisp/nnimap.el
DE> @@ -530,7 +530,8 @@ textual parts.")
DE>  				(mapconcat #'identity flags " ")))))))
DE>  	;; Wait for the last command to complete to avoid later
DE>  	;; syncronisation problems with the stream.
DE> -	(nnimap-wait-for-response sequence)))))
DE> +	(when sequence
DE> +	  (nnimap-wait-for-response sequence))))))
 
DE>  (deffoo nnimap-request-accept-article (group &optional server last)
DE>    (when (nnimap-possibly-change-group nil server)

Shouldn't nnimap set it as a custom flag in that case?

Ted




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: new nnimap: marks with no flags (patch)
  2010-09-20 11:37 new nnimap: marks with no flags (patch) David Edmondson
  2010-09-20 15:18 ` Ted Zlatanov
@ 2010-09-20 15:51 ` Lars Magne Ingebrigtsen
  1 sibling, 0 replies; 4+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-09-20 15:51 UTC (permalink / raw)
  To: ding

David Edmondson <dme@dme.org> writes:

> If a Gnus mark has no corresponding IMAP flag an error results in
> nnimap-request-set-mark. Suggested patch:

Thanks; applied and pushed.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: new nnimap: marks with no flags (patch)
  2010-09-20 15:18 ` Ted Zlatanov
@ 2010-09-20 15:52   ` Lars Magne Ingebrigtsen
  0 siblings, 0 replies; 4+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-09-20 15:52 UTC (permalink / raw)
  To: ding

Ted Zlatanov <tzz@lifelogs.com> writes:

> Shouldn't nnimap set it as a custom flag in that case?

Not all Gnus flags are relevant on the server.  Like the flags Gnus uses
to keep track of how to sync with the server.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-09-20 15:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-20 11:37 new nnimap: marks with no flags (patch) David Edmondson
2010-09-20 15:18 ` Ted Zlatanov
2010-09-20 15:52   ` Lars Magne Ingebrigtsen
2010-09-20 15:51 ` Lars Magne Ingebrigtsen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).