Re: nnimap fails to fetch some articles

[Bjorn Solberg <bjorn_ding@hekneby.org>]

Simon Josefsson writes:

> Bjorn Solberg <bjorn_ding@hekneby.org> writes:
[...]
>> " *nntpd*" shows an entry for all 5 messages.  I have received new
>> messages since last, so now it show only 2 messages when I do 5 RET.
>> Which means this is somehow content-related.
>> 
>> However, I see a pattern in " *nntpd*" now: " *nntpd*" shows that the
>> messages aren't sorted by id.  For example, doing 5 RET I see entries 793
>> 795 794 792 791 in " *nntpd*", and only 793 and 795 is shown in the
>> Summary buffer.

> Ah, thanks, that is it.  The IMAP server returned the articles out of
> order.  Which I think is perfectly legal.  Maybe the following patch
> help?  Untested.

> --- nnimap.el	04 Mar 2005 17:59:01 +0100	7.17
> +++ nnimap.el	07 Mar 2005 22:45:30 +0100	
> @@ -710,6 +710,8 @@
>  			    (if (imap-capability 'IMAP4rev1)
>  				(format "BODY.PEEK[HEADER.FIELDS %s])" headers)
>  			      (format "RFC822.HEADER.LINES %s)" headers)))))
> +      (with-current-buffer nntp-server-buffer
> +	(sort-lines))
>        (and (numberp nnmail-large-newsgroup)
>  	   (> nnimap-length nnmail-large-newsgroup)
>  	   (nnheader-message 6 "nnimap: Retrieving headers...done")))))

When compiling, it says:

Compiling file c:/emacs-21.3/site-lisp/gnus-CURRENT-20050304/lisp/nnimap.el at Mon Mar 07 13:51:46 2005
  ** sort-lines called with 0 arguments, but requires 3

and when running it:

nnimap-retrieve-headers-from-server: Wrong number of arguments: #[(reverse beg end) 	}ebÃ
ÄÅ#*" [beg end reverse sort-subr forward-line end-of-line] 4 ("c:/emacs-21.3/lisp/sort.elc" . 4220) "P
r"], 0

C-h f sort-lines says:

sort-lines is an interactive compiled Lisp function in `sort'.
(sort-lines REVERSE BEG END)

Sort lines in region alphabetically; argument means descending order.
Called from a program, there are three arguments:
REVERSE (non-nil means reverse order), BEG and END (region to sort).
The variable `sort-fold-case' determines whether alphabetic case affects
the sort order.

So I suppose we need to pass in the beginning and end of the buffer also,
or is that something the macro surrounding it should have taken care of?
(About time I start learning some elisp, I guess.)

Bjorn.