[gnus.gnus-bug] [Regression] Why is my Summary buffer green?

[gnus.gnus-bug] [Regression] Why is my Summary buffer green?

[Lars Magne Ingebrigtsen]

[-- Attachment #1: Type: text/plain, Size: 97 bytes --]

This really should be fixed, I think.  What's the minimal solution
for making this work better?


[-- Attachment #2: Type: message/rfc822, Size: 35771 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 371 bytes --]

Gnus v5.10.5
XEmacs 21.4 (patch 14) "Reasonable Discussion" [Lucid] (powerpc-unknown-linux) of Sat Nov 22 2003 on c18072.rivrw2.nsw.optusnet.com.au
200  NNRP Service Ready (posting ok).

[I Think that Kai has already reported this but I don't think it made much
impact]

This is a picture of my summary buffer for aus.rail when using CVS gnus
updated a few minutes ago:


[-- Attachment #2.1.2: Green Summary Buffer --]
[-- Type: image/png, Size: 12033 bytes --]

[-- Attachment #2.1.3: Type: text/plain, Size: 110 bytes --]


Note how all the articles are all the one colour.  This contrasts with 5.10.2
using exactly the same setup:


[-- Attachment #2.1.4: Same buffer in 5.10.2. --]
[-- Type: image/png, Size: 12247 bytes --]

[-- Attachment #2.1.5: Type: text/plain, Size: 298 bytes --]


I think that it is related to relatively recent agent changes, but for
whatever reason it is a regression and should be fixed before No Gnus starts.

Is there any chance that this could be done?  I find it a lot harder to find
unread articles because I'm used to the different colours.

Malcolm



[-- Attachment #3: Type: text/plain, Size: 124 bytes --]



-- 
If you want an explanation on what you have just read, please
refer to <URL:http://quimby.gnus.org/gnus/zombie.html>.

Re: [gnus.gnus-bug] [Regression] Why is my Summary buffer green?

[Zack Weinberg]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> This really should be fixed, I think.  What's the minimal solution
> for making this work better?

FWIW I also see this, but only in NNTP groups.

zw

Re: [gnus.gnus-bug] [Regression] Why is my Summary buffer green?

[Simon Josefsson]

I don't see this (perhaps because my gnus-select-article-hook call
gnus-agent-fetch-selected-article), but one idea is that this patch
might help.  I think this has been discussed before.

--- gnus-sum.el.~6.376.~	2004-01-03 23:45:28.000000000 +0100
+++ gnus-sum.el	2004-01-03 23:48:00.000000000 +0100
@@ -907,12 +907,6 @@
 (defcustom gnus-summary-highlight
   '(((eq mark gnus-canceled-mark)
      . gnus-summary-cancelled-face)
-    ((and uncached (> score default-high))
-     . gnus-summary-high-undownloaded-face)
-    ((and uncached (< score default-low))
-     . gnus-summary-low-undownloaded-face)
-    (uncached
-     . gnus-summary-normal-undownloaded-face)
     ((and (> score default-high)
 	  (or (eq mark gnus-dormant-mark)
 	      (eq mark gnus-ticked-mark)))
@@ -940,6 +934,12 @@
      . gnus-summary-high-read-face)
     ((< score default-low)
      . gnus-summary-low-read-face)
+    ((and uncached (> score default-high))
+     . gnus-summary-high-undownloaded-face)
+    ((and uncached (< score default-low))
+     . gnus-summary-low-undownloaded-face)
+    (uncached
+     . gnus-summary-normal-undownloaded-face)
     (t
      . gnus-summary-normal-read-face))
   "*Controls the highlighting of summary buffer lines.

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> This really should be fixed, I think.  What's the minimal solution
> for making this work better?
>
> From:  Malcolm Purvis <malcolmpurvis@optushome.com.au>
> Subject: [Regression] Why is my Summary buffer green?
> Newsgroups: gnus.gnus-bug
> Date: Sat, 03 Jan 2004 21:59:42 +1100
>
> Gnus v5.10.5
> XEmacs 21.4 (patch 14) "Reasonable Discussion" [Lucid] (powerpc-unknown-linux) of Sat Nov 22 2003 on c18072.rivrw2.nsw.optusnet.com.au
> 200  NNRP Service Ready (posting ok).
>
> [I Think that Kai has already reported this but I don't think it made much
> impact]
>
> This is a picture of my summary buffer for aus.rail when using CVS gnus
> updated a few minutes ago:
>
>
>
> Note how all the articles are all the one colour.  This contrasts with 5.10.2
> using exactly the same setup:
>
>
>
> I think that it is related to relatively recent agent changes, but for
> whatever reason it is a regression and should be fixed before No Gnus starts.
>
> Is there any chance that this could be done?  I find it a lot harder to find
> unread articles because I'm used to the different colours.
>
> Malcolm
>
>
> ----------
>
>
>
> -- 
> If you want an explanation on what you have just read, please
> refer to <URL:http://quimby.gnus.org/gnus/zombie.html>.

Re: [gnus.gnus-bug] [Regression] Why is my Summary buffer green?

[Lars Magne Ingebrigtsen]

Simon Josefsson <jas@extundo.com> writes:

> I don't see this (perhaps because my gnus-select-article-hook call
> gnus-agent-fetch-selected-article), but one idea is that this patch
> might help.  I think this has been discussed before.

So you basically just move the uncached-face stuff further down.

It's worth a shot -- you could apply it after No Gnus has started...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: [gnus.gnus-bug] [Regression] Why is my Summary buffer green?

[Sebastian D.B. Krause]

"Zack Weinberg" <zack@codesourcery.com> wrote:
> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>> This really should be fixed, I think.  What's the minimal solution
>> for making this work better?
>
> FWIW I also see this, but only in NNTP groups.

Same here. That's because you probably have the Gnus Agent disabled
in the mail groups, and I only get this colors on groups which use
the agent.

I think it's important to fix it before No Gnus starts, it's very
annoying.

Sebastian

Re: [gnus.gnus-bug] [Regression] Why is my Summary buffer green?

[Lars Magne Ingebrigtsen]

"Sebastian D.B. Krause" <krause@sdbk.de> writes:

> I think it's important to fix it before No Gnus starts, it's very
> annoying.

It should be OK now...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: [gnus.gnus-bug] [Regression] Why is my Summary buffer green?

[Malcolm Purvis]

>>>>> "Lars" == Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

Lars> It should be OK now...

Fixed here.  Thanks!

Malcolm

-- 
	       Malcolm Purvis <malcolmpurvis@optushome.com.au>

Q: Why did the chicken cross the Mobius strip?
A: To get to the other... uh... err...