Re: Changes committed gnus/lisp (ChangeLog gnus-msg.el gnus-sum.el)

Re: Changes committed gnus/lisp (ChangeLog gnus-msg.el gnus-sum.el)

[Jesper Harder]

"Lars Magne Ingebrigtsen" <larsi@gnus.org> writes:

> +2003-02-07  Lars Magne Ingebrigtsen  <larsi@gnus.org>
>
> +	* gnus-msg.el (gnus-version-expose-system): Change default.
>
> +(defcustom gnus-version-expose-system nil
> +  "If non-nil, `system-configuration' is exposed in `gnus-extended-version'."

Couldn't we have it turned on by default, please?

Having that information saves a lot of time in gnu.emacs.*, because
people always forget to say what system they're using.

Re: Changes committed gnus/lisp (ChangeLog gnus-msg.el gnus-sum.el)

[Lars Magne Ingebrigtsen]

Jesper Harder <harder@myrealbox.com> writes:

> Couldn't we have it turned on by default, please?

I think software should try to err on the side of not revealing stuff
that people possibly don't want to reveal.  I know I wouldn't want
people to know if I were using a Microsoft Windows machine, for
instance. 

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Changes committed gnus/lisp (ChangeLog gnus-msg.el gnus-sum.el)

[Vasily Korytov]

[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]

>>>>> "LMI" == Lars Magne Ingebrigtsen writes:

 LMI> Jesper Harder <harder@myrealbox.com> writes:
 >> Couldn't we have it turned on by default, please?

 LMI> I think software should try to err on the side of not revealing stuff
 LMI> that people possibly don't want to reveal.  I know I wouldn't want
 LMI> people to know if I were using a Microsoft Windows machine, for
 LMI> instance. 

On the other side, why would someone want to set this variable to t, and
how does this help anyone else?

Again, system-configuraton exposing isn't so bad. tin, slrn, GoldED+ --
they have certain OS exposion (each in it's own way), and generally it
can be good (in, say, fido7.ru.unix -- again a lot of people forget to
mention theis OS).

Well, the whoule User-Agent header is revealing some info, user is
probably unwilling to share. But as long, as one can turn it off, I see
nothing bad, but even good, if it's enabled by default. The same for
system-coniguration.

-- 
       I accept RFC3156 and RFC1991-compatible encrypted mail.
PGP key fingerprint: 123A 7CCE 6E26 6233 0D87 E01A A0F8 3524 FCD8 1841

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: Changes committed gnus/lisp (ChangeLog gnus-msg.el gnus-sum.el)

[Jesper Harder]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Jesper Harder <harder@myrealbox.com> writes:
>
>> Couldn't we have it turned on by default, please?
>
> I think software should try to err on the side of not revealing stuff
> that people possibly don't want to reveal.  

We could limit it to `system-type' instead of `system-configuration'.

The rest of the stuff in `system-configuration' (i386, i686, sparc or
whatever) isn't really helpful anyway.

Re: Changes committed gnus/lisp (ChangeLog gnus-msg.el gnus-sum.el)

[Lars Magne Ingebrigtsen]

Jesper Harder <harder@myrealbox.com> writes:

>> I think software should try to err on the side of not revealing stuff
>> that people possibly don't want to reveal.  
>
> We could limit it to `system-type' instead of `system-configuration'.

That's a possibility...

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Changes committed gnus/lisp (ChangeLog gnus-msg.el gnus-sum.el)

[Vasily Korytov]

[-- Attachment #1.1: Type: text/plain, Size: 411 bytes --]

>>>>> "LMI" == Lars Magne Ingebrigtsen writes:

 LMI> Jesper Harder <harder@myrealbox.com> writes:
 >>> I think software should try to err on the side of not revealing stuff
 >>> that people possibly don't want to reveal.  
 >> 
 >> We could limit it to `system-type' instead of `system-configuration'.

 LMI> That's a possibility...

Will we switch to use gnus-version-expose-system t by default?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: gnus-msg.el.patch --]
[-- Type: text/x-patch, Size: 1251 bytes --]

--- gnus-msg.el~	Fri Feb  7 17:17:17 2003
+++ gnus-msg.el	Sun Feb  9 06:04:11 2003
@@ -284,7 +284,7 @@
   :type 'boolean)
 
 (defcustom gnus-version-expose-system nil
-  "If non-nil, `system-configuration' is exposed in `gnus-extended-version'."
+  "If non-nil, `system-type' is exposed in `gnus-extended-version'."
   :group 'gnus-message
   :type 'boolean)
 
@@ -1034,7 +1034,7 @@
     ((string-match "^\\(\\([.0-9]+\\)*\\)\\.[0-9]+$" emacs-version)
      (concat "Emacs/" (match-string 1 emacs-version)
 	     (if gnus-version-expose-system
-		 " (" system-configuration ")"
+		 (concat " (" (symbol-name system-type) ")")
 	       "")))
     ((string-match "\\([A-Z]*[Mm][Aa][Cc][Ss]\\)[^(]*\\(\\((beta.*)\\|'\\)\\)?"
 		   emacs-version)
@@ -1044,10 +1044,11 @@
 		 (match-string 3 emacs-version)
 	       "")
 	     (if (boundp 'xemacs-codename)
-	     (if gnus-version-expose-system
-		 (concat " (" xemacs-codename ", " system-configuration ")")
-	       (concat " (" xemacs-codename ")"))
-	     "")))
+		 (if gnus-version-expose-system
+		     (concat " (" xemacs-codename ", "
+			     (symbol-name system-type) ")")
+		   (concat " (" xemacs-codename ")"))
+	       "")))
     (t emacs-version))))
 
 \f

[-- Attachment #1.3: Type: text/plain, Size: 141 bytes --]

-- 
       I accept RFC3156 and RFC1991-compatible encrypted mail.
PGP key fingerprint: 123A 7CCE 6E26 6233 0D87 E01A A0F8 3524 FCD8 1841

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: Changes committed gnus/lisp (ChangeLog gnus-msg.el gnus-sum.el)

[Vasily Korytov]

[-- Attachment #1.1: Type: text/plain, Size: 211 bytes --]

>>>>> "VK" == Vasily Korytov writes:

 VK> [2. text/x-patch; gnus-msg.el.patch]...

I've forgotten to mention, the above patch also fixes the forgotten
concat in my code. =)) Also here goes the doc patch:

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: gnus.texi.patch --]
[-- Type: text/x-patch, Size: 721 bytes --]

--- gnus.texi~	Sun Feb  9 05:47:41 2003
+++ gnus.texi	Sun Feb  9 06:17:13 2003
@@ -11158,10 +11158,10 @@
 @item gnus-version-expose-system
 @vindex gnus-version-expose-system
 
-Your system type (@code{system-configuration} variable, such as
-@samp{i686-pc-linux}) is exposed in the auto-generated by default
-User-Agent header. Sometimes, it may be desireable (mostly because of
-aesthetic reasons) to turn it off. In this case, set it to @code{nil}.
+Your system type (@code{system-type} variable) is exposed in the
+auto-generated by default User-Agent header. Sometimes, it may be
+desireable (mostly because of aesthetic reasons) to turn it off. In this
+case, set it to @code{nil}.
 
 @end table
 

[-- Attachment #1.3: Type: text/plain, Size: 141 bytes --]

-- 
       I accept RFC3156 and RFC1991-compatible encrypted mail.
PGP key fingerprint: 123A 7CCE 6E26 6233 0D87 E01A A0F8 3524 FCD8 1841

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: Changes committed gnus/lisp (ChangeLog gnus-msg.el gnus-sum.el)

[Vasily Korytov]

[-- Attachment #1.1: Type: text/plain, Size: 218 bytes --]

>>>>> "VK" == Vasily Korytov writes:

 VK> [2. text/x-patch; gnus-msg.el.patch]...

One more related XEmacs-related patch. You may notice the difference in
the User-Agent header of this message and the previous.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: gnus-msg.patch --]
[-- Type: text/x-patch, Size: 549 bytes --]

--- gnus-msg.el~	Mon Feb 10 11:21:05 2003
+++ gnus-msg.el	Mon Feb 10 11:22:24 2003
@@ -1044,10 +1044,10 @@
 		 (match-string 3 emacs-version)
 	       "")
 	     (if (boundp 'xemacs-codename)
-		 (if gnus-version-expose-system
-		     (concat " (" xemacs-codename ", "
-			     (symbol-name system-type) ")")
-		   (concat " (" xemacs-codename ")"))
+		 (concat " \"" xemacs-codename "\"")
+	       "")
+	     (if gnus-version-expose-system
+		 (concat " (" (symbol-name system-type) ")")
 	       "")))
     (t emacs-version))))
 

[-- Attachment #1.3: Type: text/plain, Size: 141 bytes --]

-- 
       I accept RFC3156 and RFC1991-compatible encrypted mail.
PGP key fingerprint: 123A 7CCE 6E26 6233 0D87 E01A A0F8 3524 FCD8 1841

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: Changes committed gnus/lisp (ChangeLog gnus-msg.el gnus-sum.el)

[Russ Allbery]

Vasily Korytov <deskpot@myrealbox.com> writes:

> One more related XEmacs-related patch. You may notice the difference in
> the User-Agent header of this message and the previous.

The one in this latest message is wrong, though.

User-Agent: Gnus/5.090016 (Oort Gnus v0.16) XEmacs/21.4 "Portable Code"
 (linux)

"Portable Code" is not a product/version pair.  Anything that isn't a
product/version pair needs to be a comment.

The User-Agent header in the mail or news context isn't really
standardized as such, but it's essentially an adoption of the User-Agent
header from HTTP.  From RFC 2616:

14.43 User-Agent

   The User-Agent request-header field contains information about the
   user agent originating the request. This is for statistical purposes,
   the tracing of protocol violations, and automated recognition of user
   agents for the sake of tailoring responses to avoid particular user
   agent limitations. User agents SHOULD include this field with
   requests. The field can contain multiple product tokens (section 3.8)
   and comments identifying the agent and any subproducts which form a
   significant part of the user agent. By convention, the product tokens
   are listed in order of their significance for identifying the
   application.

       User-Agent     = "User-Agent" ":" 1*( product | comment )

   Example:

       User-Agent: CERN-LineMode/2.15 libwww/2.17b3

where product is:

3.8 Product Tokens

   Product tokens are used to allow communicating applications to
   identify themselves by software name and version. Most fields using
   product tokens also allow sub-products which form a significant part
   of the application to be listed, separated by white space. By
   convention, the products are listed in order of their significance
   for identifying the application.

       product         = token ["/" product-version]
       product-version = token

   Examples:

       User-Agent: CERN-LineMode/2.15 libwww/2.17b3
       Server: Apache/0.8.4

-- 
Russ Allbery (rra@stanford.edu)             <http://www.eyrie.org/~eagle/>

Re: Changes committed gnus/lisp (ChangeLog gnus-msg.el gnus-sum.el)

[Vasily Korytov]

[-- Attachment #1: Type: text/plain, Size: 716 bytes --]

>>>>> "RA" == Russ Allbery writes:

 RA> User-Agent: Gnus/5.090016 (Oort Gnus v0.16) XEmacs/21.4 "Portable Code"
 RA>  (linux)

 RA> "Portable Code" is not a product/version pair.  Anything that isn't a
 RA> product/version pair needs to be a comment.

 RA> The User-Agent header in the mail or news context isn't really
 RA> standardized as such, but it's essentially an adoption of the User-Agent
 RA> header from HTTP.

Ah, that's why I don't know anything about it. =)) Anyway, probably,
you're right and this patch shouldn't be applied. Thanks for info.

-- 
       I accept RFC3156 and RFC1991-compatible encrypted mail.
PGP key fingerprint: 123A 7CCE 6E26 6233 0D87 E01A A0F8 3524 FCD8 1841

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: Changes committed gnus/lisp (ChangeLog gnus-msg.el gnus-sum.el)

[Lars Magne Ingebrigtsen]

deskpot@myrealbox.com (Vasily Korytov) writes:

> Will we switch to use gnus-version-expose-system t by default?

Well, thinking this over a bit, it seems that the only reason for
exposing the system type is to make it easier to see whether people
are using Windows, so that we can adequately, er, help.  So it's a
kind of debugging tool.  I'm not quite sure that's important enough
a reason to expose this information.

(Why have a User-Agent header at all?  Well, first of all because
it's fun, but most importantly because it's a way to hold client
writers accountable.  If Eudora didn't put its name in any of the
headers, we wouldn't know how much that client sucked,
interoperatively speaking.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Changes committed gnus/lisp (ChangeLog gnus-msg.el gnus-sum.el)

[Jesper Harder]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> deskpot@myrealbox.com (Vasily Korytov) writes:
>
>> Will we switch to use gnus-version-expose-system t by default?
>
> Well, thinking this over a bit, it seems that the only reason for
> exposing the system type is to make it easier to see whether people
> are using Windows, 

And also Mac, these days.

> so that we can adequately, er, help.  So it's a kind of debugging
> tool.

Another useful purpose is doing statistics (which is also mentioned in
Usefor).  I think "What's the percentage of Unix/Windows/Mac
Gnus-users?" would be a reasonable question to try to answer.

> I'm not quite sure that's important enough a reason to expose this
> information.

I think there's a valid security argument against exposing
`system-configuration'.  On some systems it might include enough
information to maybe determine if you're vulnerable to some exploit.

But `system-type' is so generic that it doesn't reveal very much.
E.g. my Digital Unix box is listed as just "berkeley-unix" (I doubt that
would help an attacker much :-), and all the different ms-windows
versions are "windows-nt".

Re: Changes committed gnus/lisp (ChangeLog gnus-msg.el gnus-sum.el)

[Vasily Korytov]

[-- Attachment #1: Type: text/plain, Size: 614 bytes --]

>>>>> "LMI" == Lars Magne Ingebrigtsen writes:

 LMI> Well, thinking this over a bit, it seems that the only reason for
 LMI> exposing the system type is to make it easier to see whether people
 LMI> are using Windows, so that we can adequately, er, help.  So it's a
 LMI> kind of debugging tool.  I'm not quite sure that's important enough
 LMI> a reason to expose this information.

By the way, what's the reason to expose emacsen version in that very header?

-- 
       I accept RFC3156 and RFC1991-compatible encrypted mail.
PGP key fingerprint: 123A 7CCE 6E26 6233 0D87 E01A A0F8 3524 FCD8 1841

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

User-Agent string (was: Changes committed gnus/lisp (ChangeLog gnus-msg.el gnus-sum.el))

[Reiner Steib]

On Tue, Feb 11 2003, Jesper Harder wrote:

> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>> Well, thinking this over a bit, it seems that the only reason for
>> exposing the system type is to make it easier to see whether people
>> are using Windows, 
> And also Mac, these days.
>> so that we can adequately, er, help.  So it's a kind of debugging
>> tool.
>
> Another useful purpose is doing statistics (which is also mentioned in
> Usefor).  I think "What's the percentage of Unix/Windows/Mac
> Gnus-users?" would be a reasonable question to try to answer.
>
>> I'm not quite sure that's important enough a reason to expose this
>> information.

`system-configuration' was added 2001-10-22 and I've never seen any
complaints against it (some people were surprised that i?86 doesn't
reflect their running system --> built system).  I think that it's
both, quite save and useful to use `system-type' and enable this by
default.  Exposing the system is helpful quite often.

To make it easier for the user to expose less information, we could
add something like this...

--8<---------------cut here---------------start------------->8---
(defcustom gnus-user-agent 'full
  "Which information should be exposed in the User-Agent header.
Can be one of the symbols `full' \(show full information\), `emacs-gnus'
\(show only Emacs and Gnus version\), `gnus' \(show only Gnus version\) or a
custom string.  If you set it to a string, be sure to use a valid format, see
RFC 2616."
  :group 'gnus-message
  :type '(choice (item :tag "Show full info" full) ;; system-type
		 (item :tag "Show Gnus and Emacs versions" emacs-gnus)
		 (item :tag "Show only Gnus version" gnus)
		 (string :tag "Other")))
--8<---------------cut here---------------end--------------->8---

If we can reach consensus about this, I'll send a proper patch for
`gnus-extended-version' (BTW, the current User-Agent header is b0rked,
if `gnus-version-expose-system' is non-nil).

> But `system-type' is so generic that it doesn't reveal very much.
> E.g. my Digital Unix box is listed as just "berkeley-unix" (I doubt that
> would help an attacker much :-), and all the different ms-windows
> versions are "windows-nt".

ACK.  Most other multi-platform MUAs and news readers expose the
system (or even more) by default, e.g. Netscape/Mozilla, tin, slrn,
...

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/

Re: User-Agent string

[Vasily Korytov]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

>>>>> "RS" == Reiner Steib writes:

 RS> (BTW, the current User-Agent header is b0rked, if
 RS> `gnus-version-expose-system' is non-nil).

As for GNU Emacs, yes. I've forgotten the concat (I've supplied a fix
higher in the thread, but together with switching to system-type). =))

-- 
       I accept RFC3156 and RFC1991-compatible encrypted mail.
PGP key fingerprint: 123A 7CCE 6E26 6233 0D87 E01A A0F8 3524 FCD8 1841

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: User-Agent string

[Lars Magne Ingebrigtsen]

Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:

> To make it easier for the user to expose less information, we could
> add something like this...
>
> --8<---------------cut here---------------start------------->8---
> (defcustom gnus-user-agent 'full
>   "Which information should be exposed in the User-Agent header.

I think this makes most sense -- letting the user decide.

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Changes committed gnus/lisp (ChangeLog gnus-msg.el gnus-sum.el)

[Lars Magne Ingebrigtsen]

deskpot@myrealbox.com (Vasily Korytov) writes:

> By the way, what's the reason to expose emacsen version in that very
> header?

It's fun.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: User-Agent string

[Reiner Steib]

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]

On Sat, Feb 22 2003, Lars Magne Ingebrigtsen wrote:

> Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:
>
>> To make it easier for the user to expose less information, we could
>> add something like this...
>>
>> --8<---------------cut here---------------start------------->8---
>> (defcustom gnus-user-agent 'full
>>   "Which information should be exposed in the User-Agent header.
>
> I think this makes most sense -- letting the user decide.

The attached patch contains code, documentation and ChangeLog entries
for this.

2003-02-24  Reiner Steib  <Reiner.Steib@gmx.de>

	* gnus-msg.el (gnus-user-agent): New variable.
	(gnus-version-expose-system): Removed.  Obsoleted by
	`gnus-user-agent'.
	(gnus-extended-version): Use `gnus-user-agent'.

2003-02-24  Reiner Steib  <Reiner.Steib@gmx.de>

	* gnus.texi (Mail and Post): Added `gnus-user-agent', removed
	`gnus-version-expose-system'.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-user-agent.patch --]
[-- Type: text/x-patch, Size: 5870 bytes --]

Index: texi/gnus.texi
===================================================================
RCS file: /usr/local/cvsroot/gnus/texi/gnus.texi,v
retrieving revision 6.427
diff -u -r6.427 gnus.texi
--- texi/gnus.texi	24 Feb 2003 02:01:01 -0000	6.427
+++ texi/gnus.texi	24 Feb 2003 16:58:03 -0000
@@ -11183,13 +11183,17 @@
 lists will work most of the time.  Posting to these groups (@kbd{a}) is
 still a pain, though.
 
-@item gnus-version-expose-system
-@vindex gnus-version-expose-system
+@item gnus-user-agent
+@vindex gnus-user-agent
+@cindex User-Agent
 
-Your system type (@code{system-configuration} variable, such as
-@samp{i686-pc-linux}) is exposed in the auto-generated by default
-User-Agent header. Sometimes, it may be desireable (mostly because of
-aesthetic reasons) to turn it off. In this case, set it to @code{nil}.
+This variable controls which information should be exposed in the
+User-Agent header.  It can be one of the symbols @code{full} (show full
+information, i.e. Emacs and Gnus version and system configuration),
+@code{emacs-gnus} (show only Emacs and Gnus version),
+@code{emacs-gnus-type} (same as @code{emacs-gnus} plus system type),
+@code{gnus} (show only Gnus version) or a custom string.  If you set it
+to a string, be sure to use a valid format, see RFC 2616.
 
 @end table
 
Index: texi/ChangeLog
===================================================================
RCS file: /usr/local/cvsroot/gnus/texi/ChangeLog,v
retrieving revision 6.464
diff -u -r6.464 ChangeLog
--- texi/ChangeLog	24 Feb 2003 03:16:20 -0000	6.464
+++ texi/ChangeLog	24 Feb 2003 16:58:03 -0000
@@ -1,3 +1,8 @@
+2003-02-24  Reiner Steib  <Reiner.Steib@gmx.de>
+
+	* gnus.texi (Mail and Post): Added `gnus-user-agent', removed
+	`gnus-version-expose-system'.
+
 2003-02-24  Jesper Harder  <harder@ifa.au.dk>
 
 	* gnus.texi: Markup fixes.
Index: lisp/gnus-msg.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-msg.el,v
retrieving revision 6.121
diff -u -r6.121 gnus-msg.el
--- lisp/gnus-msg.el	23 Feb 2003 12:32:18 -0000	6.121
+++ lisp/gnus-msg.el	24 Feb 2003 16:58:03 -0000
@@ -283,10 +283,21 @@
   :group 'gnus-message
   :type 'boolean)
 
-(defcustom gnus-version-expose-system nil
-  "If non-nil, `system-configuration' is exposed in `gnus-extended-version'."
+(defcustom gnus-user-agent 'full
+  "Which information should be exposed in the User-Agent header.
+
+It can be one of the symbols `full' \(show full information, i.e. Emacs and
+Gnus version and system configuration\), `emacs-gnus' \(show only Emacs and
+Gnus version\), `emacs-gnus-type' \(same as `emacs-gnus' plus system type\),
+`gnus' \(show only Gnus version\) or a custom string.  If you set it to a
+string, be sure to use a valid format, see RFC 2616."
   :group 'gnus-message
-  :type 'boolean)
+  :type '(choice (item :tag "Show full info" full)
+		 (item :tag "Show Gnus and Emacs versions and system type"
+		       emacs-gnus-type)
+		 (item :tag "Show Gnus and Emacs versions" emacs-gnus)
+		 (item :tag "Show only Gnus version" gnus)
+		 (string :tag "Other")))
 
 ;;; Internal variables.
 
@@ -1026,31 +1037,51 @@
   (defvar xemacs-codename))
 
 (defun gnus-extended-version ()
-  "Stringified Gnus version and Emacs version."
+  "Stringified Gnus version and Emacs version.
+See the variable `gnus-user-agent'."
   (interactive)
-  (concat
-   "Gnus/" (gnus-prin1-to-string (gnus-continuum-version gnus-version))
-   " (" gnus-version ")"
-   " "
-   (cond
-    ((string-match "^\\(\\([.0-9]+\\)*\\)\\.[0-9]+$" emacs-version)
-     (concat "Emacs/" (match-string 1 emacs-version)
-	     (if gnus-version-expose-system
-		 " (" system-configuration ")"
-	       "")))
-    ((string-match "\\([A-Z]*[Mm][Aa][Cc][Ss]\\)[^(]*\\(\\((beta.*)\\|'\\)\\)?"
-		   emacs-version)
-     (concat (match-string 1 emacs-version)
+  (let* ((gnus-v
+	  (concat "Gnus/"
+		  (prin1-to-string (gnus-continuum-version gnus-version) t)
+		  " (" gnus-version ")"))
+	 (system-v
+	  (cond
+	   ((eq gnus-user-agent 'full)
+	    system-configuration)
+	   ((eq gnus-user-agent 'emacs-gnus-type)
+	    (symbol-name system-type))
+	   (t nil)))
+	 (emacs-v
+	  (cond
+	   ((eq gnus-user-agent 'gnus)
+	    nil)
+	   ((string-match "^\\(\\([.0-9]+\\)*\\)\\.[0-9]+$" emacs-version)
+	    (concat "Emacs/" (match-string 1 emacs-version)
+		    (if system-v
+			(concat " (" system-v ")")
+		      "")))
+	   ((string-match
+	     "\\([A-Z]*[Mm][Aa][Cc][Ss]\\)[^(]*\\(\\((beta.*)\\|'\\)\\)?"
+	     emacs-version)
+	    (concat
+	     (match-string 1 emacs-version)
 	     (format "/%d.%d" emacs-major-version emacs-minor-version)
 	     (if (match-beginning 3)
 		 (match-string 3 emacs-version)
 	       "")
 	     (if (boundp 'xemacs-codename)
-	     (if gnus-version-expose-system
-		 (concat " (" xemacs-codename ", " system-configuration ")")
-	       (concat " (" xemacs-codename ")"))
-	     "")))
-    (t emacs-version))))
+		 (concat
+		  " (" xemacs-codename
+		  (if system-v
+		      (concat ", " system-v ")")
+		    ")"))
+	       "")))
+	   (t emacs-version))))
+    (if (stringp gnus-user-agent)
+	gnus-user-agent
+      (concat gnus-v
+	      (when emacs-v
+		(concat " " emacs-v))))))
 
 \f
 ;;;
Index: lisp/ChangeLog
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/ChangeLog,v
retrieving revision 6.2043
diff -u -r6.2043 ChangeLog
--- lisp/ChangeLog	24 Feb 2003 16:20:06 -0000	6.2043
+++ lisp/ChangeLog	24 Feb 2003 16:58:03 -0000
@@ -1,3 +1,10 @@
+2003-02-24  Reiner Steib  <Reiner.Steib@gmx.de>
+
+	* gnus-msg.el (gnus-user-agent): New variable.
+	(gnus-version-expose-system): Removed.  Obsoleted by
+	`gnus-user-agent'.
+	(gnus-extended-version): Use `gnus-user-agent'.
+
 2003-02-24  Ted Zlatanov <tzz@lifelogs.com>
 	From Michael Shields  <shields@msrl.com>
 

[-- Attachment #3: Type: text/plain, Size: 117 bytes --]



Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/

Re: User-Agent string

[Vasily Korytov]

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]

>>>>> "RS" == Reiner Steib writes:

 RS> On Sat, Feb 22 2003, Lars Magne Ingebrigtsen wrote:
 >> Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:
 >> 
 >>> To make it easier for the user to expose less information, we could
 >>> add something like this...
 >>> 
 >>> --8<---------------cut here---------------start------------->8---
 >>> (defcustom gnus-user-agent 'full
 >>> "Which information should be exposed in the User-Agent header.
 >> 
 >> I think this makes most sense -- letting the user decide.

 RS> The attached patch contains code, documentation and ChangeLog entries
 RS> for this.

Maybe, we should consider replacing 'full with 'emacs-gnus-type (that
is, no system-configuration exposion). I see two reasons for that:

1. Those two types seem to serve the same purpose. For me, they're
   identical, but:

2. As it was said somewhere in the thread, system-configuration may
   reveal some security-sensitive information. Besides, it's sometimes
   very igly.

-- 
       I accept RFC3156 and RFC1991-compatible encrypted mail.
PGP key fingerprint: 123A 7CCE 6E26 6233 0D87 E01A A0F8 3524 FCD8 1841

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: User-Agent string

[Kai Großjohann]

Aside: I think it's better to omit the ChangeLog entries from the
patch; they also cause spurious conflicts.  It seems it's easier to
just copy and paste them from the message into the corresponding
files.

And if you say whether it goes in lisp/ChangeLog or texi/ChangeLog,
then that would make it even easier ;-)
-- 
A preposition is not a good thing to end a sentence with.

Re: User-Agent string

[Reiner Steib]

On Mon, Feb 24 2003, Vasily Korytov wrote:

>>>>>> "RS" == Reiner Steib writes:
>  RS> On Sat, Feb 22 2003, Lars Magne Ingebrigtsen wrote:
[...]
>  >>> (defcustom gnus-user-agent 'full
[...]
>  >> I think this makes most sense -- letting the user decide.

While writing the code I forgot, that my suggestion was to use
system-type as default.  Sorry.

| (defcustom gnus-user-agent 'full [...]
|   :type '(choice (item :tag "Show full info" full) ;; system-type

> Maybe, we should consider replacing 'full with 'emacs-gnus-type (that
> is, no system-configuration exposion). 
[...]
> 2. As it was said somewhere in the thread, system-configuration may
>    reveal some security-sensitive information. 

I did a quick Google search for »User-Agent: Oort Gnus msvc«.  Now I
agree that the default might expose too much (in case of Windows, at
least) and should be changed to use system-type only.

Unless there are objections, I shall change the default to use
system-type and leave system-configuration as an option.

>    Besides, it's sometimes very igly.

igly[1]? Did you mean `bigly' or `ugly'?  The `xemacs-codename' part
may also be quite long.  (Mozilla's User-Agent string too.)

Bye, Reiner.

[1] <URL: http://dict.leo.org/?search=igly&searchLoc=-1>;
,----[ dict igly ]
| No definitions found for "igly", perhaps you mean:
| web1913:  Ugly  Idly  Illy  Inly
| wn:  ugly  idly  iglu
| foldoc:  IGL
`----
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/

Re: User-Agent string

[Vasily Korytov]

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

>>>>> "RS" == Reiner Steib writes:

 RS> On Mon, Feb 24 2003, Vasily Korytov wrote:
 >> Besides, it's sometimes very igly.

 RS> igly[1]? Did you mean `bigly' or `ugly'?  The `xemacs-codename' part
 RS> may also be quite long.  (Mozilla's User-Agent string too.)

Sorry, I meant ugly. Not because it's long, just on some systems it
doesn't look nice. I often see things like `i386-unknown-freebsd4.7' or
`i386--freebsd4.5'.

-- 
       I accept RFC3156 and RFC1991-compatible encrypted mail.
PGP key fingerprint: 123A 7CCE 6E26 6233 0D87 E01A A0F8 3524 FCD8 1841

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: User-Agent string

[Reiner Steib]

On Thu, Feb 27 2003, Reiner Steib wrote:

> Unless there are objections, I shall change the default to use
> system-type and leave system-configuration as an option.

Done.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/

Re: User-Agent string

[Frank Haun]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:

> On Thu, Feb 27 2003, Reiner Steib wrote:
>
>> Unless there are objections, I shall change the default to use
>> system-type and leave system-configuration as an option.
>
> Done.

To get `system-configuration' I must set `gnus-user-agent' to `full',
because `emacs-gnus-config' isn't processed in `gnus-extended-version'.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch for gnus-msg.el --]
[-- Type: text/x-patch, Size: 371 bytes --]

--- gnus-msg.el.~6.123.~	2003-03-01 22:49:13.000000000 +0100
+++ gnus-msg.el	2003-03-01 23:44:41.000000000 +0100
@@ -1048,7 +1048,7 @@
 		  " (" gnus-version ")"))
 	 (system-v
 	  (cond
-	   ((eq gnus-user-agent 'full)
+	   ((eq gnus-user-agent 'emacs-gnus-config)
 	    system-configuration)
 	   ((eq gnus-user-agent 'emacs-gnus-type)
 	    (symbol-name system-type))

[-- Attachment #3: Type: text/plain, Size: 7 bytes --]


Frank

Re: User-Agent string

[Reiner Steib]

On Sun, Mar 02 2003, Frank Haun wrote:

> To get `system-configuration' I must set `gnus-user-agent' to `full',
> because `emacs-gnus-config' isn't processed in `gnus-extended-version'.

Oops, sorry.  Fixed.  The manual entry has been fixed, too.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/