Test: alternative multipart in a mixed multipart

Test: alternative multipart in a mixed multipart

[Shenghuo ZHU]

[-- Attachment #1: Type: text/plain, Size: 7 bytes --]

Part1


[-- Attachment #2.1: Type: text/plain, Size: 6 bytes --]

Test


[-- Attachment #2.2: Type: image/gif, Size: 2032 bytes --]

[-- Attachment #3: Type: text/plain, Size: 6 bytes --]

Part3

Re: Test: alternative multipart in a mixed multipart

[Lars Magne Ingebrigtsen]

Shenghuo ZHU <zsh@cs.rochester.edu> writes:

> Part1

This actually works in 0.39.  Strange, but true.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Test: alternative multipart in a mixed multipart

[Shenghuo ZHU]

After applying the patch, it will shown as

[1. text/plain]
Part1


[*] text/plain          [ ] image/gif           

Test

  
[2. text/plain]

Part3

This patch is a bit ugly. It seems better to split
gnus-mime-display-alternative into initial function and callback
function.

-- 
Shenghuo

:- cut --------------------------------
--- ChangeLog	1998/10/25 04:56:31	1.1
+++ ChangeLog	1998/10/25 05:01:04
@@ -1,3 +1,8 @@
+Sun Oct 25 00:59:23 1998  Shenghuo ZHU  <zsh@cs.rochester.edu>
+
+	* gnus-art.el (gnus-mime-display-alternative): Show alternative
+ 	multipart with other parts in a mixed multipart.
+
 Sat Oct 24 16:48:51 1998  Shenghuo ZHU  <zsh@cs.rochester.edu>
 
 	* mm-uu.el (mm-uu-dissect): Delete the begining spurious newline

--- gnus-art.el	1998/10/25 04:56:12	1.1
+++ gnus-art.el	1998/10/25 04:57:37
@@ -2400,18 +2400,14 @@
       (goto-char (point-max)))))
 
 (defun gnus-mime-display-alternative (handles &optional preferred)
-  (let* ((preferred (mm-preferred-alternative handles preferred))
+  (let* ((is-callback preferred)
+	 (preferred (mm-preferred-alternative handles preferred))
 	 (ihandles handles)
 	 (point (point))
 	 handle buffer-read-only from)
-    (goto-char (point-min))
-    (search-forward "\n\n" nil t)
-    (delete-region (point) (point-max))
-    (when preferred
-      ;; Top-level call; we clean up.
-      (mm-remove-parts gnus-article-mime-handles)
-      (setq gnus-article-mime-handles handles
-	    gnus-article-mime-handle-alist nil))
+    (when is-callback
+      (delete-region (gnus-point-at-bol) (progn (forward-line 1) (point)))
+      (mm-remove-parts handles))
     (while (setq handle (pop handles))
       (gnus-add-text-properties
        (setq from (point))
@@ -2437,12 +2433,18 @@
 			     :action 'gnus-widget-press-button
 			     :button-keymap gnus-widget-button-keymap)
       (insert "  "))
-    (insert "\n\n")
+    (insert "\n")
+    (if is-callback nil
+      (insert "\n")
+      (goto-char (point-max)))
     (when preferred
       (if (stringp (car preferred))
 	  (gnus-display-mime preferred)
 	(mm-display-part preferred)))
-    (goto-char point)))
+    (if is-callback
+	(goto-char point)
+      (goto-char (point-max))
+      (insert "\n"))))
 
 (defun gnus-article-wash-status ()
   "Return a string which display status of article washing."

Re: Test: alternative multipart in a mixed multipart

[Vladimir Volovich]

"ZSH" == Shenghuo ZHU writes:

 ZSH> After applying the patch, it will shown as

 ZSH> [1. text/plain] Part1


 ZSH> [*] text/plain [ ] image/gif

 ZSH> Test
  
 ZSH> [2. text/plain]

 ZSH> Part3


I wonder, should it be looking like

[1. text/plain]
Part1


2. [*] text/plain          [ ] image/gif           

Test

  
[3. text/plain]

Part3

because part numbering is wrong for the first variant. Also, when
digestifying this with pgnus 0.39, i get

   [  76: Shenghuo ZHU        ] <* mixed> Test: alternative multipart in a mixed multipart
       [  58: Shenghuo ZHU        ] <1.* alternative>
           [  46: Shenghuo ZHU        ] <1.1 gif>
       [   2: Shenghuo ZHU        ] <2 text>

which seems also wrong (the first part simply did not appear; the text
part of multipart also did not appear; and numbering is wrong). The
correct way of displaying is imho the following:

   [  76: Shenghuo ZHU        ] <* mixed> Test: alternative multipart in a mixed multipart
       [  ??: Shenghuo ZHU        ] <1 text>
       [  58: Shenghuo ZHU        ] <2.* alternative>
           [  46: Shenghuo ZHU        ] <2.1 gif>
           [  ??: Shenghuo ZHU        ] <2.2 text>
       [   2: Shenghuo ZHU        ] <3 text>

	Best regards, -- Vladimir.

Re: Test: alternative multipart in a mixed multipart

[Lars Magne Ingebrigtsen]

Vladimir Volovich <vvv@vvv.vsu.ru> writes:

> I wonder, should it be looking like
> 
> [1. text/plain]
> Part1
> 
> 2. [*] text/plain          [ ] image/gif           

I don't know.  I don't see much point in being able to `2 b' the
multipart/alternative part...

> because part numbering is wrong for the first variant. Also, when
> digestifying this with pgnus 0.39, i get
> 
>    [  76: Shenghuo ZHU        ] <* mixed> Test: alternative multipart in a mixed multipart
>        [  58: Shenghuo ZHU        ] <1.* alternative>
>            [  46: Shenghuo ZHU        ] <1.1 gif>
>        [   2: Shenghuo ZHU        ] <2 text>

Yup.  Fix in Pterodactyl Gnus v0.40.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Test: alternative multipart in a mixed multipart

[Robert Bihlmeyer]

Hi,

>>>>> On 25 Oct 1998 17:57:55 +0100
>>>>> Lars Magne Ingebrigtsen <larsi@gnus.org> said:

 Lars> I don't know. I don't see much point in being able to `2 b' the
 Lars> multipart/alternative part...

How do a switch between the alternatives then? Movinge the
cursor/mouse to it and RETing/clicking it? "b" functionality seems a
lot more convenient.

	Robbe

-- 
Robert Bihlmeyer	reads: Deutsch, English, MIME, Latin-1, NO SPAM!
<robbe@orcus.priv.at>	<http://stud2.tuwien.ac.at/~e9426626/sig.html>

Re: Test: alternative multipart in a mixed multipart

[Lars Magne Ingebrigtsen]

Robert Bihlmeyer <e9426626@stud2.tuwien.ac.at> writes:

> How do a switch between the alternatives then? Movinge the
> cursor/mouse to it and RETing/clicking it? "b" functionality seems a
> lot more convenient.

I guess to.  `b' on the multipart/alternative part would then rotate
between the alternatives?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Test: alternative multipart in a mixed multipart

[Robert Bihlmeyer]

Hi,

>>>>> On 28 Oct 1998 08:25:32 +0100
>>>>> Lars Magne Ingebrigtsen <larsi@gnus.org> said:

 Lars> I guess to. `b' on the multipart/alternative part would then
 Lars> rotate between the alternatives?

That would be nice, yes.

	Robbe

-- 
Robert Bihlmeyer	reads: Deutsch, English, MIME, Latin-1, NO SPAM!
<robbe@orcus.priv.at>	<http://stud2.tuwien.ac.at/~e9426626/sig.html>

Re: Test: alternative multipart in a mixed multipart

[Lars Magne Ingebrigtsen]

Robert Bihlmeyer <e9426626@stud2.tuwien.ac.at> writes:

>  Lars> I guess to. `b' on the multipart/alternative part would then
>  Lars> rotate between the alternatives?
> 
> That would be nice, yes.

Yup.  Fix in Pterodactyl Gnus v0.41.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Test: alternative multipart in a mixed multipart

[Hrvoje Niksic]

Shenghuo ZHU <zsh@cs.rochester.edu> writes:
[...]

In 0.40: the message is shown correctly, but...  If I click on the
image/gif part, I get the GIF in the same line with [2. text/plain]
part.  When I click on the [2. ] part, the GIF is lost.

-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
Jone's law: The man who smiles when things go wrong has thought of
someone to blame it on.

Re: Test: alternative multipart in a mixed multipart

[Shenghuo ZHU]

>>>>> "Hrvoje" == Hrvoje Niksic <hniksic@srce.hr> writes:

Hrvoje> Shenghuo ZHU <zsh@cs.rochester.edu> writes:
Hrvoje> [...]

Hrvoje> In 0.40: the message is shown correctly, but...  If I click on
Hrvoje> the image/gif part, I get the GIF in the same line with
Hrvoje> [2. text/plain] part.  When I click on the [2. ] part, the GIF
Hrvoje> is lost.

gnus-mm-display-part deletes the line of old mime-button then creates
a new one. Unfortunately, the image is in the same line with
mime-button.

How about adding a "\n" in mm-inline-image?

-- 
Shenghuo

Re: Test: alternative multipart in a mixed multipart

[Lars Magne Ingebrigtsen]

Hrvoje Niksic <hniksic@srce.hr> writes:

> In 0.40: the message is shown correctly, but...  If I click on the
> image/gif part, I get the GIF in the same line with [2. text/plain]
> part.  When I click on the [2. ] part, the GIF is lost.

Yup.  Fix in Pterodactyl Gnus v0.41.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen