Gnus development mailing list
 help / color / mirror / Atom feed
From: Daiki Ueno <ueno@unixuser.org>
To: ding@gnus.org
Subject: Re: Accepting x-pkcs7-signature
Date: Fri, 23 Jul 2010 17:53:16 +0900	[thread overview]
Message-ID: <m3hbjqlgub.fsf-ueno@unixuser.org> (raw)
In-Reply-To: <87y6d3z0f4.fsf@randomsample.de> (David Engster's message of "Thu, 22 Jul 2010 23:11:59 +0200")

Hi David,

David Engster <deng@randomsample.de> writes:

> I still have this old patch lying around, which lets Gnus accept
> signatures with a x-pkcs7-signature MIME type, instead of just
> "pkcs7-signature".

Agreed.

> Does anyone see a problem with this patch?

I admittedly have not tested it yet, but:

> --- mml-smime.el.~7.23.~	2008-05-19 10:47:42.000000000 +0200
> +++ mml-smime.el	2008-09-17 11:56:12.000000000 +0200
> @@ -520,10 +520,14 @@
>  					   ctl 'protocol)
>  					  "application/pkcs7-signature")

^^ this line should also be changed to accept "x-pkcs7-signature"?

>  				  t)))
> -		(null (setq signature (mm-find-part-by-type
> -				       (cdr handle)
> -				       "application/pkcs7-signature"
> -				       nil t))))
> +		(null (setq signature (or (mm-find-part-by-type
> +					   (cdr handle)
> +					   "application/pkcs7-signature"
> +					   nil t)
> +					  (mm-find-part-by-type
> +					   (cdr handle)
> +					   "application/x-pkcs7-signature"
> +					   nil t)))))

Regards,
-- 
Daiki Ueno



  reply	other threads:[~2010-07-23  8:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-22 21:11 David Engster
2010-07-23  8:53 ` Daiki Ueno [this message]
2010-07-23 10:32   ` David Engster
2010-07-23 14:57     ` Daiki Ueno
2010-07-23 18:13       ` David Engster
2010-07-24  1:21         ` Daiki Ueno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3hbjqlgub.fsf-ueno@unixuser.org \
    --to=ueno@unixuser.org \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).