void-variable gnus-face-properties-alist

void-variable gnus-face-properties-alist

[Reiner Steib]

Hi,

in the German-speaking Gnus newsgroup, I got the following report from
Wolfgang Bauer.

When displaying an article containing a Face header, Wolfgang got the
backtrace:

--8<---------------cut here---------------start------------->8---
Debugger entered--Lisp error: (void-variable gnus-face-properties-alist)
  article-display-face()
  apply(article-display-face nil)
  (if interactive (call-interactively (quote article-display-face))
    (apply (quote article-display-face) args))
  (save-excursion (set-buffer gnus-article-buffer) (if interactive
    (call-interactively ...) (apply ... args)))
  gnus-article-display-face()
  gnus-treat-article(head)
  gnus-display-mime()
  gnus-article-prepare-display()
  gnus-article-prepare(23029 nil)
  gnus-summary-display-article(23029 nil)
  gnus-summary-select-article(nil nil pseudo)
  gnus-summary-scroll-up(1)
* call-interactively(gnus-summary-scroll-up)
--8<---------------cut here---------------end--------------->8---

AFAICS, `article-display-face' uses `gnus-face-properties-alist', but
`gnus-fun' is not loaded:

--8<---------------cut here---------------start------------->8---
(eval-when-compile
  (defvar gnus-face-properties-alist))

(defun article-display-face ()
  "Display any Face headers in the header."
  (interactive)
[...]
			(apply 'gnus-create-image png 'png t
			       (cdr (assq 'png gnus-face-properties-alist))))
--8<---------------cut here---------------end--------------->8---

Should we add (require 'gnus-fun) inside the defun or move the
defcustom to `gnus-art.el'?  (Or something else?)

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: void-variable gnus-face-properties-alist

[Lars Magne Ingebrigtsen]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> Should we add (require 'gnus-fun) inside the defun or move the
> defcustom to `gnus-art.el'?  (Or something else?)

I don't really like having `require's in functions, but in this case,
I guess it's the right thing to do.  I'll commit the change.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: void-variable gnus-face-properties-alist

[Lars Magne Ingebrigtsen]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

>> Should we add (require 'gnus-fun) inside the defun or move the
>> defcustom to `gnus-art.el'?  (Or something else?)
>
> I don't really like having `require's in functions, but in this case,
> I guess it's the right thing to do.  I'll commit the change.

I changed my mind.  I moved the defcustom to gnus-art.el.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen