From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/39679 Path: main.gmane.org!not-for-mail From: prj@po.cwru.edu (Paul Jarc) Newsgroups: gmane.emacs.gnus.general Subject: Re: new Mail-Followup-To patch...please take a look... Date: Wed, 24 Oct 2001 12:13:21 -0400 Organization: What did you have in mind? A short, blunt, human pyramid? Sender: owner-ding@hpc.uh.edu Message-ID: References: <87wv1m9y6j.fsf@mclinux.com> <87bsixhk7t.fsf@mclinux.com> NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1035175353 29255 80.91.224.250 (21 Oct 2002 04:42:33 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 21 Oct 2002 04:42:33 +0000 (UTC) Return-Path: Original-Received: (qmail 7759 invoked from network); 24 Oct 2001 16:15:46 -0000 Original-Received: from malifon.math.uh.edu (mail@129.7.128.13) by mastaler.com with SMTP; 24 Oct 2001 16:15:46 -0000 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 15wQfF-0006kK-00; Wed, 24 Oct 2001 11:13:57 -0500 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Wed, 24 Oct 2001 11:13:34 -0500 (CDT) Original-Received: from sclp3.sclp.com (qmailr@sclp3.sclp.com [209.196.61.66]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id LAA12290 for ; Wed, 24 Oct 2001 11:13:22 -0500 (CDT) Original-Received: (qmail 7700 invoked by alias); 24 Oct 2001 16:13:22 -0000 Original-Received: (qmail 7695 invoked from network); 24 Oct 2001 16:13:21 -0000 Original-Received: from multivac.student.cwru.edu (HELO multivac.cwru.edu) (qmail-remote@129.22.96.25) by gnus.org with SMTP; 24 Oct 2001 16:13:21 -0000 Original-Received: (qmail 31459 invoked by uid 500); 24 Oct 2001 16:13:43 -0000 Mail-Followup-To: ding@gnus.org Original-To: ding@gnus.org Mail-Copies-To: never In-Reply-To: <87bsixhk7t.fsf@mclinux.com> (Josh Huber's message of "Tue, 23 Oct 2001 21:59:02 -0400") Original-Lines: 63 User-Agent: Gnus/5.090004 (Oort Gnus v0.04) Emacs/20.7 Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:39679 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:39679 Josh Huber wrote: > +(defvar gnus-group-dirty-flag nil) The name's rather vague. But if Per's functions are fast enough, then I agree that caching is not worthwhile anyway. > +(defun gnus-find-subscribed-addresses-real () > + "Return a regexp matching the addresses of all subscribed mail groups. Since this is used in message-subscribed-address-functions: > + (mft-regexps (apply 'append message-subscribed-regexps > + (mapcar 'regexp-quote > + message-subscribed-addresses) > + (mapcar 'funcall > + message-subscribed-address-functions)))) Shouldn't it return a list of regexps (possibly just one, but still a list)? > + (progn > + (setq gnus-group-dirty-flag nil) > + (setq gnus-group-parameter-cache gnus-parameters) > + (setq gnus-subscribed-addresses > + (gnus-find-subscribed-addresses-real))))) (Assuming caching is not discarded...) Better to make that gnus-atomic-progn, or to rearrange like so: (progn (setq gnus-subscribed-addresses (gnus-find-subscribed-addresses-real)) (setq gnus-group-dirty-flag nil) (setq gnus-group-parameter-cache gnus-parameters) gnus-subscribed-addresses) Otherwise a C-g could come in after we've updated our flags, but before we've recalculated the subscribed addresses, thus making our regexp falsely seem up to date. > +(defvar message-subscribed-address-functions '(ignore) > + "*Specifies functions for determining list subscription. The structure of the return value needs to be documented, and "specifies" seems to be unnecessary, judging by existing docstrings. "*A list of functions, each returning a list of regular expressions matching addresses of mailing lists the the user is subscribed to."? > +If nil, do not attempt to determine list subscribtion with functions. > +If non-nil, this variable contains a list of functions which return > +regular expressions to match lists. nil is a list; I don't think it needs to be separately documented. > +(defun message-goto-mail-followup-to () > + "Move point to the Mail-Followup-To header." > + (interactive) > + (message-position-on-field "Mail-Followup-To" "From")) > + This, at least (along with its key and menu bindings), can be committed now, I think. paul