* float-pi (was: [gnus git] branch master updated: =5= Add color check support with shr-color ; shr: add tag font ; Revert "Drop colorisation of regions since we don't control the background color." ; shr-color: import ; color-lab: new)
[not found] <E1PKYPn-0003yn-00@quimby.gnus.org>
@ 2010-11-22 18:37 ` Sven Joachim
2010-11-22 18:41 ` float-pi Lars Magne Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Sven Joachim @ 2010-11-22 18:37 UTC (permalink / raw)
To: ding
In Emacs 23.2 (and earlier), compiling color-lab.el triggers warnings
because float-pi is not defined. It would probably be good to check if
float-pi is bound before using it.
Cheers,
Sven
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: float-pi
2010-11-22 18:37 ` float-pi (was: [gnus git] branch master updated: =5= Add color check support with shr-color ; shr: add tag font ; Revert "Drop colorisation of regions since we don't control the background color." ; shr-color: import ; color-lab: new) Sven Joachim
@ 2010-11-22 18:41 ` Lars Magne Ingebrigtsen
2010-11-23 7:32 ` float-pi Sven Joachim
0 siblings, 1 reply; 6+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-11-22 18:41 UTC (permalink / raw)
To: ding
Sven Joachim <svenjoac@gmx.de> writes:
> In Emacs 23.2 (and earlier), compiling color-lab.el triggers warnings
> because float-pi is not defined. It would probably be good to check if
> float-pi is bound before using it.
shr.el and friends are for Emacs 24 only, so compiling color-lab should
probably be disabled on Emacs 23, I guess...
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: float-pi
2010-11-22 18:41 ` float-pi Lars Magne Ingebrigtsen
@ 2010-11-23 7:32 ` Sven Joachim
2010-11-23 9:18 ` float-pi Julien Danjou
0 siblings, 1 reply; 6+ messages in thread
From: Sven Joachim @ 2010-11-23 7:32 UTC (permalink / raw)
To: ding
On 2010-11-22 19:41 +0100, Lars Magne Ingebrigtsen wrote:
> Sven Joachim <svenjoac@gmx.de> writes:
>
>> In Emacs 23.2 (and earlier), compiling color-lab.el triggers warnings
>> because float-pi is not defined. It would probably be good to check if
>> float-pi is bound before using it.
>
> shr.el and friends are for Emacs 24 only, so compiling color-lab should
> probably be disabled on Emacs 23, I guess...
That would be annoying for people who share the same Gnus installation
between Emacs 23 and Emacs 24. And it's easy to define float-pi
yourself:
(unless (boundp 'float-pi)
(defconst float-pi (* 4 (atan 1)) "The value of Pi (3.1415926...)."))
Cheers,
Sven
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: float-pi
2010-11-23 7:32 ` float-pi Sven Joachim
@ 2010-11-23 9:18 ` Julien Danjou
2010-11-23 14:53 ` float-pi Ted Zlatanov
0 siblings, 1 reply; 6+ messages in thread
From: Julien Danjou @ 2010-11-23 9:18 UTC (permalink / raw)
To: ding
On Tue, Nov 23 2010, Sven Joachim wrote:
> That would be annoying for people who share the same Gnus installation
> between Emacs 23 and Emacs 24. And it's easy to define float-pi
> yourself:
>
> (unless (boundp 'float-pi)
> (defconst float-pi (* 4 (atan 1)) "The value of Pi (3.1415926...)."))
Yes, but I don't see the point of adding support for Emacs < 24 in code
which will never be run in Emacs 24. :-/ Compat for old Emacs is already
a PITA everywhere.
Maybe just ignore the warnings? :)
--
Julien Danjou
// ᐰ <julien@danjou.info> http://julien.danjou.info
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: float-pi
2010-11-23 9:18 ` float-pi Julien Danjou
@ 2010-11-23 14:53 ` Ted Zlatanov
2010-11-23 16:02 ` float-pi Julien Danjou
0 siblings, 1 reply; 6+ messages in thread
From: Ted Zlatanov @ 2010-11-23 14:53 UTC (permalink / raw)
To: ding
On Tue, 23 Nov 2010 10:18:38 +0100 Julien Danjou <julien@danjou.info> wrote:
JD> On Tue, Nov 23 2010, Sven Joachim wrote:
>> That would be annoying for people who share the same Gnus installation
>> between Emacs 23 and Emacs 24. And it's easy to define float-pi
>> yourself:
>>
>> (unless (boundp 'float-pi)
>> (defconst float-pi (* 4 (atan 1)) "The value of Pi (3.1415926...)."))
JD> Yes, but I don't see the point of adding support for Emacs < 24 in code
JD> which will never be run in Emacs 24. :-/ Compat for old Emacs is already
JD> a PITA everywhere.
JD> Maybe just ignore the warnings? :)
I think color-lab.el will quickly become popular and people will ask for
Emacs 23 support without needing shr.el. Considering how simple the fix
is, I think it should be implemented.
Ted
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-11-23 16:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1PKYPn-0003yn-00@quimby.gnus.org>
2010-11-22 18:37 ` float-pi (was: [gnus git] branch master updated: =5= Add color check support with shr-color ; shr: add tag font ; Revert "Drop colorisation of regions since we don't control the background color." ; shr-color: import ; color-lab: new) Sven Joachim
2010-11-22 18:41 ` float-pi Lars Magne Ingebrigtsen
2010-11-23 7:32 ` float-pi Sven Joachim
2010-11-23 9:18 ` float-pi Julien Danjou
2010-11-23 14:53 ` float-pi Ted Zlatanov
2010-11-23 16:02 ` float-pi Julien Danjou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).