From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/41051 Path: main.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.gnus.general Subject: Re: "seen" marks create adjacent lists Date: Sat, 29 Dec 2001 03:54:59 +0100 Organization: Programmerer Ingebrigtsen Sender: owner-ding@hpc.uh.edu Message-ID: References: NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1035176510 4137 80.91.224.250 (21 Oct 2002 05:01:50 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 21 Oct 2002 05:01:50 +0000 (UTC) Return-Path: Original-Received: (qmail 26540 invoked from network); 29 Dec 2001 03:00:09 -0000 Original-Received: from malifon.math.uh.edu (mail@129.7.128.13) by mastaler.com with SMTP; 29 Dec 2001 03:00:09 -0000 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 16K9im-0005gg-00; Fri, 28 Dec 2001 20:59:40 -0600 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Fri, 28 Dec 2001 20:59:31 -0600 (CST) Original-Received: from sclp3.sclp.com (qmailr@sclp3.sclp.com [209.196.61.66]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id UAA24119 for ; Fri, 28 Dec 2001 20:59:19 -0600 (CST) Original-Received: (qmail 26514 invoked by alias); 29 Dec 2001 02:59:22 -0000 Original-Received: (qmail 26509 invoked from network); 29 Dec 2001 02:59:22 -0000 Original-Received: from quimby.gnus.org (HELO quimby2.netfonds.no) (195.204.10.66) by gnus.org with SMTP; 29 Dec 2001 02:59:22 -0000 Original-Received: from news by quimby2.netfonds.no with local (Exim 3.12 #1 (Debian)) id 16K9x1-0005ic-00 for ; Sat, 29 Dec 2001 04:14:23 +0100 Original-To: ding@gnus.org Original-Path: not-for-mail Original-Newsgroups: gnus.ding Original-Lines: 67 Original-NNTP-Posting-Host: quimbies.gnus.org Original-X-Trace: quimby2.netfonds.no 1009595663 21985 195.204.10.148 (29 Dec 2001 03:14:23 GMT) Original-X-Complaints-To: usenet@quimby2.netfonds.no Original-NNTP-Posting-Date: 29 Dec 2001 03:14:23 GMT Mail-Copies-To: never X-Now-Playing: Various's _Staedtizism 2_: "Headset - Dustmite" User-Agent: Gnus/5.090004 (Oort Gnus v0.04) Emacs/21.0.104 (i686-pc-linux-gnu) X-Face: &w!^oO~dS|}-P0~ge{$c!h\ writes: > I've noticed that "seen" marks have a pronounced tendency to create > pointlessly adjacent number lists, rather than subsuming new items > into existing lists. Here's an example: [...] > - (105429 . 106775))) > + (105429 . 106776) > + 106777)) > (nntp "news")) > ("nntp+news:comp.protocols.dns.ops" 3 > ((1 . 93004)) > > Before this particular run of Gnus, I'd seen up through 106775. When > I ran Gnus, there were 2 articles there, which I read (or at least > used `d' on), and Gnus correctly identifies that I've seen up through > 106777 now. This must be a bug in the range handling functions... Hm... This is the code that does the updating: (when (eq (cdr type) 'seen) (setq list (if list (gnus-range-add (gnus-uncompress-sequence list) gnus-newsgroup-unseen) (gnus-compress-sequence gnus-newsgroup-articles)))) First of all -- we see that the code is wonky. It uncompresses the range of seen articles, which will give us a rather huge list of articles after a while. However: (gnus-range-add (gnus-uncompress-sequence '((105429 . 106775))) '(106776 106777)) => ((105429 . 106777)) It does seem to give us the right results. Can you reproduce this error? Removing the uncompress thing gives us the same answer. (gnus-range-add '((105429 . 106775)) '(106776 106777)) => ((105429 . 106777)) (I've now done this in the source as well.) > In some very busy groups I read, this has induced some really > impressively large "seen" lists, all numerically adjacent. I've looked over my .newsrc.eld file, and I don't see that. However, I do see lots of huge seen lists, with an article missing here and there, and that's probably due to cross-post handling. And, looking over the code, I see that I've forgotten to write code to remove seen ranges outside the range of active articles. I've now fixed this as well. -- (domestic pets only, the antidote for overdose, milk.) larsi@gnus.org * Lars Magne Ingebrigtsen