Gnus development mailing list
 help / color / mirror / Atom feed
From: Lars Magne Ingebrigtsen <larsi@gnus.org>
Subject: Re: New completion mode
Date: Sat, 22 Apr 2006 02:01:20 +0200	[thread overview]
Message-ID: <m3lktywka7.fsf@quimbies.gnus.org> (raw)
In-Reply-To: <b4msloa3u1p.fsf@jpl.org>

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> The regexp used in `message-put-addresses-in-ecomplete' causes
> an infloop in XEmacs.  The test case is:
>
>    (gnus-replace-in-string "yamaoka@jpl.org" "^ +\\| *$" "")
>
> It might be due to an XEmacs bug.  Though it seems to be solved
> by replacing the regexp with "^ +\\| +$".

Ok; done.

> The completions list appears only when a user invokes the
> `self-insert-command' command.  Especially in Japan, people use
> various tools in order to write Japanese text.  Some tools
> replace `self-insert-command' with the other command, e.g.,
> `egg-self-insert-char', in many keys, and it is used even when
> writing ASCII text.  So, we need to make changes in message.el
> like the following:
>
> (defcustom message-self-insert-commands '(self-insert-command)

Yup.  I wonder whether there's a simpler solution to make this work
automatically.  The point of the check for `self-insert-command' was
just to avoid having the code trigger on totally automatic header
setup stuff.  (It would flash "No ecomplete matches" while generating
the header.)

But I don't see any obvious way to fix this, so I've installed your
change.

> Therefore, I make a proposal to add a variable like
> `ecomplete-database-file-coding-system'.  I think the best
> choice for the default value is `iso-2022-7bit' which all
> Emacsen (with Mule) support.

Ok; I'll make this change.

> Putting the coding cookie to the rc file would also be good.  It
> enables people to manually edit the rc file safely and informs
> non-Mule XEmacs whether the contents can be used and modified.

What should the cookie look like?

> Mail-abbrevs is still useful.  So, I use
>
> (add-hook 'message-setup-hook (if (featurep 'xemacs)
> 				  'mail-aliases-setup
> 				'mail-abbrevs-setup))
>
> even if I set `message-mail-alias-type' to `ecomplete'.  How
> about making this option a list?

Will do.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen




  parent reply	other threads:[~2006-04-22  0:01 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-11 10:30 Lars Magne Ingebrigtsen
2006-04-11 15:40 ` Sam Steingold
2006-04-11 15:52   ` Lars Magne Ingebrigtsen
2006-04-11 16:02     ` Sam Steingold
2006-04-12  6:21       ` Lars Magne Ingebrigtsen
2006-04-12  7:55         ` Lars Magne Ingebrigtsen
2006-04-12 11:13           ` Reiner Steib
2006-04-12 11:35             ` Lars Magne Ingebrigtsen
2006-04-12 13:25               ` Lars Magne Ingebrigtsen
2006-04-12 14:41               ` Lars Magne Ingebrigtsen
2006-04-13  2:29 ` Wolfram Fenske
2006-04-13  5:42   ` Lars Magne Ingebrigtsen
2006-04-13 16:19     ` Wolfram Fenske
     [not found]     ` <m3bqv6av4t.fsf-qBEgNjfYAPolG3ThADb//ti2O/JbrIOy@public.gmane.org>
2006-04-13 17:31       ` Jochen Küpper
2006-04-14 10:27         ` Lars Magne Ingebrigtsen
2006-04-16 19:50           ` Use of ecomplete.el in message.el (was: New completion mode) Reiner Steib
2006-04-16 20:30             ` Use of ecomplete.el in message.el Lars Magne Ingebrigtsen
2006-04-17 11:40               ` Reiner Steib
2006-04-17 13:04                 ` Lars Magne Ingebrigtsen
2006-04-17  0:23             ` Steve Youngs
2006-04-17  9:01               ` Lars Magne Ingebrigtsen
2006-04-18 11:17           ` New completion mode Simon Josefsson
2006-04-18 13:04             ` Reiner Steib
2006-04-18 13:46               ` Simon Josefsson
2006-04-18 15:24                 ` Lars Magne Ingebrigtsen
2006-04-18 21:07                   ` Simon Josefsson
2006-04-21 23:51                     ` Lars Magne Ingebrigtsen
2006-04-14 19:26     ` Miles Bader
2006-04-15  5:46       ` Lars Magne Ingebrigtsen
2006-04-18 22:22         ` Wolfram Fenske
2006-04-19  7:26 ` Katsumi Yamaoka
2006-04-20 12:14   ` Steve Youngs
2006-04-20 13:07     ` gnus-replace-in-string: Avoid inf-loop in XEmacs (was: New completion mode) Reiner Steib
2006-04-20 14:18       ` gnus-replace-in-string: Avoid inf-loop in XEmacs Michael Olson
2006-04-20 15:23         ` Reiner Steib
2006-04-22  4:36           ` Michael Olson
2006-04-20 16:06       ` Steve Youngs
2006-04-20 17:06         ` Reiner Steib
2006-04-21  6:32     ` New completion mode Steve Youngs
2006-04-22  0:01   ` Lars Magne Ingebrigtsen [this message]
2006-04-24  8:55     ` Katsumi Yamaoka
2006-04-30  9:32       ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3lktywka7.fsf@quimbies.gnus.org \
    --to=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).