PATCH: Make nnrss include RSS dc:subject

PATCH: Make nnrss include RSS dc:subject

[Mark Plaksin]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

How about this small patch to nnrss which makes it put the RSS dc:subject
in the article?  It is especially useful for del.icio.us RSS feeds--it lets
you see the tags that were assigned to a link.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: nnrss patch for dc:subject --]
[-- Type: text/x-patch, Size: 902 bytes --]

--- gnus-cvs/lisp/nnrss.el	2005-10-19 11:00:54.000000000 -0400
+++ gnus/lisp/nnrss.el	2005-12-16 22:57:45.000000000 -0500
@@ -533,7 +533,7 @@
 ;;; Snarf functions
 
 (defun nnrss-check-group (group server)
-  (let (file xml subject url extra changed author date
+  (let (file xml subject url extra changed author date feed-subject
 	     enclosure comments rss-ns rdf-ns content-ns dc-ns)
     (if (and nnrss-use-local
 	     (file-exists-p (setq file (expand-file-name
@@ -576,6 +576,8 @@
 	(setq extra (or extra
 			(nnrss-node-text content-ns 'encoded item)
 			(nnrss-node-text rss-ns 'description item)))
+        (if (setq feed-subject (nnrss-node-text dc-ns 'subject item))
+            (setq extra (concat feed-subject "<br /><br />\n" extra)))
 	(setq author (or (nnrss-node-text rss-ns 'author item)
 			 (nnrss-node-text dc-ns 'creator item)
 			 (nnrss-node-text dc-ns 'contributor item)))

Re: PATCH: Make nnrss include RSS dc:subject

[Katsumi Yamaoka]

>>>>> In <87psnw9xf4.fsf@stone.tss.usg.edu> Mark Plaksin wrote:

> How about this small patch to nnrss which makes it put the RSS dc:subject
> in the article?  It is especially useful for del.icio.us RSS feeds--it lets
> you see the tags that were assigned to a link.

Looks good.  I've added your patch.  Thanks.

Re: PATCH: Make nnrss include RSS dc:subject

[Katsumi Yamaoka]

>>>>>> In <87psnw9xf4.fsf@stone.tss.usg.edu> Mark Plaksin wrote:

>> How about this small patch to nnrss which makes it put the RSS dc:subject
>> in the article?  It is especially useful for del.icio.us RSS feeds--it lets
>> you see the tags that were assigned to a link.

>>>>> In <b4mfyopslxm.fsf@jpl.org> Katsumi Yamaoka wrote:

> Looks good.  I've added your patch.  Thanks.

Sorry, it's not good.  I see `<br /><br />' in the article
buffer when I choose the text/plain part[1].  Any idea?  It
seems to me enough to use "\n\n\n" instead of "<br /><br />\n".

[1]
(setq gnus-buttonized-mime-types
      '("multipart/alternative" "multipart/signed")
      mm-discouraged-alternatives
      '("text/html" "image/.*"))

;; I don't usually use nnrss.

Re: PATCH: Make nnrss include RSS dc:subject

[Katsumi Yamaoka]

>>>>> In <b4mirtka4vn.fsf@jpl.org> Katsumi Yamaoka wrote:

> Sorry, it's not good.  I see `<br /><br />' in the article
> buffer when I choose the text/plain part[1].  Any idea?  It
> seems to me enough to use "\n\n\n" instead of "<br /><br />\n".

It's also bad to use "\n\n\n".  I've fixed it by replacing
`<br />'s with newlines when generating text/plain parts.  It
will not have a bad influence because only `nnrss-check-group'
inserts `<br />'s.

Re: PATCH: Make nnrss include RSS dc:subject

[Mark Plaksin]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

>>>>>> In <b4mirtka4vn.fsf@jpl.org> Katsumi Yamaoka wrote:
>
>> Sorry, it's not good.  I see `<br /><br />' in the article
>> buffer when I choose the text/plain part[1].  Any idea?  It
>> seems to me enough to use "\n\n\n" instead of "<br /><br />\n".
>
> It's also bad to use "\n\n\n".  I've fixed it by replacing
> `<br />'s with newlines when generating text/plain parts.  It
> will not have a bad influence because only `nnrss-check-group'
> inserts `<br />'s.

Thanks for fixing it!  I forgot that I put "<br /><br />" in there.  And I
never tested text/plain.

>> ;; I don't usually use nnrss.

You say this a lot.  Do you read a lot of feeds?  Do you read all of them
with nnshimbun?

I read all of my feeds in Gnus and nnrss generally does a good enough job
for me (I'm pretty easy to please :)  Sometimes nnshimbun is better
though--like for the emacswiki.org feed.  When I want to make small
changes, like the nnrss change we're discussing, I'm not sure whether it's
better to make the change in nnrss or nnshimbun.

Re: PATCH: Make nnrss include RSS dc:subject

[Katsumi Yamaoka]

>>>>> In <87y82fkbzq.fsf@stone.tss.usg.edu> Mark Plaksin wrote:

> Katsumi Yamaoka <yamaoka@jpl.org> writes:

>>> ;; I don't usually use nnrss.

> You say this a lot.  Do you read a lot of feeds?  Do you read all of them
> with nnshimbun?

Yes.  Since I am one of the maintainers and need to check that
they all are going well, I am subscribing to a lot of shimbun
groups.  I actually read only a few groups among them, though.

> I read all of my feeds in Gnus and nnrss generally does a good enough job
> for me (I'm pretty easy to please :)

I also admit the usefulness of nnrss, especially if articles
contain some text, not only links.  I have ever a bit considered
about an easy-to-use way to fetch full contents of links into
the article buffer.  It might be possible to achieve it, however
the article buffer will necessarily be filled with a large amount
of advertisement.

> Sometimes nnshimbun is better
> though--like for the emacswiki.org feed.  When I want to make small
> changes, like the nnrss change we're discussing, I'm not sure whether it's
> better to make the change in nnrss or nnshimbun.

Nnrss is sometimes good and nnshimbun is sometimes good.  Nnrss
is useful when I glance subjects in the summary buffer and pick
one, moreover nnrss need not follow to changes in news sites
since it works depending on only the xml standard.  The
advantage of nnshimbun is to remove advertisement.  However, the
module to deal with it with each news site is needed (e.g.,
sb-bbc.el for BBC), and we need to make major changes in those
modules periodically.

Re: PATCH: Make nnrss include RSS dc:subject

[Lars Magne Ingebrigtsen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> The advantage of nnshimbun is to remove advertisement.  However, the
> module to deal with it with each news site is needed (e.g.,
> sb-bbc.el for BBC), and we need to make major changes in those
> modules periodically.

Would it be possible to separate out this into something declarative
that could be downloaded at will?

The main problem with all these web-centred things is the need to
update the source code whenever the HTML changes, and I don't see any
general way to fix that.  To parse Slashdot, for instance, you
probably have to do that programmatically. 

But for stuff like ad removal, couldn't a language be defined for
that?  For instance a set of regexps (or something) that could be
applied to the article bodies before displaying (on a per-source
basis).  The user could update these rules with, say,
`M-x gnus-update-washing-rules' that would download the rules from
some central repository.

The important thing being, of course, that there would be no actual
code being downloaded, because that would be a security problem.

Heh.  Imagine rules that would remove Yahoo ads from Yahoogroups
mailing lists, and Sourceforge ads from those lists, and...

Gnus ad blocker.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: PATCH: Make nnrss include RSS dc:subject

[yamaoka]

>>>>> In <m3lkua9ffi.fsf@quimbies.gnus.org>
>>>>>	Lars Magne Ingebrigtsen wrote:

> Katsumi Yamaoka <yamaoka@jpl.org> writes:

>> The advantage of nnshimbun is to remove advertisement.  However, the
>> module to deal with it with each news site is needed (e.g.,
>> sb-bbc.el for BBC), and we need to make major changes in those
>> modules periodically.

> Would it be possible to separate out this into something declarative
> that could be downloaded at will?

This is exactly what the emacs-w3m people were considering.  It
has not been achieved yet, though.  In fact, the number of
modules is too large for a few developers to maintain nowadays.

> The main problem with all these web-centred things is the need to
> update the source code whenever the HTML changes, and I don't see any
> general way to fix that.  To parse Slashdot, for instance, you
> probably have to do that programmatically.

Yes, we will not be able to deal with everything using only
regexps.

> But for stuff like ad removal, couldn't a language be defined for
> that?  For instance a set of regexps (or something) that could be
> applied to the article bodies before displaying (on a per-source
> basis).  The user could update these rules with, say,
> `M-x gnus-update-washing-rules' that would download the rules from
> some central repository.

> The important thing being, of course, that there would be no actual
> code being downloaded, because that would be a security problem.

Or there might be a bug causing a serious accident even if it
was made with no malice.

> Heh.  Imagine rules that would remove Yahoo ads from Yahoogroups
> mailing lists, and Sourceforge ads from those lists, and...

> Gnus ad blocker.  :-)

Perhaps we had better concentrate instead on `Gnus spam blocker'.
:-)

Re: PATCH: Make nnrss include RSS dc:subject

[Lars Magne Ingebrigtsen]

<yamaoka@jpl.org> writes:

> This is exactly what the emacs-w3m people were considering.  It
> has not been achieved yet, though.  In fact, the number of
> modules is too large for a few developers to maintain nowadays.

Are there any plans to integrate emacs-w3m into Emacs?  That often
helps in getting more users (and therefore developers :-).

>> Gnus ad blocker.  :-)
>
> Perhaps we had better concentrate instead on `Gnus spam blocker'.
> :-)

But that's so difficult.  An ad blocker is much simpler.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: PATCH: Make nnrss include RSS dc:subject

[Katsumi Yamaoka]

>>>>> In <m31ww1rgb9.fsf@quimbies.gnus.org>
>>>>>	Lars Magne Ingebrigtsen <larsi@gnus.org> wrote:

> <yamaoka@jpl.org> writes:

;; Oops, I forgot to write my full name into /etc/passwd.  I'm
;; now setting up a new Linux. ;-)

>> This is exactly what the emacs-w3m people were considering.  It
>> has not been achieved yet, though.  In fact, the number of
>> modules is too large for a few developers to maintain nowadays.

> Are there any plans to integrate emacs-w3m into Emacs?  That often
> helps in getting more users (and therefore developers :-).

Richard invited us.  However, it is hard for a certain person to
assign FSF the copyright.  I haven't yet heard that he has been
successful in the negotiation with the office (which is a big
company in Japan). :<

Re: PATCH: Make nnrss include RSS dc:subject

[Lars Magne Ingebrigtsen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> Richard invited us.  However, it is hard for a certain person to
> assign FSF the copyright.  I haven't yet heard that he has been
> successful in the negotiation with the office (which is a big
> company in Japan). :<

Oh, that's too bad.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen