qgnus 0.34 - domain picons not displaying?

qgnus 0.34 - domain picons not displaying?

[Mike McEwan]

Hi,
  I see that `gnus-picon.el' has been hit in this last iteration of
qgnus. My newsgroup picons are still fine, but no domains anymore - is 
there something I have to add/change?

  Pertinent bits:-

(setq gnus-use-picons t)
     (add-hook 'gnus-article-display-hook 'gnus-article-display-picons t)
     (add-hook 'gnus-article-display-hook 'gnus-group-display-picons t)
     (add-hook 'gnus-article-display-hook 'gnus-picons-article-display-x-face t)

(setq gnus-picons-database "/usr/local/lib/picons/")
(setq gnus-picons-news-directories "news")
(setq gnus-picons-domain-directories (list "domains" "unknown"))
(setq gnus-picons-user-directories (list "users" "misc"))
(setq gnus-picons-display-where "article")

-- 
Mike.

Re: qgnus 0.34 - domain picons not displaying?

[Hans de Graaff]

Mike McEwan <mike@lotusland.demon.co.uk> writes:

>   I see that `gnus-picon.el' has been hit in this last iteration of
> qgnus. My newsgroup picons are still fine, but no domains anymore - is 
> there something I have to add/change?

Hmm, things still work fine for me. I did notice that suddenly the
newsgroup picons do show, perhaps the default changed?

> (setq gnus-use-picons t)
>      (add-hook 'gnus-article-display-hook 'gnus-article-display-picons t)
>      (add-hook 'gnus-article-display-hook 'gnus-group-display-picons t)
>      (add-hook 'gnus-article-display-hook 'gnus-picons-article-display-x-face t)
> 
> (setq gnus-picons-database "/usr/local/lib/picons/")

I have this too.

> (setq gnus-picons-news-directories "news")
> (setq gnus-picons-domain-directories (list "domains" "unknown"))
> (setq gnus-picons-user-directories (list "users" "misc"))

I don't have these set. Perhaps that may help?

> (setq gnus-picons-display-where "article")

I have (setq gnus-picons-display-where 'article) instead.

Hans

[Solved] qgnus 0.34 - domain picons not displaying?

[Mike McEwan]

Hans de Graaff <graaff@xs4all.nl> writes:
 
> Hmm, things still work fine for me. I did notice that suddenly the
> newsgroup picons do show, perhaps the default changed? 

  Well, I've finally worked out what's happening! The reason you now
get the newsgroup picons as well is that:-

In another thread in this list - Kim-Minh Kaplan wrote:

>Note that you should also remove `gnus-group-display-picons' from the
>`gnus-summary-prepare-hook' ; it is now done inside
>`gnus-article-display-picons'.

  It would appear that `gnus-group-display-picons' is now called from
`gnus-article-display-picons'. So you're now getting two for the price
of one. 

  Although Kim says to remove `gnus-group-display-picons' from the
`gnus-summary-prepare-hook', I had this in my `gnus-article-display-hook'.   
A session with edebug revealed that the newsgroup *and* domain picons
were being successfully generated via the `article' hook, but the
picons line within the article buffer was then being overwritten by my 
subsequent call of the `group' hook. Result - newsgroup picons, but no 
domains.

  I guess someone should maybe update the doc.

-- 
Mike.