Gravatar support

Gravatar support

[Julien Danjou]

Hi folks,

You had fun with picons, faces, etc, didn't you?
That was fun. But so 90's.

Welcome to 2010! Now we got Gravatar[1], used all around the Interweb.
It's like Face headers… but with more people.

So here's a full implementation of it for Gnus, with support for From
and To/Cc headers, inspired from picons support code.

The code has been tested, and the documentation updated.

What I would like:
- feedbacks;
- authorization to commit the code.

BE CAREFUL: by running Gnus with the following patch, you will do see
my face in mails I wrote.

You've been warned.

[1] http://www.gravatar.com

-- 
Julien Danjou
// ᐰ <julien@danjou.info>   http://julien.danjou.info

[PATCH] Add Gravatar support

[Julien Danjou]

Signed-off-by: Julien Danjou <julien@danjou.info>
---
 lisp/ChangeLog        |   10 ++++
 lisp/gnus-art.el      |   34 +++++++++++++-
 lisp/gnus-gravatar.el |  112 ++++++++++++++++++++++++++++++++++++++++++++
 lisp/gnus-sum.el      |    6 ++-
 lisp/gravatar.el      |  123 +++++++++++++++++++++++++++++++++++++++++++++++++
 texi/ChangeLog        |    4 ++
 texi/gnus.texi        |   70 +++++++++++++++++++++++++++-
 7 files changed, 355 insertions(+), 4 deletions(-)
 create mode 100644 lisp/gnus-gravatar.el
 create mode 100644 lisp/gravatar.el

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 9733760..c19c5cd 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,13 @@
+2010-09-24  Julien Danjou  <julien@danjou.info>
+
+	* gnus-sum.el: Add support for Gravatars.
+
+	* gnus-art.el: Add support for Gravatars.
+
+	* gnus-gravatar.el: Add this file.
+
+	* gravatar.el: Add this file.
+
 2010-09-24  Lars Magne Ingebrigtsen  <larsi@gnus.org>
 
 	* nnimap.el (nnimap-command): Register the last command time so
diff --git a/lisp/gnus-art.el b/lisp/gnus-art.el
index d92d29d..231f9e9 100644
--- a/lisp/gnus-art.el
+++ b/lisp/gnus-art.el
@@ -1529,10 +1529,40 @@ node `(gnus)Picons' for details."
   :type gnus-article-treat-head-custom)
 (put 'gnus-treat-newsgroups-picon 'highlight t)
 
+(defcustom gnus-treat-from-gravatar
+  (when (display-images-p) 'head)
+  "Display gravatars in the From header.
+Valid values are nil, t, `head', `first', `last', an integer or a
+predicate.  See Info node `(gnus)Customizing Articles' and Info
+node `(gnus)Gravatars' for details."
+  :version "24.1"
+  :group 'gnus-article-treat
+  :group 'gnus-gravatar
+  :link '(custom-manual "(gnus)Customizing Articles")
+  :link '(custom-manual "(gnus)Gravatars")
+  :type gnus-article-treat-head-custom)
+(put 'gnus-treat-from-gravatar 'highlight t)
+
+(defcustom gnus-treat-mail-gravatar
+  (when (display-images-p) 'head)
+  "Display gravatars in To and Cc headers.
+Valid values are nil, t, `head', `first', `last', an integer or a
+predicate.  See Info node `(gnus)Customizing Articles' and Info
+node `(gnus)Gravatars' for details."
+  :version "24.1"
+  :group 'gnus-article-treat
+  :group 'gnus-gravatar
+  :link '(custom-manual "(gnus)Customizing Articles")
+  :link '(custom-manual "(gnus)Gravatars")
+  :type gnus-article-treat-head-custom)
+(put 'gnus-treat-mail-gravatar 'highlight t)
+
 (defcustom gnus-treat-body-boundary
   (if (or gnus-treat-newsgroups-picon
 	  gnus-treat-mail-picon
-	  gnus-treat-from-picon)
+	  gnus-treat-from-picon
+          gnus-treat-from-gravatar
+          gnus-treat-mail-gravatar)
       ;; If there's much decoration, the user might prefer a boundery.
       'head
     nil)
@@ -1669,6 +1699,8 @@ This requires GNU Libidn, and by default only enabled if it is found."
     (gnus-treat-from-picon gnus-treat-from-picon)
     (gnus-treat-mail-picon gnus-treat-mail-picon)
     (gnus-treat-newsgroups-picon gnus-treat-newsgroups-picon)
+    (gnus-treat-from-gravatar gnus-treat-from-gravatar)
+    (gnus-treat-mail-gravatar gnus-treat-mail-gravatar)
     (gnus-treat-highlight-headers gnus-article-highlight-headers)
     (gnus-treat-highlight-signature gnus-article-highlight-signature)
     (gnus-treat-strip-trailing-blank-lines
diff --git a/lisp/gnus-gravatar.el b/lisp/gnus-gravatar.el
new file mode 100644
index 0000000..6b97a54
--- /dev/null
+++ b/lisp/gnus-gravatar.el
@@ -0,0 +1,112 @@
+;;; gnus-gravatar.el --- Gnus Gravatar support
+
+;; Copyright (C) 2010 Free Software Foundation, Inc.
+
+;; Author: Julien Danjou <julien@danjou.info>
+;; Keywords: news
+
+;; This file is part of GNU Emacs.
+
+;; GNU Emacs is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; GNU Emacs is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs.  If not, see <http://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;;; Code:
+
+(require 'gravatar)
+
+(defgroup gnus-gravatar nil
+  "Gnus Gravatar."
+  :group 'gnus-visual)
+
+(defcustom gnus-gravatar-size 32
+  "How big should gravatars be displayed."
+  :type 'integer
+  :group 'gnus-gravatar)
+
+(defcustom gnus-gravatar-relief 1
+  "If non-nil, adds a shadow rectangle around the image. The
+value, relief, specifies the width of the shadow lines, in
+pixels. If relief is negative, shadows are drawn so that the
+image appears as a pressed button; otherwise, it appears as an
+unpressed button."
+  :group 'gnus-gravatar)
+
+(defun gnus-gravatar-transform-address (header category)
+  (gnus-with-article-headers
+    (let ((addresses
+           (mail-header-parse-addresses
+            ;; mail-header-parse-addresses does not work (reliably) on
+            ;; decoded headers.
+            (or
+             (ignore-errors
+               (mail-encode-encoded-word-string
+                (or (mail-fetch-field header) "")))
+             (mail-fetch-field header)))))
+      (dolist (address addresses)
+        (gravatar-retrieve
+         (car address)
+         'gnus-gravatar-insert
+         (list header (car address) category))))))
+
+(defun gnus-gravatar-insert (gravatar header address category)
+  "Insert GRAVATAR for ADDRESS in HEADER in current article buffer.
+Set image category to CATEGORY."
+  (unless (eq gravatar 'error)
+    (gnus-with-article-headers
+      (gnus-article-goto-header header)
+      (mail-header-narrow-to-field)
+      (when (and (search-forward address nil t)
+                 (or (search-backward ", " nil t)
+                     (search-backward ": " nil t)))
+        (goto-char (1+ (point)))
+        ;; Do not do anything if there's already a gravatar. This can
+        ;; happens if the buffer has been regenerated in the mean time, for
+        ;; example we were fetching someaddress, and then we change to
+        ;; another mail with the same someaddress.
+        (unless (memq 'gnus-gravatar (text-properties-at (point)))
+          (let ((inhibit-read-only t)
+                (point (point))
+                (gravatar (append
+                           gravatar
+                           `(:ascent center :relief ,gnus-gravatar-relief))))
+            (gnus-put-image gravatar nil category)
+            (put-text-property point (point) 'gnus-gravatar address)
+            (gnus-add-wash-type category)
+            (gnus-add-image category gravatar)))))))
+
+;;;###autoload
+(defun gnus-treat-from-gravatar ()
+  "Display gravatar in the From header.
+If gravatar is already displayed, remove it."
+  (interactive)
+  (gnus-with-article-buffer
+    (if (memq 'from-gravatar gnus-article-wash-types)
+        (gnus-delete-images 'from-gravatar)
+      (gnus-gravatar-transform-address "from" 'from-gravatar))))
+
+;;;###autoload
+(defun gnus-treat-mail-gravatar ()
+  "Display gravatars in the Cc and To headers.
+If gravatars are already displayed, remove them."
+  (interactive)
+    (gnus-with-article-buffer
+      (if (memq 'mail-gravatar gnus-article-wash-types)
+          (gnus-delete-images 'mail-gravatar)
+        (gnus-gravatar-transform-address "cc" 'mail-gravatar)
+        (gnus-gravatar-transform-address "to" 'mail-gravatar))))
+
+(provide 'gnus-gravatar)
+
+;;; gnus-gravatar.el ends here
diff --git a/lisp/gnus-sum.el b/lisp/gnus-sum.el
index 50f9b32..062a2be 100644
--- a/lisp/gnus-sum.el
+++ b/lisp/gnus-sum.el
@@ -2124,7 +2124,9 @@ increase the score of each group you read."
   "W" gnus-html-show-images
   "f" gnus-treat-from-picon
   "m" gnus-treat-mail-picon
-  "n" gnus-treat-newsgroups-picon)
+  "n" gnus-treat-newsgroups-picon
+  "g" gnus-treat-from-gravatar
+  "h" gnus-treat-mail-gravatar)
 
 (gnus-define-keys (gnus-summary-wash-mime-map "M" gnus-summary-wash-map)
   "w" gnus-article-decode-mime-words
@@ -2374,6 +2376,8 @@ increase the score of each group you read."
 	      ["Show picons in From" gnus-treat-from-picon t]
 	      ["Show picons in mail headers" gnus-treat-mail-picon t]
 	      ["Show picons in news headers" gnus-treat-newsgroups-picon t]
+              ["Show Gravatars in From" gnus-treat-from-gravatar t]
+	      ["Show Gravatars in mail headers" gnus-treat-mail-gravatar t]
 	      ("View as different encoding"
 	       ,@(gnus-summary-menu-split
 		  (mapcar
diff --git a/lisp/gravatar.el b/lisp/gravatar.el
new file mode 100644
index 0000000..ec03b1b
--- /dev/null
+++ b/lisp/gravatar.el
@@ -0,0 +1,123 @@
+;;; gravatar.el --- Get Gravatars
+
+;; Copyright (C) 2010 Free Software Foundation, Inc.
+
+;; Author: Julien Danjou <julien@danjou.info>
+;; Keywords: news
+
+;; This file is part of GNU Emacs.
+
+;; GNU Emacs is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; GNU Emacs is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs.  If not, see <http://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;;; Code:
+
+(require 'image)
+(require 'url)
+(require 'url-cache)
+
+(defgroup gravatar nil
+  "Gravatar."
+  :group 'comm)
+
+(defcustom gravatar-automatic-caching t
+  "Whether cache retrieved gravatar."
+  :group 'gravatar)
+
+(defcustom gravatar-cache-ttl (days-to-time 30)
+  "Time to live for gravatar cache entries."
+  :group 'gravatar)
+
+(defcustom gravatar-rating "g"
+  "Default rating for gravatar."
+  :group 'gravatar)
+
+(defcustom gravatar-size 32
+  "Default size in pixels for gravatars."
+  :group 'gravatar)
+
+(defconst gravatar-base-url
+  "http://www.gravatar.com/avatar"
+  "Base URL for getting gravatars.")
+
+(defun gravatar-hash (mail-address)
+  "Create an hash from MAIL-ADDRESS."
+  (md5 (downcase mail-address)))
+
+(defun gravatar-build-url (mail-address)
+  "Return an URL to retrieve MAIL-ADDRESS gravatar."
+  (format "%s/%s?d=404&r=%s&s=%d"
+          gravatar-base-url
+          (gravatar-hash mail-address)
+          gravatar-rating
+          gravatar-size))
+
+(defun gravatar-cache-expired (url)
+  "Check if URL is cached for more than `gravatar-cache-ttl'."
+  (cond (url-standalone-mode
+         (not (file-exists-p (url-cache-create-filename url))))
+        (t (let ((cache-time (url-is-cached url)))
+             (if cache-time
+                 (time-less-p
+                  (time-add
+                   cache-time
+                   gravatar-cache-ttl)
+                  (current-time))
+               t)))))
+
+(defun gravatar-get-data ()
+  "Get data from current buffer."
+  (when (string-match "^HTTP/.+ 200 OK$"
+                      (buffer-substring (point-min) (line-end-position)))
+    (when (search-forward "\n\n" nil t)
+      (buffer-substring (point) (point-max)))))
+
+(defun gravatar-data->image ()
+  "Get data of current buffer and return an image.
+If no image available, return 'error."
+  (let ((data (gravatar-get-data)))
+    (if data
+        (create-image data  nil t)
+      'error)))
+
+;;;###autoload
+(defun gravatar-retrieve (mail-address cb &optional cbargs)
+  "Retrieve MAIL-ADDRESS gravatar and call CB on retrieval.
+You can provide a list of argument to pass to CB in CBARGS."
+  (let ((url (gravatar-build-url mail-address)))
+    (if (gravatar-cache-expired url)
+        (url-retrieve url
+                      'gravatar-retrieved
+                      (list cb (when cbargs cbargs)))
+      (apply cb
+               (with-temp-buffer
+                 (mm-disable-multibyte)
+                 (url-cache-extract (url-cache-create-filename url))
+                 (gravatar-data->image))
+               cbargs))))
+
+(defun gravatar-retrieved (status cb &optional cbargs)
+  "Callback function used by `gravatar-retrieve'."
+  ;; Store gravatar?
+  (when gravatar-automatic-caching
+    (url-store-in-cache (current-buffer)))
+  (if (plist-get status :error)
+      ;; Error happened.
+      (apply cb 'error cbargs)
+    (apply cb (gravatar-data->image) cbargs)))
+
+(provide 'gravatar)
+
+;;; gravatar.el ends here
diff --git a/texi/ChangeLog b/texi/ChangeLog
index 17022dd..5cedf17 100644
--- a/texi/ChangeLog
+++ b/texi/ChangeLog
@@ -1,3 +1,7 @@
+2010-09-24  Julien Danjou  <julien@danjou.info>
+
+	* gnus.texi: Add Gravatars.
+
 2010-09-23  Lars Magne Ingebrigtsen  <larsi@gnus.org>
 
 	* gnus.texi (Startup Variables): Mention gnus-use-backend-marks.
diff --git a/texi/gnus.texi b/texi/gnus.texi
index 7f20f96..678a1e7 100644
--- a/texi/gnus.texi
+++ b/texi/gnus.texi
@@ -589,7 +589,7 @@ Article Treatment
 * Article Buttons::             Click on URLs, Message-IDs, addresses and the like.
 * Article Button Levels::       Controlling appearance of buttons.
 * Article Date::                Grumble, UT!
-* Article Display::             Display various stuff---X-Face, Picons, Smileys
+* Article Display::             Display various stuff---X-Face, Picons, Smileys, Gravatars
 * Article Signature::           What is a signature?
 * Article Miscellanea::         Various other stuff.
 
@@ -9255,7 +9255,8 @@ these articles easier.
 * Article Buttons::             Click on URLs, Message-IDs, addresses and the like.
 * Article Button Levels::       Controlling appearance of buttons.
 * Article Date::                Grumble, UT!
-* Article Display::             Display various stuff---X-Face, Picons, Smileys
+* Article Display::             Display various stuff:
+                                X-Face, Picons, Gravatars, Smileys.
 * Article Signature::           What is a signature?
 * Article Miscellanea::         Various other stuff.
 @end menu
@@ -10299,6 +10300,7 @@ preferred format automatically.
 @cindex picons
 @cindex x-face
 @cindex smileys
+@cindex gravatars
 
 These commands add various frivolous display gimmicks to the article
 buffer in Emacs versions that support them.
@@ -10315,6 +10317,9 @@ their messages with (@pxref{Smileys}).
 Picons, on the other hand, reside on your own system, and Gnus will
 try to match the headers to what you have (@pxref{Picons}).
 
+Gravatars reside on-line and are fetched from
+@uref{http://www.gravatar.com/} (@pxref{Gravatars}).
+
 All these functions are toggles---if the elements already exist,
 they'll be removed.
 
@@ -10353,6 +10358,17 @@ Piconify all mail headers (i. e., @code{Cc}, @code{To})
 Piconify all news headers (i. e., @code{Newsgroups} and
 @code{Followup-To}) (@code{gnus-treat-newsgroups-picon}).
 
+@item W D g
+@kindex W D g (Summary)
+@findex gnus-treat-from-gravatar
+Gravatarify the @code{From} header (@code{gnus-treat-from-gravatar}).
+
+@item W D h
+@kindex W D h (Summary)
+@findex gnus-treat-mail-gravatar
+Gravatarify all mail headers (i. e., @code{Cc}, @code{To})
+(@code{gnus-treat-from-gravatar}).
+
 @item W D D
 @kindex W D D (Summary)
 @findex gnus-article-remove-images
@@ -12631,6 +12647,8 @@ controlling variable is a predicate list, as described above.
 @vindex gnus-treat-from-picon
 @vindex gnus-treat-mail-picon
 @vindex gnus-treat-newsgroups-picon
+@vindex gnus-treat-from-gravatar
+@vindex gnus-treat-mail-gravatar
 @vindex gnus-treat-display-smileys
 @vindex gnus-treat-body-boundary
 @vindex gnus-treat-display-x-face
@@ -12697,6 +12715,11 @@ possible but those listed are probably sufficient for most people.
 
 @xref{Picons}.
 
+@item gnus-treat-from-gravatar (head)
+@item gnus-treat-mail-gravatar (head)
+
+@xref{Gravatars}.
+
 @item gnus-treat-display-smileys (t, integer)
 
 @item gnus-treat-body-boundary (head)
@@ -23709,6 +23732,7 @@ stuff, so Gnus has taken advantage of that.
 * Face::                        Display a funkier, teensier colored image.
 * Smileys::                     Show all those happy faces the way they were meant to be shown.
 * Picons::                      How to display pictures of what you're reading.
+* Gravatars::                   Display the avatar of people you read.
 * XVarious::                    Other XEmacsy Gnusey variables.
 @end menu
 
@@ -24037,6 +24061,48 @@ Ordered list of suffixes on picon file names to try.  Defaults to
 
 @end table
 
+@node Gravatars
+@subsection Gravatars
+
+@iftex
+@iflatex
+\include{gravatars}
+@end iflatex
+@end iftex
+
+A gravatar is an image registered to an e-mail address.
+
+You can submit yours on-line at @uref{http://www.gravatar.com}.
+
+The following variables offer control over how things are displayed.
+
+@table @code
+
+@item gnus-gravatar-size
+@vindex gnus-gravatar-size
+The size in pixels of gravatars. Gravatars are always square, so one
+number for the size is enough.
+
+@item gnus-gravatar-relief
+@vindex gnus-gravatar-relief
+If non-nil, adds a shadow rectangle around the image. The value,
+relief, specifies the width of the shadow lines, in pixels. If relief
+is negative, shadows are drawn so that the image appears as a pressed
+button; otherwise, it appears as an unpressed button.
+
+@end table
+
+If you want to see them in the From field, set:
+@lisp
+(setq gnus-treat-from-gravatar 'head)
+@end lisp
+
+If you want to see them in the Cc and To fields, set:
+
+@lisp
+(setq gnus-treat-mail-gravatar 'head)
+@end lisp
+
 
 @node XVarious
 @subsection Various XEmacs Variables
-- 
1.7.1

Re: Gravatar support

[Ted Zlatanov]

On Fri, 24 Sep 2010 19:13:55 +0200 Julien Danjou <julien@danjou.info> wrote: 

JD> You had fun with picons, faces, etc, didn't you?
JD> That was fun. But so 90's.

JD> Welcome to 2010! Now we got Gravatar[1], used all around the Interweb.
JD> It's like Face headers… but with more people.

JD> So here's a full implementation of it for Gnus, with support for From
JD> and To/Cc headers, inspired from picons support code.

JD> The code has been tested, and the documentation updated.

JD> What I would like:
JD> - feedbacks;
JD> - authorization to commit the code.

JD> BE CAREFUL: by running Gnus with the following patch, you will do see
JD> my face in mails I wrote.

JD> You've been warned.

It depends on an external URL so I would put it under contrib/

The Face header is self-contained.  That makes it better IMO.

Ted

Re: Gravatar support

[Lars Magne Ingebrigtsen]

Julien Danjou <julien@danjou.info> writes:

> Welcome to 2010! Now we got Gravatar[1], used all around the Interweb.
> It's like Face headers… but with more people.

Gravatar is nice, and the code looks good, but I'm not quite sure
whether adding functionality that relies on outside services is good.  I
mean, we've done this in the past now and then...  and it's mostly
turned out to not be good.

So I'm not sure.  What do all y'all think?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Gravatar support

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

On Fri, Sep 24 2010, Ted Zlatanov wrote:

> It depends on an external URL so I would put it under contrib/

Picons does.
gnus-group-faq does.
gnus-group-charter-alist does.
gnus-group-archive-directory does.

Please find another argument.

-- 
Julien Danjou
// ᐰ <julien@danjou.info>   http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: Gravatar support

[Ted Zlatanov]

On Fri, 24 Sep 2010 20:03:53 +0200 Julien Danjou <julien@danjou.info> wrote: 

JD> On Fri, Sep 24 2010, Ted Zlatanov wrote:
>> It depends on an external URL so I would put it under contrib/

JD> Picons does.
JD> gnus-group-faq does.
JD> gnus-group-charter-alist does.
JD> gnus-group-archive-directory does.

OK, "it depends on a 3rd party that we don't know, control, or
influence, and which has no responsibility or incentive to keep the
service going for our sake."  Sorry I was not precise.  Look up NoCeM
for a prior example of how this can be painful.

So, much like the google-* stuff for org-mode discussed in emacs-devel,
I'd be OK if this was done as a user choice with gravatar.com being one
of the backend providers, but my vote is no otherwise.

Ted

Re: Gravatar support

[Lars Magne Ingebrigtsen]

Julien Danjou <julien@danjou.info> writes:

> Picons does.
> gnus-group-faq does.
> gnus-group-charter-alist does.
> gnus-group-archive-directory does.
>
> Please find another argument.

I think you've just illustrated the problem.  :-)

gnus-group-archive-directory
=> "/ftp@ftp.hpc.uh.edu:/pub/emacs/ding-list/"

And that server doesn't exist any more.  I haven't checked with the
gnus-group-charter-alist sites, but if many of them exist any more, I'd
be surprised.  That stuff should be removed, not added to.

On the other hand, the Gravatar stuff is more fun than the charter
stuff, so I don't know.  I mean, it's not a hard and fast rule: "The
shall be no external services!"  It's more...  "Is this external service
really useful?"

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Gravatar support

[Ted Zlatanov]

On Fri, 24 Sep 2010 20:19:55 +0200 Lars Magne Ingebrigtsen <larsi@gnus.org> wrote: 

LMI> On the other hand, the Gravatar stuff is more fun than the charter
LMI> stuff, so I don't know.  I mean, it's not a hard and fast rule: "The
LMI> shall be no external services!"  It's more...  "Is this external service
LMI> really useful?"

Why not unite picons, faces, and Gravatars into a consistent framework
using backends, so when and if gravatar.com goes away, for instance, we
can just remove that backend?  They all behave similarly, right?  It
seems like gnus-gravatar.el duplicates a lot of gnus-picon.el so that
would be a chance to reduce the amount of code, too.

Ted

Re: Gravatar support

[Lars Magne Ingebrigtsen]

Ted Zlatanov <tzz@lifelogs.com> writes:

> Why not unite picons, faces, and Gravatars into a consistent framework
> using backends, so when and if gravatar.com goes away, for instance, we
> can just remove that backend?  They all behave similarly, right?

Yes and nooo.

Faces (and X-Faces) are contained in the message headers.  Picon support
is based on the concept that you download the entire picon tree locally,
and look at it there.  And Gravatar is a service that you query online.

So it's like a gliding scale from something that is definitely
... readerish to do (Faces) to something questionable (Picons) to
something that's totally an external service (Gravatar).

I think it would make sense to remove the picon support.  I can't
imagine there are more than a handful of people in the world that uses
it.  Although the packages are still in Debian, so perhaps...

But I would like to try the Gravatar stuff, at least.  :-)  Perhaps just
install it, and then we can give it a whirl?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Gravatar support

[Steinar Bang]

>>>>> Lars Magne Ingebrigtsen <larsi@gnus.org>:

> On the other hand, the Gravatar stuff is more fun than the charter
> stuff, so I don't know.  I mean, it's not a hard and fast rule: "The
> shall be no external services!"  It's more...  "Is this external
> service really useful?"

"Is this external service fun?"

Re: Gravatar support

[Steinar Bang]

>>>>> Lars Magne Ingebrigtsen <larsi@gnus.org>:

> So I'm not sure.  What do all y'all think?

Personally I only care if it causes my gnus to freeze up when trying to
read agentized email or news when offline.

Re: Gravatar support

[Ted Zlatanov]

On Fri, 24 Sep 2010 20:35:21 +0200 Lars Magne Ingebrigtsen <larsi@gnus.org> wrote: 

LMI> Ted Zlatanov <tzz@lifelogs.com> writes:
>> Why not unite picons, faces, and Gravatars into a consistent framework
>> using backends, so when and if gravatar.com goes away, for instance, we
>> can just remove that backend?  They all behave similarly, right?

LMI> Yes and nooo.

LMI> Faces (and X-Faces) are contained in the message headers.  Picon support
LMI> is based on the concept that you download the entire picon tree locally,
LMI> and look at it there.  And Gravatar is a service that you query online.

LMI> So it's like a gliding scale from something that is definitely
LMI> ... readerish to do (Faces) to something questionable (Picons) to
LMI> something that's totally an external service (Gravatar).

OK, but at least Faces vs. gravatars seems pretty close.  The code for
those two could be merged.

LMI> I think it would make sense to remove the picon support.  I can't
LMI> imagine there are more than a handful of people in the world that uses
LMI> it.  Although the packages are still in Debian, so perhaps...

I'm in favor to get rid of it.

LMI> But I would like to try the Gravatar stuff, at least.  :-)  Perhaps just
LMI> install it, and then we can give it a whirl?

OK :)

Ted

Re: Gravatar support

[Lars Magne Ingebrigtsen]

Ted Zlatanov <tzz@lifelogs.com> writes:

> OK, but at least Faces vs. gravatars seems pretty close.  The code for
> those two could be merged.

You mean Picons vs Gravatars?

> LMI> I think it would make sense to remove the picon support.  I can't
> LMI> imagine there are more than a handful of people in the world that uses
> LMI> it.  Although the packages are still in Debian, so perhaps...
>
> I'm in favor to get rid of it.

If the packages are in Debian, perhaps there's still some buy-in.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Gravatar support

[David Engster]

Lars Magne Ingebrigtsen writes:
> So I'm not sure.  What do all y'all think?

I'd say install it. I'm just a bit scared that you hack that thing to do
an async query for all gravatars in all gmane groups and cache them
locally.

-David

Re: Gravatar support

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 822 bytes --]

On Fri, Sep 24 2010, Lars Magne Ingebrigtsen wrote:

> I think it would make sense to remove the picon support.  I can't
> imagine there are more than a handful of people in the world that uses
> it.  Although the packages are still in Debian, so perhaps...

I just agree with all you said. Gnus has a lot of old stuff in it, and
I'd like to give it a fresh.

> But I would like to try the Gravatar stuff, at least.  :-)  Perhaps just
> install it, and then we can give it a whirl?

Ok, it's done. If too many people is unhappy, we can revert the commit.

[ Note that it is enabled by default:
  +(defcustom gnus-treat-from-gravatar
  +  (when (display-images-p) 'head)
  But this could be set to nil by default, obviously.]

-- 
Julien Danjou
// ᐰ <julien@danjou.info>   http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: Gravatar support

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

On Fri, Sep 24 2010, Steinar Bang wrote:

> Personally I only care if it causes my gnus to freeze up when trying to
> read agentized email or news when offline.

No chance, it's totally async and has a cache. :-)

-- 
Julien Danjou
// ᐰ <julien@danjou.info>   http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: Gravatar support

[Adam Sjøgren]

On Fri, 24 Sep 2010 19:13:55 +0200, Julien wrote:

> It's like Face headers… but with more people.

So, how does it work: Are gravatars shown instead of (X-)Face:s if both
exist?


  Best regards,

    Adam

-- 
 "Sunday morning when the rain begins to fall                 Adam Sjøgren
  I believe I have seen the end of it all"               asjo@koldfront.dk

Re: Gravatar support

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

On Fri, Sep 24 2010, Adam Sjøgren wrote:

> So, how does it work: Are gravatars shown instead of (X-)Face:s if both
> exist?

No, faces are not disabled by it. You'd get both.

-- 
Julien Danjou
// ᐰ <julien@danjou.info>   http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: Gravatar support

[CHENG Gao]

I found it's fun. And easier to use then Face/X-Face since the site can
help me to upload and crop photos. 

Thank you for this feature.

Re: Gravatar support

[Adam Sjøgren]

On Fri, 24 Sep 2010 21:36:50 +0200, Julien wrote:

> On Fri, Sep 24 2010, Adam Sjøgren wrote:

>> So, how does it work: Are gravatars shown instead of (X-)Face:s if both
>> exist?

> No, faces are not disabled by it. You'd get both.

Ah, cool!

Sorry for the misunderstanding, I seem to have lost X-Face-support when
I switched from using XEmacs to using GNU Emacs the other night.

Hm. I wonder why.

                                 o o o

A little curiosity: When I read an article by someone why has no
gravatar (I guess), the minibuffer shows this:

  "Reading [text/html; charset=utf-8]... 24 bytes of 13 bytes (185%)"

... which seems a little odd? :-)


  Best regards,

    Adam

-- 
 "Sunday morning when the rain begins to fall                 Adam Sjøgren
  I believe I have seen the end of it all"               asjo@koldfront.dk

Re: Gravatar support

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

On Fri, Sep 24 2010, Adam Sjøgren wrote:

> A little curiosity: When I read an article by someone why has no
> gravatar (I guess), the minibuffer shows this:
>
>   "Reading [text/html; charset=utf-8]... 24 bytes of 13 bytes (185%)"
>
> ... which seems a little odd? :-)

What's odd?
I wanted to disable the progress so `url-retrieve' would be silent, but
that's not possible.
185% is a usual bug in `url-retrieve'. :-)
text/html is because, well, it's a 404. But the 404 is cached, so it
will not be fetched until your cache TTL expires.

-- 
Julien Danjou
// ᐰ <julien@danjou.info>   http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: Gravatar support

[Adam Sjøgren]

On Fri, 24 Sep 2010 22:05:06 +0200, Adam wrote:

>> No, faces are not disabled by it. You'd get both.

Hm, I don't get both.

If I set gnus-treat-display-x-face to head and look at one if my own
articles, I see the X-Face only. If I set it to nil, I get the gravatar
only. Not both.

> Sorry for the misunderstanding, I seem to have lost X-Face-support when
> I switched from using XEmacs to using GNU Emacs the other night.

> Hm. I wonder why.

I guess XEmacs is compiled with libcompface, while GNU Emacs needs the
uncompface command, that I have now installed.


  Best regards,

    Adam

-- 
 "Sunday morning when the rain begins to fall                 Adam Sjøgren
  I believe I have seen the end of it all"               asjo@koldfront.dk

Re: Fetching 185% of something

[Adam Sjøgren]

On Fri, 24 Sep 2010 22:09:44 +0200, Julien wrote:

>> "Reading [text/html; charset=utf-8]... 24 bytes of 13 bytes (185%)"

> What's odd?
> I wanted to disable the progress so `url-retrieve' would be silent, but
> that's not possible.
> 185% is a usual bug in `url-retrieve'. :-)

That is what I thought was odd - just 'cause I hadn't seen it before.


  :-),

   Adam

-- 
 "Sunday morning when the rain begins to fall                 Adam Sjøgren
  I believe I have seen the end of it all"               asjo@koldfront.dk

Re: Gravatar support

[Steinar Bang]

>>>>> Julien Danjou <julien@danjou.info>:

> [ Note that it is enabled by default:
>   +(defcustom gnus-treat-from-gravatar
>   +  (when (display-images-p) 'head)
>   But this could be set to nil by default, obviously.]

Well... if there is a speed hit, I can't see it.

Re: Gravatar support

[Greg Troxel]

[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]


Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Julien Danjou <julien@danjou.info> writes:
>
>> Welcome to 2010! Now we got Gravatar[1], used all around the Interweb.
>> It's like Face headers… but with more people.
>
> Gravatar is nice, and the code looks good, but I'm not quite sure
> whether adding functionality that relies on outside services is good.  I
> mean, we've done this in the past now and then...  and it's mostly
> turned out to not be good.
>
> So I'm not sure.  What do all y'all think?

There is a serious privacy issue lurking, which lets gravatar.com
perform traffic analysis.  It is totally unreasonable to have any code
enabled by default that queries external servers based on received mail.

Also, there's a philosophical question about free software support for
proprietary services.  If there's a standard protocol and multiple
implementations, that seems fine.  But it seems really like this could
have been:

X-Face-URL: http://www.gravatar.com/avatar/205e460b479e2e5b48aec07710c08d50

if it's intended that requests be made about every email address, that
seems even more invasive.

[-- Attachment #2: Type: application/pgp-signature, Size: 194 bytes --]

Re: Gravatar support

[Russ Allbery]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Gravatar is nice, and the code looks good, but I'm not quite sure
> whether adding functionality that relies on outside services is good.  I
> mean, we've done this in the past now and then...  and it's mostly
> turned out to not be good.

> So I'm not sure.  What do all y'all think?

This seems like a good use case for user configuration.  If I like
Gravatar and think it's nifty and want it to download pictures for people,
I think I should have to explicitly enable that.  Once I've done so,
though, I think it's fair game.  As long as it isn't the default, I'm not
too worried about the privacy concern; people can make an informed
decision, particularly if the documentation points out that enabling this
would allow Gravatar to perform traffic analysis and get information about
what e-mail you're reading.

-- 
Russ Allbery (rra@stanford.edu)             <http://www.eyrie.org/~eagle/>

Re: Gravatar support

[Daniel Pittman]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> Ted Zlatanov <tzz@lifelogs.com> writes:
>
>> LMI> I think it would make sense to remove the picon support.  I can't
>> LMI> imagine there are more than a handful of people in the world that uses
>> LMI> it.  Although the packages are still in Debian, so perhaps...
>>
>> I'm in favor to get rid of it.
>
> If the packages are in Debian, perhaps there's still some buy-in.

popcon says that, like, 50 submitters have it installed.  So, buy-in is pretty
low inside the Debian ecosystem.

        Daniel
-- 
✣ Daniel Pittman            ✉ daniel@rimspace.net            ☎ +61 401 155 707
               ♽ made with 100 percent post-consumer electrons

Re: Gravatar support

[CHENG Gao]

*On Fri, 24 Sep 2010 22:19:19 +0200
* Also sprach asjo@koldfront.dk (Adam Sjøgren):

> On Fri, 24 Sep 2010 22:05:06 +0200, Adam wrote:
>
> I guess XEmacs is compiled with libcompface, while GNU Emacs needs the
> uncompface command, that I have now installed.
>
>
>   Best regards,
>
>     Adam

In contrib/ of Gnus there is a elisp version compface.el which does not
need uncompface command. I have expected it to become official for long
time but there is no way to contact the author to sign the paper. Anyway
I can use it.

Re: Gravatar support

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

On Sat, Sep 25 2010, Greg Troxel wrote:

> There is a serious privacy issue lurking, which lets gravatar.com
> perform traffic analysis.  It is totally unreasonable to have any code
> enabled by default that queries external servers based on received mail.

I agree, but please don't start to be paranoid too. Furthermore, images
are cached to 30 days by default, so you're not going to request an
image on every mail you read.

-- 
Julien Danjou
// ᐰ <julien@danjou.info>   http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: Gravatar support

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

On Fri, Sep 24 2010, Adam Sjøgren wrote:

> Hm, I don't get both.
>
> If I set gnus-treat-display-x-face to head and look at one if my own
> articles, I see the X-Face only. If I set it to nil, I get the gravatar
> only. Not both.

I see that too. The funny thing is that I did not write any code to do
that, and I expected the opposite. I'll dig into the treatment code, at
least to know why and if it's a bug.

-- 
Julien Danjou
// ᐰ <julien@danjou.info>   http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: Gravatar support

[Steinar Bang]

>>>>> Daniel Pittman <daniel@rimspace.net>:

> popcon says that, like, 50 submitters have it installed.  So, buy-in
> is pretty low inside the Debian ecosystem.

"popcon" huh...?  Ah... http://popcon.debian.org/

Interesting.  But FWIW, I have been a debian user since 2001, with 4
debian boxes currently running.  And I had never heard about popcon
before now.

Re: Gravatar support

[Charles Philip Chan]

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> I think it would make sense to remove the picon support.  I can't
> imagine there are more than a handful of people in the world that uses
> it.  Although the packages are still in Debian, so perhaps...

I vote no- I actually use it. It is kind of fun seeing the country
flags, domain icons, newsgroup icons, and isp icons in the article
buffer.

Charles

-- 
"We all know Linux is great...it does infinite loops in 5 seconds."
(Linus Torvalds about the superiority of Linux on the Amterdam
Linux Symposium)

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: Gravatar support

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

On Sat, Sep 25 2010, Steinar Bang wrote:

> Interesting.  But FWIW, I have been a debian user since 2001, with 4
> debian boxes currently running.  And I had never heard about popcon
> before now.

You should have if you installed a lenny or squeeze, since AFAIK the
installer now asks if you want to participate in popcon.

-- 
Julien Danjou
// ᐰ <julien@danjou.info>   http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: Gravatar support

[Daniel Pittman]

Julien Danjou <julien@danjou.info> writes:
> On Sat, Sep 25 2010, Steinar Bang wrote:
>
>> Interesting.  But FWIW, I have been a debian user since 2001, with 4 debian
>> boxes currently running.  And I had never heard about popcon before now.
>
> You should have if you installed a lenny or squeeze, since AFAIK the
> installer now asks if you want to participate in popcon.

...and, for what it is worth, despite it having a relatively low penetration
among Debian users the volumes are sufficiently high that it can be a passable
guide to what "average" desktop Debian users have.

eg: http://qa.debian.org/popcon-graph.php?packages=libc6

We could safely say that present contribution levels are somewhere on the
order of 90,000 data points or so, which suggests that approximately zero
percent of Debian users install the Debian picon packages.

        Daniel
-- 
✣ Daniel Pittman            ✉ daniel@rimspace.net            ☎ +61 401 155 707
               ♽ made with 100 percent post-consumer electrons

Re: Gravatar support

[Steinar Bang]

>>>>> Julien Danjou <julien@danjou.info>:

> You should have if you installed a lenny or squeeze, since AFAIK the
> installer now asks if you want to participate in popcon.

I've installed one lenny on my own, but I can't remember the question.
So it can't have made much of an impression. :-)

Re: Gravatar support

[Adam Sjøgren]

On Sat, 25 Sep 2010 11:47:07 +1000, Daniel wrote:

> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

>> Ted Zlatanov <tzz@lifelogs.com> writes:

LMI> I think it would make sense to remove the picon support.  I can't
LMI> imagine there are more than a handful of people in the world that uses
LMI> it.  Although the packages are still in Debian, so perhaps...
 
>>> I'm in favor to get rid of it.
 
>> If the packages are in Debian, perhaps there's still some buy-in.

> popcon says that, like, 50 submitters have it installed. So, buy-in is
> pretty low inside the Debian ecosystem.

I just tried installing the picon-packages. And article-headers turned
into fruit-salad.

I quickly removed the packages again.


  Just a data point,

    Adam

-- 
 "None of them kicks go boom                                  Adam Sjøgren
  None of them basslines fill the room"                  asjo@koldfront.dk

Re: Gravatar support

[Charles Philip Chan]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

asjo@koldfront.dk (Adam Sjøgren) writes:

> I just tried installing the picon-packages. And article-headers turned
> into fruit-salad.

Yes, the default "inline" style looks terrible. However, I quite like it
if you set "gnus-picon-style" to "right".

Charles

-- 
"Oh, I've seen copies [of Linux Journal] around the terminal room at The
Labs."
(By Dennis Ritchie)

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: Gravatar support

[Adam Sjøgren]

On Sat, 25 Sep 2010 07:07:16 -0400, Charles wrote:

> asjo@koldfront.dk (Adam Sjøgren) writes:

>> I just tried installing the picon-packages. And article-headers turned
>> into fruit-salad.

> Yes, the default "inline" style looks terrible. However, I quite like it
> if you set "gnus-picon-style" to "right".

Ah, I'll try that right away - thanks!

Yes, that's much better. It didn't seem to work on the
Newsgroups-header, though, so I have set:

  (setq gnus-picon-style 'right
        gnus-treat-newsgroups-picon nil)

Now I think picon support should stay :-)


  Best regards,

    Adam

-- 
 "None of them kicks go boom                                  Adam Sjøgren
  None of them basslines fill the room"                  asjo@koldfront.dk

Re: Gravatar support

[Charles Philip Chan]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

asjo@koldfront.dk (Adam Sjøgren) writes:

> Yes, that's much better. It didn't seem to work on the
> Newsgroups-header, though,

Same here- it is a bug.

Charles

-- 
"Computers may be stupid, but they're always obedient. Well, almost always."

  -- Larry Wall (Open Sources, 1999 O'Reilly and Associates)

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: Displaying picons

[Adam Sjøgren]

On Sat, 25 Sep 2010 13:26:01 +0200, Adam wrote:

> On Sat, 25 Sep 2010 07:07:16 -0400, Charles wrote:

>> Yes, the default "inline" style looks terrible. However, I quite like it
>> if you set "gnus-picon-style" to "right".

[...yes!...]

> Now I think picon support should stay :-)

I just adjusted the display of faces like this:

  ; Align the top of the face with the top of the text, approximately:
  (setq gnus-face-properties-alist
        '((pbm . (:face gnus-x-face :ascent 25))
          (png . (:ascent 25))))

Does something similar exist for picons? My guess at
gnus-picon-face-properties-alist was too optimistic :-)


  Best regards,

     Adam

-- 
 "None of them kicks go boom                                  Adam Sjøgren
  None of them basslines fill the room"                  asjo@koldfront.dk

Re: Gravatar support

[Lars Magne Ingebrigtsen]

Julien Danjou <julien@danjou.info> writes:

> [ Note that it is enabled by default:
>   +(defcustom gnus-treat-from-gravatar
>   +  (when (display-images-p) 'head)
>   But this could be set to nil by default, obviously.]

Yes, I think it should probably default to nil in production, but let's
keep it enabled by default for a while to give people a taste of how it
works.

There seems to be an odd glitch that I'm not able to debug.  I have

(setq gnus-treat-date-lapsed 'head)
(gnus-start-date-timer)

in my .gnus.el, so the date line is updated.  The first time your
gravatar was inserted, the lapsed time line was inserted, too, next to
the gravatar in addition to where it was supposed to be.  Could there be
a missing `save-excursion' (or something) in the gravatar code?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Gravatar support

[Lars Magne Ingebrigtsen]

Julien Danjou <julien@danjou.info> writes:

> I wanted to disable the progress so `url-retrieve' would be silent, but
> that's not possible.

Perhaps patch url-retrieve to allow silencing it?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Gravatar support

[Lars Magne Ingebrigtsen]

Russ Allbery <rra@stanford.edu> writes:

> As long as it isn't the default, I'm not too worried about the privacy
> concern; people can make an informed decision, particularly if the
> documentation points out that enabling this would allow Gravatar to
> perform traffic analysis and get information about what e-mail you're
> reading.

Yup.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Gravatar support

[Lars Magne Ingebrigtsen]

asjo@koldfront.dk (Adam Sjøgren) writes:

> Hm, I don't get both.
>
> If I set gnus-treat-display-x-face to head and look at one if my own
> articles, I see the X-Face only. If I set it to nil, I get the gravatar
> only. Not both.

The bug was in gnus-put-image, which put a "*" into the From header,
which meant that the Gravatar thing couldn't parse the header any more.
Fixed now.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Gravatar support

[Greg Troxel]

[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]


Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Julien Danjou <julien@danjou.info> writes:
>
>> [ Note that it is enabled by default:
>>   +(defcustom gnus-treat-from-gravatar
>>   +  (when (display-images-p) 'head)
>>   But this could be set to nil by default, obviously.]
>
> Yes, I think it should probably default to nil in production, but let's
> keep it enabled by default for a while to give people a taste of how it
> works.

Things like gravatar fetching should default to off, even in the git
version.  I realize you'd like to see people test it, but "private by
default" is the way the world ought to be, at all times.

I should not that I'm not accusing gravatar of being sinister.  Their
privacy policy looks good, although it doesn't clearly say "we keep no
logs of which IP addresses looked up which gravatars".  The point is
rather that each person should decide to deal with them or not, and
someone who just does 'git pull; make; make install' should not suddenly
find themselves making queries to their server.  I might even turn this
on myself for a while.

obtechnical: it would be cool if using the cache for display was
enablable separately from fetching.





[-- Attachment #2: Type: application/pgp-signature, Size: 194 bytes --]

Re: Gravatar support

[Lars Magne Ingebrigtsen]

Greg Troxel <gdt@work.lexort.com> writes:

> I should not that I'm not accusing gravatar of being sinister.  Their
> privacy policy looks good, although it doesn't clearly say "we keep no
> logs of which IP addresses looked up which gravatars".  The point is
> rather that each person should decide to deal with them or not, and
> someone who just does 'git pull; make; make install' should not suddenly
> find themselves making queries to their server.  I might even turn this
> on myself for a while.

I agree with this argument.  I've now switched the default of

gnus-treat-mail-gravatar
gnus-treat-from-gravatar

to nil.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Gravatar support

[Adam Sjøgren]

On Sat, 25 Sep 2010 15:39:10 +0200, Lars wrote:

> The bug was in gnus-put-image, which put a "*" into the From header,
> which meant that the Gravatar thing couldn't parse the header any more.
> Fixed now.

Great - thanks!


  Best regards,

    Adam

-- 
 "None of them kicks go boom                                  Adam Sjøgren
  None of them basslines fill the room"                  asjo@koldfront.dk

Re: Gravatar support

[Steinar Bang]

>>>>> asjo@koldfront.dk (Adam Sjøgren):

> Yes, that's much better. It didn't seem to work on the
> Newsgroups-header, though, so I have set:

>   (setq gnus-picon-style 'right
>         gnus-treat-newsgroups-picon nil)

> Now I think picon support should stay :-)

I've pulled in the picon-* packages on my Lucid Lynx UNE netbook, and
made the same adjustments you made.

And I agree they should stay.

(Though using 224MB out of my 8GB SSD, I doubt the packages will stay on
the netbook (which BTW wouldn't register on any debian statistics, even
though debian is why the packages are in Ubuntu...))

Re: Gravatar support

[Lars Magne Ingebrigtsen]

Steinar Bang <sb@dod.no> writes:

> (Though using 224MB out of my 8GB SSD, I doubt the packages will stay on
> the netbook (which BTW wouldn't register on any debian statistics, even
> though debian is why the packages are in Ubuntu...))

How many files are there in the packages?  I'm worrying I'll run out of
inodes if I install them.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Gravatar support

[Adam Sjøgren]

On Sat, 25 Sep 2010 18:50:01 +0200, Lars wrote:

> How many files are there in the packages?  I'm worrying I'll run out of
> inodes if I install them.  :-)

  $ (for p in picon-domains picon-misc picon-news picon-unknown picon-usenix picon-users picon-weather; do wajig listfiles $p; done) | wc -l
  55333
  $ 


  :-),

   Adam

-- 
 "None of them kicks go boom                                  Adam Sjøgren
  None of them basslines fill the room"                  asjo@koldfront.dk

Re: Gravatar support

[Lars Magne Ingebrigtsen]

asjo@koldfront.dk (Adam Sjøgren) writes:

>   $ (for p in picon-domains picon-misc picon-news picon-unknown picon-usenix picon-users picon-weather; do wajig listfiles $p; done) | wc -l
>   55333
>   $ 

[larsi@quimbies ~/pgnus]$ df -hi /usr
Filesystem            Inodes   IUsed   IFree IUse% Mounted on
/dev/sda9               1.6M    689K    849K   45% /usr

That should be OK, then.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Gravatar support

[Lars Magne Ingebrigtsen]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> That should be OK, then.  :-)

Heh.  It's fun to get all the pictures back.  I hadn't even noticed that
they were gone...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Gravatar support

[Charles Philip Chan]

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Heh.  It's fun to get all the pictures back.  I hadn't even noticed
> that they were gone...

I guess you now agree with us that picon support should be kept. If so
then, IMHO, the default style should be changed to "right" (inline is
really ugly) and the newsgroups header display should be fixed.

Charles

-- 
Linux: Because a PC is a terrible thing to waste.
(By komarimf@craft.camp.clarkson.edu, Mark Komarinski)

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: Gravatar support

[Lars Magne Ingebrigtsen]

Charles Philip Chan <cpchan@sympatico.ca> writes:

> I guess you now agree with us that picon support should be kept.

Yes.

> If so then, IMHO, the default style should be changed to "right"
> (inline is really ugly) and the newsgroups header display should be
> fixed.

I think the default way of displaying the picons is the most fun...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Gravatar support

[Byung-Hee HWANG]

[-- Attachment #1: Type: text/plain, Size: 915 bytes --]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Julien Danjou <julien@danjou.info> writes:
>
>> Welcome to 2010! Now we got Gravatar[1], used all around the Interweb.
>> It's like Face headers… but with more people.
>
> Gravatar is nice, and the code looks good, but I'm not quite sure
> whether adding functionality that relies on outside services is good.  I
>  [...]

Sorry, i'm lazy to read. Anyway Gravatar looks good. Currently i use
picon and Face/X-Face features in Gnus. There are so good to me.

So may i use Gravatar feature? By the way my Emacs version is "23.2". Is
it possible in my Emacs version? Could you please some advice or comment?

Sincerely,

--- 
소여물 황병희(黃炳熙) | .. 출항 15분전..

When Johnny Fontane appeared in the garden, Kay Adams recognized him 
immediately. She was truly surprised.
		-- The author's narration, "Chapter 1", page 41

[-- Attachment #2: Type: application/pgp-signature, Size: 195 bytes --]

Re: Gravatar support

[Byung-Hee HWANG]

[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]

Byung-Hee HWANG <bh@izb.knu.ac.kr> writes:

> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>
>> Julien Danjou <julien@danjou.info> writes:
>>
>>> Welcome to 2010! Now we got Gravatar[1], used all around the Interweb.
>>> It's like Face headers… but with more people.
>>
>> Gravatar is nice, and the code looks good, but I'm not quite sure
>> whether adding functionality that relies on outside services is good.  I
>>  [...]
>
> Sorry, i'm lazy to read. Anyway Gravatar looks good. Currently i use
> picon and Face/X-Face features in Gnus. There are so good to me.
>
> So may i use Gravatar feature? By the way my Emacs version is "23.2". Is
> it possible in my Emacs version? Could you please some advice or comment?

Ah.. never mind. I just did upgrade Emacs version to "24.1". Now i see
the images from Gravatar. I added 3 lines within ~/.gnus.el as below:

;; Gravatar!
(require 'gnus-gravatar)
(setq gnus-treat-from-gravatar 'head)
(setq gnus-treat-mail-gravatar nil)

Sincerely,

-- 
소여물 황병희(黃炳熙) | .. 출항 15분전..

"I'll want you both here with me."
		-- Vito Corleone, "Chapter 2", page 72

[-- Attachment #2: Type: application/pgp-signature, Size: 195 bytes --]

[ISSUE on DISPLAY_NAME] (Was: Re: Gravatar support)

[Byung-Hee HWANG]

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

Byung-Hee HWANG <bh@izb.knu.ac.kr> writes:

> [...]
> Ah.. never mind. I just did upgrade Emacs version to "24.1". Now i see
> the images from Gravatar. [...]

When i switched DISPLAY_NAME from ASCII characters (Byung-Hee HWANG) to
non-ASCII characters (황병희), the avatar did not appear. So how can i
resove it?  

Sincerely,

-- 
소여물 황병희(黃炳熙) | .. 출항 15분전..

"Does this man have real balls?"
"You're asking if he is a Sicilian." "NO."
		-- Vito Corleone and Tom Hagen, "Chapter 2", page 66-67

[-- Attachment #2: Type: application/pgp-signature, Size: 195 bytes --]

Re: [ISSUE on DISPLAY_NAME]

[Lars Magne Ingebrigtsen]

Byung-Hee HWANG <bh@izb.knu.ac.kr> writes:

> When i switched DISPLAY_NAME from ASCII characters (Byung-Hee HWANG) to
> non-ASCII characters (황병희), the avatar did not appear. So how can i
> resove it?  

Perhaps the gravatar code should grab the user name from the original
article buffer instead of the displayed one?  That should make all
en/decoding issues go away...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: [ISSUE on DISPLAY_NAME]

[Byung-Hee HWANG]

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Byung-Hee HWANG <bh@izb.knu.ac.kr> writes:
>
>> When i switched DISPLAY_NAME from ASCII characters (Byung-Hee HWANG) to
>> non-ASCII characters (황병희), the avatar did not appear. So how can i
>> resove it?  
>
> Perhaps the gravatar code should grab the user name from the original
> article buffer instead of the displayed one?  That should make all
> en/decoding issues go away...

Thanks for summary!

-- 
소여물 황병희(黃炳熙) | .. 출항 15분전..

"But I can see you don't take me seriously."
		-- Tom Hagen, "Chapter 1", page 61

[-- Attachment #2: Type: application/pgp-signature, Size: 195 bytes --]