Clicking on From: address in attachment DTWT

Clicking on From: address in attachment DTWT

[Stephen Berman]

When an email contains a forwarded email, clicking on the address in the
From: header of the attached mail creates a message buffer in which the
To: address is not, as I had hoped, the address is the attached From:
header but rather the address in the top From: header.  For example, in
the following:

----------
From: Stephen Berman <stephen.berman@bla.net>
Subject: Meeting Thu 10:00 - 12:00 (fwd)
To: <Mary.Jones@bla.net>
Date: Mon, 18 Oct 2010 09:58:33 +0200 (CEST)

[1. text/plain]


[2. Meeting Thu 10:00 - 12:00 (fwd) --- message/rfc822]

From: John Smith <John.Smith@bla.net>
Subject: Meeting Thu 10:00 - 12:00
To: Stephen Berman <stephen.berman@bla.net>
Date: Sun, 17 Oct 2010 18:15:25 +0200 (CEST)

Dear Steve,

Bla bla bla.

Thanks,
John
----------

when I click on "John.Smith@bla.net" in the attached From: header, the
resulting message buffer's To: header contains "Stephen Berman
<stephen.berman@bla.net>" rather than "John Smith <John.Smith@bla.net>". 

AFAICT, this is because message-reply narrows to the headers of the
containing email, ignoring the headers of the contained email.

Steve Berman

Re: Clicking on From: address in attachment DTWT

[Rupert Swarbrick]

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

Stephen Berman <stephen.berman@gmx.net> writes:
<snip>
> when I click on "John.Smith@bla.net" in the attached From: header, the
> resulting message buffer's To: header contains "Stephen Berman
> <stephen.berman@bla.net>" rather than "John Smith <John.Smith@bla.net>". 
>
> AFAICT, this is because message-reply narrows to the headers of the
> containing email, ignoring the headers of the contained email.
>
> Steve Berman

Are you sure that this isn't a customisation your end? My gnus here
seems to do the right thing... (Although it's about a week old, so I
guess it could be a recent change)

Rupert

[-- Attachment #2: Type: application/pgp-signature, Size: 315 bytes --]

Re: Clicking on From: address in attachment DTWT

[Stephen Berman]

On Mon, 18 Oct 2010 10:21:24 +0100 Rupert Swarbrick <rswarbrick@gmail.com> wrote:

> Stephen Berman <stephen.berman@gmx.net> writes:
> <snip>
>> when I click on "John.Smith@bla.net" in the attached From: header, the
>> resulting message buffer's To: header contains "Stephen Berman
>> <stephen.berman@bla.net>" rather than "John Smith <John.Smith@bla.net>". 
>>
>> AFAICT, this is because message-reply narrows to the headers of the
>> containing email, ignoring the headers of the contained email.
>>
>> Steve Berman
>
> Are you sure that this isn't a customisation your end? 

I don't think so: when I start Emacs with -Q, type `M-x gnus', 'y' to
continue despite having no news server set up, get to the Group buffer,
type `G f' to visit a file as a foreign group, and that file contains a
mail with an attached mail as described in my OP, and then follow the
steps in my OP, I get the same results as I reported in my OP.
Moreover, stepping through message-reply with edebug, I don't see how
this can be otherwise.

>                                                        My gnus here
> seems to do the right thing... (Although it's about a week old, so I
> guess it could be a recent change)

Are you sure you don't have a customization that makes this possible?
Do you still see this with -Q, following the steps described above?

Steve Berman

Re: Clicking on From: address in attachment DTWT

[Lars Magne Ingebrigtsen]

Stephen Berman <stephen.berman@gmx.net> writes:

> I don't think so: when I start Emacs with -Q, type `M-x gnus', 'y' to
> continue despite having no news server set up, get to the Group buffer,
> type `G f' to visit a file as a foreign group, and that file contains a
> mail with an attached mail as described in my OP, and then follow the
> steps in my OP, I get the same results as I reported in my OP.
> Moreover, stepping through message-reply with edebug, I don't see how
> this can be otherwise.

Is `message-reply' called by hitting `RET' on a mail address in the
article buffer?  I'm not able to reproduce this.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Clicking on From: address in attachment DTWT

[Stephen Berman]

[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]

On Mon, 18 Oct 2010 21:15:42 +0200 Lars Magne Ingebrigtsen <larsi@gnus.org> wrote:

> Stephen Berman <stephen.berman@gmx.net> writes:
>
>> I don't think so: when I start Emacs with -Q, type `M-x gnus', 'y' to
>> continue despite having no news server set up, get to the Group buffer,
>> type `G f' to visit a file as a foreign group, and that file contains a
>> mail with an attached mail as described in my OP, and then follow the
>> steps in my OP, I get the same results as I reported in my OP.
>> Moreover, stepping through message-reply with edebug, I don't see how
>> this can be otherwise.
>
> Is `message-reply' called by hitting `RET' on a mail address in the
> article buffer?  I'm not able to reproduce this.

Either by hitting RET or clicking on the address (mouse-1 or mouse-2).
The call path is gnus-widget-press-button -> gnus-article-press-button
-> gnus-button-reply -> message-reply.  It's not just any mail address
that triggers the problem, but one in the header of an attached
forwarded email.  I've attached an example, with which I can reproduce
the problem starting with -Q as described above.  Do you see the problem
with this mail?

Steve Berman


[-- Attachment #2: email with attached email --]
[-- Type: application/octet-stream, Size: 3728 bytes --]

From Stephen.Berman@bla.net  Wed Sep  8 10:48:54 2010
Return-Path: <Stephen.Berman@bla.net>
X-Original-To: steve@localhost
Delivered-To: steve@localhost.home
Received: from escher.home (localhost [127.0.0.1])
	by escher.home (Postfix) with ESMTP id AAB8910222
	for <steve@localhost>; Wed,  8 Sep 2010 10:48:54 +0200 (CEST)
Received: from mail.bla.net [123.456.78.9]
	by escher.home with POP3 (fetchmail-6.3.11)
	for <steve@localhost> (single-drop); Wed, 08 Sep 2010 10:48:54 +0200 (CEST)
Delivered-To: john.smith@bla.net
X-Queued: (qmail 3409 invoked by uid 31930); 8 Sep 2010 08:46:12 -0000
Date: Wed, 08 Sep 2010 10:46:11 +0200 (CEST)
From: Stephen Berman <Stephen.Berman@bla.net>
Organization: Bla Net
Subject: 17. 9. (fwd)
To: <john.smith@bla.net>
X-Gnus-Mail-Source: file:/var/spool/mail/steve
Message-ID: <201009080846116509e8c700000d38-Stephen.Berman@msgid.mail.bla.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary=+201009080846116509e8c700000d38-Stephen.Berman+
Status: O
Lines: 79
Xref: escher.home Stephen:182
X-Gnus-Article-Number: 182   Wed, 08 Sep 2010 10:49:28 +0200

  This is a MIME encoded multipart message.

--+201009080846116509e8c700000d38-Stephen.Berman+
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Bla bla bla

Steve

--+201009080846116509e8c700000d38-Stephen.Berman+
Content-Type: message/rfc822; charset=us-ascii
Content-Description: 17. 9. (fwd)

Return-Path: <john.smith@bla.net>
Delivered-To: Stephen.Berman@bla.net
X-Queued: (qmail 31348 invoked from network); 7 Sep 2010 23:12:26 -0000
Received: from mx5.rz.bla.net (123.456.78.9)
  by mbx4.rz.bla.net with QMQP; 7 Sep 2010 23:12:26 -0000
Delivered-To: CLUSTERHOST mx5.rz.bla.net Stephen.Berman@bla.net
X-Queued: (qmail 7458 invoked by alias); 7 Sep 2010 23:12:26 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	mx5.rz.bla.net
X-Spam-Level: ****
X-Spam-Status: No, score=4.5 required=5.0 tests=BAYES_50,
	FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,
	STOX_REPLY_TYPE,STOX_REPLY_TYPE_WITHOUT_QUOTES,T_RP_MATCHES_RCVD autolearn=no
	version=3.3.1
X-Spam-ASN: AS8560 213.165.64.0/19
X-Spam-Relay-Countries: DE DE
X-Spam-Language: 
X-Envelope-Sender: john.smith@bla.net
X-Queued: (qmail 7447 invoked by uid 109); 7 Sep 2010 23:12:25 -0000
X-Qmailscanner: from 123.456.78.9 by mx5.rz.bla.net (envelope-from <john.smith@bla.net>, uid 103) with qmail-scanner-2.01 
 (sophie: 3.05/3.10/4.56.  
 Clear:RC:0(123.456.78.9):. 
 Processed in 0.015006 secs); 07 Sep 2010 23:12:25 -0000
Received: from mailout-de.bla.net (HELO mail.bla.net) (123.456.78.9)
  by mx5.rz.bla.net with SMTP; 7 Sep 2010 23:12:25 -0000
Received: (qmail invoked by alias); 07 Sep 2010 23:12:25 -0000
Received: from p5B27B1C6.bla.net (EHLO Lenovo) [123.456.78.9]
  by mail.gmx.net (mp070) with SMTP; 08 Sep 2010 01:12:25 +0200
X-Authenticated: #19925087
X-Provags-ID: V01U2FsdGVkX19LUOgsTBtLVKzJ+3dIDzu0hO9r10SSZSdpVXZjjx
	Tih6IlEA9pakKN
Message-ID: <E791DCF4D282483E8BEEB9E1E5CBF4D0@Lenovo>
From: "John Smith" <john.smith@bla.net>
To: "Stephen Berman" <Stephen.Berman@bla.net>
References: <201009010751236509e8c700002737-Stephen.Berman@msgid.mail.bla.net>
In-Reply-To: <201009010751236509e8c700002737-Stephen.Berman@msgid.mail.bla.net>
Subject: 17. 9.
Date: Wed, 8 Sep 2010 01:12:24 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 8bit
X-Priority: 3
X-MSMail-Priority: Normal
Importance: Normal
X-Mailer: Microsoft Windows Live Mail 14.0.8089.726
X-MimeOLE: Produced By Microsoft MimeOLE V14.0.8089.726
X-Y-GMX-Trusted: 0


Dear Steve,

Bla bla bla.

John


--+201009080846116509e8c700000d38-Stephen.Berman+--

Re: Clicking on From: address in attachment DTWT

[Lars Magne Ingebrigtsen]

Stephen Berman <stephen.berman@gmx.net> writes:

> I've attached an example, with which I can reproduce the problem
> starting with -Q as described above.  Do you see the problem with this
> mail?

Yup.  Pretty odd code there, but I think I've now fixed it, and it will
hopefully not have any bad side effects...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Clicking on From: address in attachment DTWT

[Stephen Berman]

On Tue, 19 Oct 2010 01:12:54 +0200 Lars Magne Ingebrigtsen <larsi@gnus.org> wrote:

> Stephen Berman <stephen.berman@gmx.net> writes:
>
>> I've attached an example, with which I can reproduce the problem
>> starting with -Q as described above.  Do you see the problem with this
>> mail?
>
> Yup.  Pretty odd code there, but I think I've now fixed it, and it will
> hopefully not have any bad side effects...

I confirm that clicking or hitting RET on the From: address in an
attachment now DTRT, and haven't noticed any problems yet.  Thanks!

Steve Berman