tramp and the new nnimap?

tramp and the new nnimap?

[Steinar Bang]

Question for Ted: With the new and (seriously) performance-improved
nnimap, and with imap.el going away, is it an idea to make the IMAP
storage of tramp work through nnimap?

gnus-sync and the new nnimap (Was: tramp and the new nnimap?)

[Steinar Bang]

>>>>> Steinar Bang <sb@dod.no>:

> Question for Ted: With the new and (seriously) performance-improved
> nnimap, and with imap.el going away, is it an idea to make the IMAP
> storage of tramp work through nnimap?

If that proves to be impossible: would it be possible to have gnus-sync
work directly with nnimap?  That would make it possible for it have the
same offline/online behaviour as nnimap itself.

Re: gnus-sync and the new nnimap

[Ted Zlatanov]

On Tue, 14 Sep 2010 10:05:03 +0200 Steinar Bang <sb@dod.no> wrote: 

>>>>>> Steinar Bang <sb@dod.no>:
>> Question for Ted: With the new and (seriously) performance-improved
>> nnimap, and with imap.el going away, is it an idea to make the IMAP
>> storage of tramp work through nnimap?

Tramp would then require nnimap, which is not so good.  In fact,
tramp-imap.el is currently broken (because imap-hash.el used the removed
imap-fetch-safe) and I'm waiting for the dust to settle before fixing
it.  The lack of an outcry tells me they are not widely used and I'm
considering removing them form Tramp altogether.  If there are no users
for a feature, no matter how great you think it is...

SB> If that proves to be impossible: would it be possible to have gnus-sync
SB> work directly with nnimap?  That would make it possible for it have the
SB> same offline/online behaviour as nnimap itself.

Yes.  That may be the better approach, especially if tramp-imap.el goes
away.  But it also need UI work so for now it's on my TODO list but not
at the top.

Ted

Re: gnus-sync and the new nnimap

[Lars Magne Ingebrigtsen]

Ted Zlatanov <tzz@lifelogs.com> writes:

> Tramp would then require nnimap, which is not so good.  In fact,
> tramp-imap.el is currently broken (because imap-hash.el used the removed
> imap-fetch-safe) and I'm waiting for the dust to settle before fixing
> it. 

Oops.  I didn't think to grep for other usages.

I think the changes I did to imap.el before I decided to do a rewrite
should be reverted in total.  How does one do that?  Just fetch an old
version of imap.el somewhere and check that in?  And how do I fetch an
old version of imap.el?  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: gnus-sync and the new nnimap

[Ted Zlatanov]

On Tue, 14 Sep 2010 12:54:05 +0200 Lars Magne Ingebrigtsen <larsi@gnus.org> wrote: 

LMI> I think the changes I did to imap.el before I decided to do a rewrite
LMI> should be reverted in total.  How does one do that?  Just fetch an old
LMI> version of imap.el somewhere and check that in?  And how do I fetch an
LMI> old version of imap.el?  :-)

The changes for logging and cleanup were OK.

git log imap.el tells the revision you want, so then:

git diff -r cb950ed8ff3e0f40dac437a51b269166f9ffb60d imap.el

would work.

Ted

Re: gnus-sync and the new nnimap

[Jose A. Ortega Ruiz]

On Tue, Sep 14 2010, Ted Zlatanov wrote:

> On Tue, 14 Sep 2010 12:54:05 +0200 Lars Magne Ingebrigtsen <larsi@gnus.org> wrote: 
>
> LMI> I think the changes I did to imap.el before I decided to do a rewrite
> LMI> should be reverted in total.  How does one do that?  Just fetch an old
> LMI> version of imap.el somewhere and check that in?  And how do I fetch an
> LMI> old version of imap.el?  :-)
>
> The changes for logging and cleanup were OK.
>
> git log imap.el tells the revision you want, so then:
>
> git diff -r cb950ed8ff3e0f40dac437a51b269166f9ffb60d imap.el

Also, one can use:

  git show cb950ed8ff3e0f40dac437a51b269166f9ffb60d:imap.el

to get the file as it was in the given version.

HTH,
jao

Re: gnus-sync and the new nnimap

[Ted Zlatanov]

On Tue, 14 Sep 2010 14:22:54 +0200 "Jose A. Ortega Ruiz" <jao@gnu.org> wrote: 

jao> On Tue, Sep 14 2010, Ted Zlatanov wrote:

>> The changes for logging and cleanup were OK.
>> 
>> git log imap.el tells the revision you want, so then:
>> 
>> git diff -r cb950ed8ff3e0f40dac437a51b269166f9ffb60d imap.el

jao> Also, one can use:

jao>   git show cb950ed8ff3e0f40dac437a51b269166f9ffb60d:imap.el

jao> to get the file as it was in the given version.

On Tue, 14 Sep 2010 14:50:19 +0200 Štěpán Němec <stepnem@gmail.com> wrote: 

ŠN> ... and `git revert <commit>' does exactly what you need -- it makes a
ŠN> new commit undoing changes done by a previous commit.

Yeah, `git show' works great.  I think it's good to check the diff first
and I usually just make it into a patch since it's in my command history
:) 

I think `git revert' is not right because we want to note the changes in
the ChangeLog instead of just undoing them.

Ted

Re: gnus-sync and the new nnimap

[Štěpán Němec]

Ted Zlatanov <tzz@lifelogs.com> writes:

> On Tue, 14 Sep 2010 14:22:54 +0200 "Jose A. Ortega Ruiz" <jao@gnu.org> wrote:
>
> jao> On Tue, Sep 14 2010, Ted Zlatanov wrote:
>
>>> The changes for logging and cleanup were OK.
>>> 
>>> git log imap.el tells the revision you want, so then:
>>> 
>>> git diff -r cb950ed8ff3e0f40dac437a51b269166f9ffb60d imap.el
>
> jao> Also, one can use:
>
> jao>   git show cb950ed8ff3e0f40dac437a51b269166f9ffb60d:imap.el
>
> jao> to get the file as it was in the given version.
>
> On Tue, 14 Sep 2010 14:50:19 +0200 Štěpán Němec <stepnem@gmail.com> wrote: 
>
> ŠN> ... and `git revert <commit>' does exactly what you need -- it makes a
> ŠN> new commit undoing changes done by a previous commit.
>
> Yeah, `git show' works great.  I think it's good to check the diff first
> and I usually just make it into a patch since it's in my command history
> :) 
>
> I think `git revert' is not right because we want to note the changes in
> the ChangeLog instead of just undoing them.

Right... but you can still use `git revert -n' to prepare the commit(s) for
you and then perhaps just do `git checkout HEAD -- ChangeLog' to discard
the changes you don't want, edit etc.

Štěpán

Re: gnus-sync and the new nnimap

[Lars Magne Ingebrigtsen]

"Jose A. Ortega Ruiz" <jao@gnu.org> writes:

> Also, one can use:
>
>   git show cb950ed8ff3e0f40dac437a51b269166f9ffb60d:imap.el

Great!

I've now reverted back to the version of imap.el from a while back.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: gnus-sync and the new nnimap

[Štěpán Němec]

Ted Zlatanov <tzz@lifelogs.com> writes:

> On Tue, 14 Sep 2010 12:54:05 +0200 Lars Magne Ingebrigtsen <larsi@gnus.org>
> wrote:
>
> LMI> I think the changes I did to imap.el before I decided to do a rewrite
> LMI> should be reverted in total.  How does one do that?  Just fetch an old
> LMI> version of imap.el somewhere and check that in?  And how do I fetch an
> LMI> old version of imap.el?  :-)
>
> The changes for logging and cleanup were OK.
>
> git log imap.el tells the revision you want, so then:
>
> git diff -r cb950ed8ff3e0f40dac437a51b269166f9ffb60d imap.el
>
> would work.

... and `git revert <commit>' does exactly what you need -- it makes a
new commit undoing changes done by a previous commit.

Štěpán

Re: gnus-sync and the new nnimap

[Lars Magne Ingebrigtsen]

Štěpán Němec <stepnem@gmail.com> writes:

> ... and `git revert <commit>' does exactly what you need -- it makes a
> new commit undoing changes done by a previous commit.

There are several commits that need undoing.  Should I do them in a
particular order?

It would really be easier to get an old version of the file, perhaps...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: gnus-sync and the new nnimap

[Lawrence Mitchell]

Lars Magne Ingebrigtsen wrote:
> Štěpán Němec <stepnem@gmail.com> writes:

>> ... and `git revert <commit>' does exactly what you need -- it makes a
>> new commit undoing changes done by a previous commit.

> There are several commits that need undoing.  Should I do them in a
> particular order?

> It would really be easier to get an old version of the file, perhaps...

git checkout OLDCOMMIT -- path/to/file.el

Or if you want to do it all interactively, perhaps:

git checkout --patch OLDCOMMIT -- path/to/file.el

Lawrence
-- 
Lawrence Mitchell <wence@gmx.li>

Re: gnus-sync and the new nnimap

[Štěpán Němec]

Lawrence Mitchell <wence@gmx.li> writes:

> Lars Magne Ingebrigtsen wrote:
>> Štěpán Němec <stepnem@gmail.com> writes:
>
>>> ... and `git revert <commit>' does exactly what you need -- it makes a
>>> new commit undoing changes done by a previous commit.
>
>> There are several commits that need undoing.  Should I do them in a
>> particular order?
>
>> It would really be easier to get an old version of the file, perhaps...
>
> git checkout OLDCOMMIT -- path/to/file.el
>
> Or if you want to do it all interactively, perhaps:
>
> git checkout --patch OLDCOMMIT -- path/to/file.el

You can also use the `-n/--no-commit' option to `git revert' to only
apply the changes necessary to back out a commit, but not commit them
automatically right away, thus enabling you to make a single commit
reverting multiple previous commits... TIMTOWTDI, with Git, sky's the
limit ;-)

Štěpán