Gnus development mailing list
 help / color / mirror / Atom feed
From: Nevin Kapur <nevin@jhu.edu>
Subject: Re: nnimap does not create non-existent groups on expiry (lost mail)
Date: Mon, 06 Jan 2003 22:12:31 -0500	[thread overview]
Message-ID: <m3n0mdmz4w.fsf@fermat.mts.jhu.edu> (raw)
In-Reply-To: <ilu7kdhho86.fsf@latte.josefsson.org>

Simon Josefsson <jas@extundo.com> writes:

> In theory it is the right thing, but various IMAP server bugs make the
> TRYCREATE stuff unreliable, so with your patch I believe nnimap would
> have sent a CREATE command for every expired article (which would have
> failed in the normal case).  Does the following work instead?  It also
> has the feature that no articles are expired if the group could not be
> created.  

I applied your patch, but I don't think it does the right thing.
Isn't it trying to create the (already existing) group from where the
function is being called rather than the target given by
nnmail-expiry-target?

I took a stab at modifying the patch but ran into some difficulties.
I'm not sure if one should check for the existence of the target group
in the function nnimap-expiry-target when it is possible that
nnmail-expiry-target returns a non-nnimap group.

Is it better to move the check inside nnimap-request-accept-article?

Index: lisp/nnimap.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/nnimap.el,v
retrieving revision 6.56
diff -u -r6.56 nnimap.el
--- lisp/nnimap.el	2002/12/28 18:52:55	6.56
+++ lisp/nnimap.el	2003/01/07 03:09:43
@@ -1413,7 +1413,8 @@
 	result))))
 
 (deffoo nnimap-request-accept-article (group &optional server last)
-  (when (nnimap-possibly-change-server server)
+  (when (and (nnimap-possibly-change-server server)
+	     (nnimap-request-create-group group))
     (let (uid)
       (if (setq uid
 		(if (string= nnimap-current-server nnimap-current-move-server)


-Nevin





  reply	other threads:[~2003-01-07  3:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-05  6:24 Nevin Kapur
2003-01-06 18:36 ` Nevin Kapur
2003-01-06 23:07   ` Simon Josefsson
2003-01-07  3:12     ` Nevin Kapur [this message]
2003-01-08  2:55       ` Simon Josefsson
2003-01-08  4:17         ` Lars Magne Ingebrigtsen
2003-01-08  6:10           ` Simon Josefsson
2003-01-08  6:40             ` Lars Magne Ingebrigtsen
2003-01-08  8:52               ` Simon Josefsson
2003-01-08 11:06                 ` Nevin Kapur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3n0mdmz4w.fsf@fermat.mts.jhu.edu \
    --to=nevin@jhu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).