Gnus development mailing list
 help / color / mirror / Atom feed
From: Edwin Steiner <edwin.steiner@gmx.net>
Subject: Patch for gnus-nocem
Date: Tue, 25 Nov 2003 23:57:16 +0100	[thread overview]
Message-ID: <m3oev02h0z.fsf@linux.local> (raw)

Hello Gnus Developers!

Today I activated NoCeM scanning and it did not work. I tracked the
problem down to the following: Most of my news groups are on a
secondary server, so they have names like nntp+<server>:<groupname>. The
code in gnus-nocem.el checks against gnus-active-hashtb which contains
these names, not the real group names.

The patch below solves this problem. The lookup is now done in
gnus-nocem-real-group-hashtb which contains the real group names. (And
I think gnus-active-hashtb should not be modified by nocem anyway,
right?)

This patch makes the check in the following when clause partially
redundant. You could substitute

	  (when (gnus-gethash (gnus-group-real-name (symbol-name group))
			      gnus-nocem-real-group-hashtb)

with

	  (when (symbol-value group)

I did not test this, though.
I could submit a patch for it, too, if you are interested.

best regards
-Edwin



Index: lisp/gnus-nocem.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-nocem.el,v
retrieving revision 6.3
diff -u -r6.3 gnus-nocem.el
--- lisp/gnus-nocem.el	17 Nov 2002 22:35:39 -0000	6.3
+++ lisp/gnus-nocem.el	25 Nov 2003 22:32:58 -0000
@@ -297,7 +297,7 @@
       (while (search-forward "\t" nil t)
 	(cond
 	 ((not (ignore-errors
-		 (setq group (let ((obarray gnus-active-hashtb)) (read buf)))))
+		 (setq group (let ((obarray gnus-nocem-real-group-hashtb)) (read buf)))))
 	  ;; An error.
 	  )
 	 ((not (symbolp group))




             reply	other threads:[~2003-11-25 22:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-25 22:57 Edwin Steiner [this message]
2004-01-02 20:13 ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3oev02h0z.fsf@linux.local \
    --to=edwin.steiner@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).