From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/54950 Path: main.gmane.org!not-for-mail From: Edwin Steiner Newsgroups: gmane.emacs.gnus.general Subject: Patch for gnus-nocem Date: Tue, 25 Nov 2003 23:57:16 +0100 Sender: ding-owner@lists.math.uh.edu Message-ID: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1069801201 13447 80.91.224.253 (25 Nov 2003 23:00:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 25 Nov 2003 23:00:01 +0000 (UTC) Original-X-From: ding-owner+M3490@lists.math.uh.edu Tue Nov 25 23:59:56 2003 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AOmA0-0006lY-00 for ; Tue, 25 Nov 2003 23:59:56 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1AOm9j-0000NG-00; Tue, 25 Nov 2003 16:59:39 -0600 Original-Received: from justine.libertine.org ([66.139.78.221] ident=postfix) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1AOm9e-0000NB-00 for ding@lists.math.uh.edu; Tue, 25 Nov 2003 16:59:34 -0600 Original-Received: from mail.gmx.net (mail.gmx.de [213.165.64.20]) by justine.libertine.org (Postfix) with SMTP id B94653A0073 for ; Tue, 25 Nov 2003 16:59:33 -0600 (CST) Original-Received: (qmail 508 invoked by uid 65534); 25 Nov 2003 22:59:31 -0000 Original-Received: from a206-043.dialin.tuwien.ac.at (EHLO linux.local) (128.131.206.43) by mail.gmx.net (mp025) with SMTP; 25 Nov 2003 23:59:31 +0100 X-Authenticated: #9981821 Original-To: ding@gnus.org User-Agent: Gnus/5.1002 (Gnus v5.10.2) XEmacs/21.4 (Portable Code, linux) Precedence: bulk Xref: main.gmane.org gmane.emacs.gnus.general:54950 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:54950 Hello Gnus Developers! Today I activated NoCeM scanning and it did not work. I tracked the problem down to the following: Most of my news groups are on a secondary server, so they have names like nntp+:. The code in gnus-nocem.el checks against gnus-active-hashtb which contains these names, not the real group names. The patch below solves this problem. The lookup is now done in gnus-nocem-real-group-hashtb which contains the real group names. (And I think gnus-active-hashtb should not be modified by nocem anyway, right?) This patch makes the check in the following when clause partially redundant. You could substitute (when (gnus-gethash (gnus-group-real-name (symbol-name group)) gnus-nocem-real-group-hashtb) with (when (symbol-value group) I did not test this, though. I could submit a patch for it, too, if you are interested. best regards -Edwin Index: lisp/gnus-nocem.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/gnus-nocem.el,v retrieving revision 6.3 diff -u -r6.3 gnus-nocem.el --- lisp/gnus-nocem.el 17 Nov 2002 22:35:39 -0000 6.3 +++ lisp/gnus-nocem.el 25 Nov 2003 22:32:58 -0000 @@ -297,7 +297,7 @@ (while (search-forward "\t" nil t) (cond ((not (ignore-errors - (setq group (let ((obarray gnus-active-hashtb)) (read buf))))) + (setq group (let ((obarray gnus-nocem-real-group-hashtb)) (read buf))))) ;; An error. ) ((not (symbolp group))