browse-url-new-window-p doesn't work?

browse-url-new-window-p doesn't work?

[Kai Großjohann]

I have set browse-url-new-window-p to t and
browse-url-browser-function to browse-url-netscape.  Yet, hitting
mouse-2 on a link in an article (or RET) doesn't open a new Netscape
window, it reuses an existing window.

Has anyone else seen this, too?

kai
-- 
I like BOTH kinds of music.

Re: browse-url-new-window-p doesn't work?

[Michael Piotrowski]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

> I have set browse-url-new-window-p to t and
> browse-url-browser-function to browse-url-netscape.  Yet, hitting
> mouse-2 on a link in an article (or RET) doesn't open a new Netscape
> window, it reuses an existing window.
> 
> Has anyone else seen this, too?

Yes, I'm getting the same behavior here, I've just checked it:
Although browse-url-new-window-p is t, Netscape is called with
"-remote openURL(http://...)".  At a first glance the source code
suggests that it should really be "-noraise -remote
openURL(http://...,new-window)".  Also, passing a prefix argument
doesn't have any effect.

-- 
Michael Piotrowski, M.A. <m.piotrowski@springer.de>
Electronic Technologies, Springer-Verlag Heidelberg

Re: browse-url-new-window-p doesn't work?

[Andreas Schwab]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

|> I have set browse-url-new-window-p to t and
|> browse-url-browser-function to browse-url-netscape.  Yet, hitting
|> mouse-2 on a link in an article (or RET) doesn't open a new Netscape
|> window, it reuses an existing window.

---Buffer: *Help*----
browse-url-netscape is an interactive compiled Lisp function in `browse-url'.
(browse-url-netscape URL &optional NEW-WINDOW)
[...]
When called non-interactively, optional second argument NEW-WINDOW is
used instead of `browse-url-new-window-p'.
---------------------

Use this instead:

(defun browse-url-netscape-new-window (url)
  (browse-url-netscape url t))

-- 
Andreas Schwab                                  "And now for something
schwab@suse.de                                   completely different."
SuSE GmbH, Schanzäckerstr. 10, D-90443 Nürnberg

Re: browse-url-new-window-p doesn't work?

[Kai Großjohann]

Andreas Schwab <schwab@suse.de> writes:

> (defun browse-url-netscape-new-window (url)
>   (browse-url-netscape url t))

Right.  Thanks.  Why didn't I see this myself?  Oh, well.

kai
-- 
I like BOTH kinds of music.

Re: browse-url-new-window-p doesn't work?

[Daniel Neri]

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

> I have set browse-url-new-window-p to t and
> browse-url-browser-function to browse-url-netscape.  Yet, hitting
> mouse-2 on a link in an article (or RET) doesn't open a new Netscape
> window, it reuses an existing window.

Andreas Schwab <schwab@suse.de> writes:

> Use this instead:
> 
> (defun browse-url-netscape-new-window (url)
>   (browse-url-netscape url t))

Yeah, this fixes it. Though I think gnus-button-url should honour
browse-url-new-window-p instead. This also benefits users of other
browsers with this capability.

I'm attaching my patch (for 0.96).

Regards,
/Daniel



[-- Attachment #2: gnus-button-url patch --]
[-- Type: text/x-patch, Size: 636 bytes --]

*** gnus-art.el	1999/08/27 22:41:21	1.1
--- gnus-art.el	1999/08/27 22:58:00	1.2
***************
*** 4322,4331 ****
  
  (defun gnus-button-url (address)
    "Browse ADDRESS."
!   ;; In Emacs 20, `browse-url-browser-function' may be an alist.
!   (if (listp browse-url-browser-function)
!       (browse-url address)
!     (funcall browse-url-browser-function address)))
  
  (defun gnus-button-embedded-url (address)
    "Browse ADDRESS."
--- 4322,4328 ----
  
  (defun gnus-button-url (address)
    "Browse ADDRESS."
!   (browse-url address browse-url-new-window-p))
  
  (defun gnus-button-embedded-url (address)
    "Browse ADDRESS."

[-- Attachment #3: Type: TEXT/PLAIN, Size: 36 bytes --]


-- 
Daniel Neri
dne@mayonnaise.net

Re: browse-url-new-window-p doesn't work?

[Lars Magne Ingebrigtsen]

Daniel Neri <dne@mayonnaise.net> writes:

> Yeah, this fixes it. Though I think gnus-button-url should honour
> browse-url-new-window-p instead. This also benefits users of other
> browsers with this capability.

I don't think so.  browse-url should, itself, check its own variables
and not make all its callers supply its own variables to itself.  

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen