From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/74760 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.gnus.general Subject: Re: [gnus git] branch master updated: =2= shr: colorize only in one place ; shr: shr-colorize-region fix and stylesheet color retrieval fix Date: Mon, 06 Dec 2010 16:24:18 +0100 Organization: Programmerer Ingebrigtsen Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1291649088 31742 80.91.229.12 (6 Dec 2010 15:24:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 6 Dec 2010 15:24:48 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M23116=ding+2Daccount=gmane.org@lists.math.uh.edu Mon Dec 06 16:24:43 2010 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PPcvh-00089D-5h for ding-account@gmane.org; Mon, 06 Dec 2010 16:24:41 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1PPcvg-0004Xp-H7 for ding-account@gmane.org; Mon, 06 Dec 2010 09:24:40 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1PPcvf-0004Xk-Ie for ding@lists.math.uh.edu; Mon, 06 Dec 2010 09:24:39 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1PPcvb-0006Oa-4d for ding@lists.math.uh.edu; Mon, 06 Dec 2010 09:24:39 -0600 Original-Received: from lo.gmane.org ([80.91.229.12]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1PPcva-0002gX-00 for ; Mon, 06 Dec 2010 16:24:34 +0100 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PPcva-00084j-1Z for ding@gnus.org; Mon, 06 Dec 2010 16:24:34 +0100 Original-Received: from cm-84.215.34.171.getinternet.no ([84.215.34.171]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 06 Dec 2010 16:24:34 +0100 Original-Received: from larsi by cm-84.215.34.171.getinternet.no with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 06 Dec 2010 16:24:34 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: ding@gnus.org Original-Lines: 43 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: cm-84.215.34.171.getinternet.no Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEX3+fj+/v46OTfK3eD9 //2cvMJ0kJT7jaMzAAACeElEQVQ4jVWTT4+bMBDFoYScsUL2XFEtZ9LZyTnRpns2cWbOKdTz/T9C nw1stxaKovl5/vj5ubg6x8I2tu5zHWl4uOIGYGanf3FXVUW5ANG3L3FXkD8lcOXI/2eEqrwWO+dq s7iCpsRPHXhwqObqub2u8ep7KnUpmgTa2iK5S2LILbdGu4oEU5FwIJLJ5mGbQBCXZamZ9hIIXyhy YAXSm07r3wIFGDs9YcndptcNoBmHM4+p7jvFyF+Bxm2YenSXlEtFOqDOt90KDtdPXQBEiMKzoUNL FVUYewN8NvWDCx+inlOTDKAuDbd3lAp7pnGvwrwBjgJ1Wwkaxvosa0aayjOmaivyFxou4ZlFKdLV koXxALEqpj3XomEDJnRq4pml5r1IeM4LaDlcXdlElci8r9WPfmneQit5tFFmgfj4/AqcxLv9xqUW CFxcWbl13FaMq0fy1a14H6hsmnXcVnz5S2yyaNDfbJqSNwAageYviMRAavM5TtPr4wsQE01mDbj4 H2MSsU3g2JlGnAGuVA1ySiBnHKMmTwyVKvQN2aIN9g0vAAgVvFhjXADm+ZYnmiuespfGJEkj83BE uOsMppr6iEYZOLGZOaJW32mYut7OdMoiir/d8HjihMls6jrknNp8DoU5e+0Mm7XDMl17wCU/Tbr+ 3ud4F+Nbk7XSQPtcaQE9iU+lXLZ5b3eEpgReiZ8bmKXL5VdAf3YJqHk9d6nWsiKRHzJIzbte7ivA y3gWi9txOwDa59ZpX/QL2LUfqCCp95QkoyDZVzq2L9gqy9V2UDvSAgKaQ4l7jqei4S3LPrO3pAQO kyfrLVwBDjifwiV4w5yf2UChdH8BzbLx+2zcUr0AAAAASUVORK5CYII= Mail-Copies-To: never X-Now-Playing: Marine Girls's _Lazy Ways + Beach Party_: "Tutti Lo Sanno" User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:5aEERUaZ3MUSHEkZR7PR8/036ds= X-Spam-Score: -1.9 (-) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:74760 Archived-At: Julien Danjou writes: > - (let ((color (cdr (assq :color shr-stylesheet))) > - (background (cdr (assq :background-color > - shr-stylesheet)))) > - (when (and shr-stylesheet > - (or color background)) > - (shr-colorize-region start (point) color background))))) > + ;; Apply style > + (shr-colorize-region start (point) > + (cdr (assq 'color shr-stylesheet)) > + (cdr (assq 'background-color shr-stylesheet))))) The point of doing it this way is that if you have

foo

bar

zot then each of these will apply "red" to their own bits. That's slow an unnecessary, since, just having the top-level

do it will yield exactly the same result, won't it? > - (shr-stylesheet (list (cons :color fgcolor) > - (cons :background-color bgcolor)))) > - (shr-generic cont) > - (shr-colorize-region start (point) fgcolor bgcolor))) > + (shr-stylesheet (if fgcolor > + (if bgcolor > + `((color . ,fgcolor) > + (background-color . ,bgcolor) ,@shr-stylesheet) > + `((color . ,fgcolor) ,@shr-stylesheet)) > + (if bgcolor > + `((background-color . ,bgcolor) ,@shr-stylesheet) > + shr-stylesheet)))) > + (shr-generic cont))) Same thing here, basically. A will now result in absolutely every element compute and apply their colour, which is slow. Etc. -- (domestic pets only, the antidote for overdose, milk.) larsi@gnus.org * Lars Magne Ingebrigtsen