Re: gnus-agent typo?

[prj@po.cwru.edu (Paul Jarc)]

kai.grossjohann@uni-duisburg.de (Kai Großjohann) wrote:
> I reverted my change and added a comment some days ago.

Ah, there it is.  I didn't see it before for some reason.  But I think
that comment would leave me with (almost) the same impression that I
got from the original code: that seen and recent articles should not
be fetched, regardless of what other marks they may have.  But that's
not what the code does.  I think this would be clearer (also
incorporating Simon's note):

--- lisp/gnus-agent.el	2002/10/23 20:32:01	6.91
+++ lisp/gnus-agent.el	2002/10/24 15:10:57
@@ -1108,9 +1108,11 @@
 	(gnus-decode-encoded-word-function 'identity)
 	(file (gnus-agent-article-name ".overview" group))
 	gnus-agent-cache)
-    ;; Add article with marks to list of article headers we want to
-    ;; fetch.  We don't want to fetch all the seen articles, and we
-    ;; don't want do fetch the recent ones, though.
+    ;; Add articles with marks to the list of article headers we want to
+    ;; fetch.  Don't fetch articles solely on the basis of a recent or seen
+    ;; mark, but do fetch recent or seen articles if they have other, more
+    ;; interesting marks.  (We have to fetch articles with boring marks
+    ;; like 'reply because otherwise the agent will remove their marks.)
     (dolist (arts (gnus-info-marks (gnus-get-info group)))
       (unless (memq (car arts) '(seen recent))
 	(setq articles (gnus-range-add articles (cdr arts)))))


paul