From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/47398 Path: main.gmane.org!not-for-mail From: prj@po.cwru.edu (Paul Jarc) Newsgroups: gmane.emacs.gnus.general Subject: Re: gnus-agent typo? Date: Thu, 24 Oct 2002 11:12:06 -0400 Organization: What did you have in mind? A short, blunt, human pyramid? Sender: owner-ding@hpc.uh.edu Message-ID: References: <84n0pbipvq.fsf@crybaby.cs.uni-dortmund.de> <84hefe3m48.fsf@crybaby.cs.uni-dortmund.de> <84of9l7f3h.fsf@crybaby.cs.uni-dortmund.de> <84of9l6u4j.fsf@crybaby.uni-duisburg.de> <84u1jc9uvb.fsf@crybaby.uni-duisburg.de> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: main.gmane.org 1035472399 3607 80.91.224.249 (24 Oct 2002 15:13:19 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Thu, 24 Oct 2002 15:13:19 +0000 (UTC) Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 184jff-0000vT-00 for ; Thu, 24 Oct 2002 17:13:15 +0200 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 184jez-0006R6-00; Thu, 24 Oct 2002 10:12:33 -0500 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Thu, 24 Oct 2002 10:13:16 -0500 (CDT) Original-Received: from sclp3.sclp.com (qmailr@sclp3.sclp.com [209.196.61.66]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id KAA27100 for ; Thu, 24 Oct 2002 10:13:01 -0500 (CDT) Original-Received: (qmail 19314 invoked by alias); 24 Oct 2002 15:12:13 -0000 Original-Received: (qmail 19309 invoked from network); 24 Oct 2002 15:12:13 -0000 Original-Received: from multivac.student.cwru.edu (HELO multivac.cwru.edu) (@129.22.96.25) by gnus.org with SMTP; 24 Oct 2002 15:12:13 -0000 Original-Received: (qmail 29352 invoked by uid 500); 24 Oct 2002 15:12:29 -0000 Original-To: ding@gnus.org In-Reply-To: <84u1jc9uvb.fsf@crybaby.uni-duisburg.de> (kai.grossjohann@uni-duisburg.de's message of "Thu, 24 Oct 2002 09:08:40 +0200") Mail-Copies-To: nobody Mail-Followup-To: ding@gnus.org Original-Lines: 30 User-Agent: Gnus/5.090008 (Oort Gnus v0.08) Emacs/21.2 (i686-pc-linux-gnu) Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:47398 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:47398 kai.grossjohann@uni-duisburg.de (Kai Gro=DFjohann) wrote: > I reverted my change and added a comment some days ago. Ah, there it is. I didn't see it before for some reason. But I think that comment would leave me with (almost) the same impression that I got from the original code: that seen and recent articles should not be fetched, regardless of what other marks they may have. But that's not what the code does. I think this would be clearer (also incorporating Simon's note): --- lisp/gnus-agent.el 2002/10/23 20:32:01 6.91 +++ lisp/gnus-agent.el 2002/10/24 15:10:57 @@ -1108,9 +1108,11 @@ (gnus-decode-encoded-word-function 'identity) (file (gnus-agent-article-name ".overview" group)) gnus-agent-cache) - ;; Add article with marks to list of article headers we want to - ;; fetch. We don't want to fetch all the seen articles, and we - ;; don't want do fetch the recent ones, though. + ;; Add articles with marks to the list of article headers we want to + ;; fetch. Don't fetch articles solely on the basis of a recent or seen + ;; mark, but do fetch recent or seen articles if they have other, more + ;; interesting marks. (We have to fetch articles with boring marks + ;; like 'reply because otherwise the agent will remove their marks.) (dolist (arts (gnus-info-marks (gnus-get-info group))) (unless (memq (car arts) '(seen recent)) (setq articles (gnus-range-add articles (cdr arts))))) paul