From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/71081 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH] Replace subst-char-in-region by subst-char-in-region Date: Sun, 19 Sep 2010 15:05:21 +0200 Organization: Programmerer Ingebrigtsen Message-ID: References: <1284900370-6551-1-git-send-email-julien@danjou.info> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1284901555 10277 80.91.229.12 (19 Sep 2010 13:05:55 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 19 Sep 2010 13:05:55 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M19454@lists.math.uh.edu Sun Sep 19 15:05:55 2010 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OxJac-0000U7-BS for ding-account@gmane.org; Sun, 19 Sep 2010 15:05:54 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1OxJaJ-0007n5-Fe; Sun, 19 Sep 2010 08:05:35 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1OxJaH-0007mn-Qb for ding@lists.math.uh.edu; Sun, 19 Sep 2010 08:05:33 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1OxJaD-00076N-LA for ding@lists.math.uh.edu; Sun, 19 Sep 2010 08:05:33 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1OxJaC-0001am-00 for ; Sun, 19 Sep 2010 15:05:28 +0200 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OxJaC-0000JB-3u for ding@gnus.org; Sun, 19 Sep 2010 15:05:28 +0200 Original-Received: from cm-84.215.34.171.getinternet.no ([84.215.34.171]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 19 Sep 2010 15:05:28 +0200 Original-Received: from larsi by cm-84.215.34.171.getinternet.no with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 19 Sep 2010 15:05:28 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: ding@gnus.org Original-Lines: 25 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: cm-84.215.34.171.getinternet.no Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEX98OOfdle2j2r12sIA AAIDAwd4RT7ct6AvOnz6AAACW0lEQVQ4jW2UsW7jMAyGhdPgmWpiz1KKalXNQS8Q9wki7w4SdY2l O/D1j5TjoDicRn4mf/InEwXP5wxiAQtwO7endtDnb4Wl/AP4w3ufTxiLaWDagKe4Qs6w+KqLZTBt wMTe2D7lBeCNqwlIDQwjf25TmhfwFeldMi4CarQly7vCUCr+bhIMDFa0+SMf81xgA+ezZNRa4zFD Xub74vxJQEqXpDx6csfZgrf5ak2pfxjcU1KRqJjj3F+DjtK6Fw1OUTyU6+/z4oPCDybUSjHQxbm+ T9e6gf4F4uqcXbJHDMjO9MMGkiInb60x1pFB/pZ2BbS4p9qVUAQse4ZphKpSSkrlfHiCFrcDBaW0 aCzvPzMsECrsZF9weGpspWzF0Ik4GM6YBfC2mwiO4ACKpR1Y40sDSCsYcgK+BBRHYBxUCqxtHsUf ZFEyIBVrjKlsJlcKXdlBDOyi8VxqXbjp6Bh8CagYqyunGNhNGcbtGRWRna+kNLHBSnUyuYCHxsBC UTzhpyODLBusKiitq0aUeCR7OE+52R64AGpWEhLiettNrKgFEYqClkuc5s3dU+RvJaw5/pDbbRrF FpLOWEkKPqRUyxjBEhGLKx000uOlwft84ymkURb7NXzuGcR+IHK0tTue1l38rTgrVmxvxPU2pVbK cy3a42qll8bAWzq9yKczt0kWdVEDEPhRE/JCdF1h2YHjVa9dVF1gC4qAdu1JrQwK8iQhUKh2gV18 ldPfuwp8D7d0uUspuSV6vLrif4b0PJ+fGQwyi28nKr8vfMa17fM+B/wE2MD0HwACWld/AUTB+49c Kn4aAAAAAElFTkSuQmCC Mail-Copies-To: never X-Now-Playing: Jane Siberry's _Maria_: "Lovin' Cup" User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:HSSVg/O5QoeNi3S53zi7gjZy06A= X-Spam-Score: -0.4 (/) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:71081 Archived-At: Julien Danjou writes: > * gnus-sum.el (gnus-summary-update-mark): Use `subst-char-in-string' > rather than `subst-char-in-region' in order to be able to replace ASCII > char by UTF-8 ones. [...] > + (subst-char-in-string (char-after) mark > + (buffer-substring (point) (1+ (point)))))) > + (delete-region (point) (1+ (point))) > + (insert to-insert)) Actually, this takes a large performance hit, so I don't think it should be done. Deleting/inserting something in a buffer moves the buffer gap around, while subst-in-region does not. If you're in a summary buffer with 10K articles, and you hit `C', you'll get 10K buffer gap movements, and it'll be very slow. At least it was when I benchmarked that back in 1996. :-) (It used to use delete/insert before that, if I remember correctly.) -- (domestic pets only, the antidote for overdose, milk.) larsi@gnus.org * Lars Magne Ingebrigtsen