bug in nnrss and solution!

bug in nnrss and solution!

[Joakim Verona]

Hello list,

I found a bug and a solution for it with nnrss.el.

The problem is that articles get marked as new all the time, so you
get multiple copies of the same article.

This happens when an article in the rss feed doesnt have a "link"
element. This is allowed.

There is a workaround in nnrss that uses the "description" element as
a hash instead, when the link element isnt present.

The description element isnt used consistently tough, in one function
its the "publish date" that is used, which I believe is wrong.


the tiny patch below fixes this. (it only changes "5" to "6" really)

Cheers,
/Joakim

diff --unified /home/joakim/.elisp/gnus/lisp/nnrss.el /net/builds/gnus/lisp/nnrss.el
--- /home/joakim/.elisp/gnus/lisp/nnrss.el	2004-07-01 20:42:04.000000000 +0200
+++ /net/builds/gnus/lisp/nnrss.el	2004-05-20 10:02:40.000000000 +0200
@@ -331,9 +331,7 @@
       (let ((coding-system-for-read 'binary))
 	(load file nil t t))
       (dolist (e nnrss-group-data)
-	(puthash (or (nth 2 e) ;JAVE "link"
-		     (nth 6 e) ;JAVE "pubdate" should be "description"
-		     ) t nnrss-group-hashtb)
+	(puthash (or (nth 2 e) (nth 5 e)) t nnrss-group-hashtb)
 	(when (and (car e) (> nnrss-group-min (car e)))
 	  (setq nnrss-group-min (car e)))
 	(when (and (car e) (< nnrss-group-max (car e)))

Re: bug in nnrss and solution!

[Jesper Harder]

Joakim Verona <joakim@verona.se> writes:

> I found a bug and a solution for it with nnrss.el.
>
> the tiny patch below fixes this. (it only changes "5" to "6" really)

Thanks, applied.

-- 
Jesper Harder                                <http://purl.org/harder/>