From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/58043 Path: main.gmane.org!not-for-mail From: Joakim Verona Newsgroups: gmane.emacs.gnus.general Subject: bug in nnrss and solution! Date: Thu, 01 Jul 2004 23:09:52 +0200 Sender: ding-owner@lists.math.uh.edu Message-ID: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1088716475 1133 80.91.224.253 (1 Jul 2004 21:14:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 1 Jul 2004 21:14:35 +0000 (UTC) Original-X-From: ding-owner+M6584@lists.math.uh.edu Thu Jul 01 23:14:24 2004 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Bg8sy-0006Ls-00 for ; Thu, 01 Jul 2004 23:14:24 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1Bg8oo-0006HR-00; Thu, 01 Jul 2004 16:10:06 -0500 Original-Received: from util2.math.uh.edu ([129.7.128.23]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1Bg8oh-0006HI-00 for ding@lists.math.uh.edu; Thu, 01 Jul 2004 16:09:59 -0500 Original-Received: from justine.libertine.org ([66.139.78.221] ident=postfix) by util2.math.uh.edu with esmtp (Exim 4.30) id 1Bg8og-0003n7-2X for ding@lists.math.uh.edu; Thu, 01 Jul 2004 16:09:58 -0500 Original-Received: from main.gmane.org (main.gmane.org [80.91.224.249]) by justine.libertine.org (Postfix) with ESMTP id 23B883A0061 for ; Thu, 1 Jul 2004 16:09:56 -0500 (CDT) Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1Bg8oc-0000oK-00 for ; Thu, 01 Jul 2004 23:09:54 +0200 Original-Received: from c-929672d5.242-1-64736c11.cust.bredbandsbolaget.se ([213.114.150.146]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 01 Jul 2004 23:09:54 +0200 Original-Received: from joakim by c-929672d5.242-1-64736c11.cust.bredbandsbolaget.se with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 01 Jul 2004 23:09:54 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: ding@gnus.org Original-Lines: 36 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: c-929672d5.242-1-64736c11.cust.bredbandsbolaget.se User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3.50 (gnu/linux) Cancel-Lock: sha1:AMvGneFTYTecg2aR8VYHJgoKSoE= Precedence: bulk Xref: main.gmane.org gmane.emacs.gnus.general:58043 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:58043 Hello list, I found a bug and a solution for it with nnrss.el. The problem is that articles get marked as new all the time, so you get multiple copies of the same article. This happens when an article in the rss feed doesnt have a "link" element. This is allowed. There is a workaround in nnrss that uses the "description" element as a hash instead, when the link element isnt present. The description element isnt used consistently tough, in one function its the "publish date" that is used, which I believe is wrong. the tiny patch below fixes this. (it only changes "5" to "6" really) Cheers, /Joakim diff --unified /home/joakim/.elisp/gnus/lisp/nnrss.el /net/builds/gnus/lisp/nnrss.el --- /home/joakim/.elisp/gnus/lisp/nnrss.el 2004-07-01 20:42:04.000000000 +0200 +++ /net/builds/gnus/lisp/nnrss.el 2004-05-20 10:02:40.000000000 +0200 @@ -331,9 +331,7 @@ (let ((coding-system-for-read 'binary)) (load file nil t t)) (dolist (e nnrss-group-data) - (puthash (or (nth 2 e) ;JAVE "link" - (nth 6 e) ;JAVE "pubdate" should be "description" - ) t nnrss-group-hashtb) + (puthash (or (nth 2 e) (nth 5 e)) t nnrss-group-hashtb) (when (and (car e) (> nnrss-group-min (car e))) (setq nnrss-group-min (car e))) (when (and (car e) (< nnrss-group-max (car e)))