Re: CRM114 Mailfilter and spam.el

[Jesper Harder <harder@ifa.au.dk>]

asjo@koldfront.dk (Adam Sjøgren) writes:

> + 		 (if db `("", db) `("")))) ; asjo: I don't know how to do this right.
> +                                            ;       I'd like to add --fileprefix=db if
> +                                            ;       db is set.

Do you mean:

(defun spam-check-crm114 (&optional score)
  "Check the CRM114 Mailfilter back end for the classification of this message."
   (let ((article-buffer-name (buffer-name))
 	(db spam-crm114-database-directory))
     (with-temp-buffer
       (let ((temp-buffer-name (buffer-name)))
	 (with-current-buffer article-buffer-name
	   (apply 'call-process-region
		  (point-min) (point-max)
		  spam-crm114-path
		  nil temp-buffer-name nil
		  (when db (list (concat "--fileprefix=" db)))))
	 (spam-check-crm114-headers score)))))

[untested!]

> + (defcustom spam-crm114-path (executable-find "mailfilter.crm")
> +   "File path of the CRM114 Mailfilter executable program."
> +   :type '(choice (file :tag "Location of CRM114 Mailfilter")
> + 		 (const :tag "CRM114 Mailfilter is not installed"))
> +   :group 'spam-crm114)

This isn't a very good name[1].  I think `spam-crm114-program' would
be clearer.


[1] From the GNU coding standards:

  Please do not use the term ``pathname'' that is used in Unix
  documentation; use ``file name'' (two words) instead.  We use the
  term ``path'' only for search paths, which are lists of directory
  names.
-- 
Jesper Harder                                <http://purl.org/harder/>