Small, but possibly fatal change in nntp.el

Small, but possibly fatal change in nntp.el

[Lars Magne Ingebrigtsen]

I've just committed a change to nntp.el that makes
nntp-open-connection notice whether it got a 200 response back or not,
and if it didn't, it hangs up.  (This is to avoid recursing infinitely
when getting a 400 response back.)  The way I did it Works For Me, but
if you aren't able to connect to an nntp server, poke around in
nntp-open-connection/nntp-wait-for. 

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Small, but possibly fatal change in nntp.el

[Lee Cantey]

>>>>> On Wed Jan 24, Lars writes:

> I've just committed a change to nntp.el that makes
> nntp-open-connection notice whether it got a 200 response back or
> not, and if it didn't, it hangs up.  (This is to avoid recursing
> infinitely when getting a 400 response back.)  The way I did it
> Works For Me, but if you aren't able to connect to an nntp server,
> poke around in nntp-open-connection/nntp-wait-for.

I've found that it sits for some very long period of time until I C-g
out of it.  Should I attempt to trace it or are others having this
too?

Lee

Re: Small, but possibly fatal change in nntp.el

[ShengHuo ZHU]

Lee Cantey <lcantey@borland.com> writes:

> >>>>> On Wed Jan 24, Lars writes:
> 
> > I've just committed a change to nntp.el that makes
> > nntp-open-connection notice whether it got a 200 response back or
> > not, and if it didn't, it hangs up.  (This is to avoid recursing
> > infinitely when getting a 400 response back.)  The way I did it
> > Works For Me, but if you aren't able to connect to an nntp server,
> > poke around in nntp-open-connection/nntp-wait-for.
> 
> I've found that it sits for some very long period of time until I C-g
> out of it.  Should I attempt to trace it or are others having this
> too?

I possibly fixed it.  Please try again.

ShengHuo

Re: Small, but possibly fatal change in nntp.el

[Lee Cantey]

>>>>> On Wed Jan 24, ShengHuo writes:

> Lee Cantey <lcantey@borland.com> writes:
>> >>>>> On Wed Jan 24, Lars writes:
>>
>> > I've just committed a change to nntp.el that makes
>> > nntp-open-connection notice whether it got a 200 response back or
>> > not, and if it didn't, it hangs up.  (This is to avoid recursing
>> > infinitely when getting a 400 response back.)  The way I did it
>> > Works For Me, but if you aren't able to connect to an nntp
>> > server, poke around in nntp-open-connection/nntp-wait-for.
>>
>> I've found that it sits for some very long period of time until I
>> C-g out of it.  Should I attempt to trace it or are others having
>> this too?

> I possibly fixed it.  Please try again.

Fixed, thanks.

Lee

Re: Small, but possibly fatal change in nntp.el

[Russ Allbery]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> I've just committed a change to nntp.el that makes
> nntp-open-connection notice whether it got a 200 response back or not,
> and if it didn't, it hangs up.

I haven't looked at the change, but I assume you're allowing 201 as well?
Read-only servers are useful.

-- 
Russ Allbery (rra@stanford.edu)             <http://www.eyrie.org/~eagle/>

Re: Small, but possibly fatal change in nntp.el

[ShengHuo ZHU]

Russ Allbery <rra@stanford.edu> writes:

> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> 
> > I've just committed a change to nntp.el that makes
> > nntp-open-connection notice whether it got a 200 response back or not,
> > and if it didn't, it hangs up.
> 
> I haven't looked at the change, but I assume you're allowing 201 as well?
> Read-only servers are useful.

201 is allowed now.

ShengHuo

Re: Small, but possibly fatal change in nntp.el

[Didier Verna]

Lars Magne Ingebrigtsen wrote:

> I've just committed a change to nntp.el that makes
> nntp-open-connection notice whether it got a 200 response back or not,
> and if it didn't, it hangs up.  (This is to avoid recursing infinitely
> when getting a 400 response back.)  The way I did it Works For Me, but
> if you aren't able to connect to an nntp server, poke around in
> nntp-open-connection/nntp-wait-for. 

        I'm not sure, but this seems to have completely broken my XEmacs. It
gets a bunch of async replies from the xlib among other similar and very low
level messages. I'm currently using nntp.el from the XEmacs package
distribution. Could you provide the exact patch you applied, so that I can try
to revert it and see if things get better ?

        Thanks.

-- 
    /     /   _   _       Didier Verna       http://www.lrde.epita.fr/~didier
 - / / - / / /_/ /        EPITA / LRDE         mailto:didier@lrde.epita.fr
/_/ / /_/ / /__ /      14-16 rue Voltaire        Tel. +33 (1) 53 14 59 47
                   94276 Kremlin-Bicêtre cedex   Fax. +33 (1) 44 08 01 99