Gnus development mailing list
 help / color / mirror / Atom feed
From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: ding@gnus.org
Subject: IMAP marks went missing from a group
Date: Wed, 29 Dec 2010 18:27:00 +0100	[thread overview]
Message-ID: <m3sjxgij6j.fsf@quimbies.gnus.org> (raw)

While on holiday, I managed to (sort of) reproduce the problem that some
people have seen with marks going missing in a group.

I managed to identify the sequence, and I think it was this:

00:32:10 2530 SELECT "misc".
00:32:10 2531 UID STORE 1684:1685,1694,1707:1708,1785,1803,1808,1816 -FLAGS.SILENT (\Flagged).
00:32:10 2532 UID STORE  -FLAGS.SILENT (gnus-dormant).
00:32:10 2533 UID STORE  -FLAGS.SILENT (\Flagged).
00:32:10 2534 UID STORE  -FLAGS.SILENT (gnus-dormant).
00:32:10 2535 UID STORE  -FLAGS.SILENT (\Flagged).
00:32:10 2536 UID STORE  -FLAGS.SILENT (gnus-dormant).
00:32:10 2537 UID STORE  -FLAGS.SILENT (\Flagged).
00:32:10 2538 UID STORE  -FLAGS.SILENT (gnus-dormant).

From circumstantial evidence, I think this could only have been the
result of trying to enter a group.

Here's a normal enter-a-group sequence, from the same group:

02:05:26 3037 SELECT "misc".
02:05:26 3038 UID FETCH 1684:1685,1694,1707:1708,1785,1803,1808,1816 (UID RFC822.SIZE BODYSTRUCTURE BODY.PEEK[HEADER.FIELDS (Subject From Date Message-Id References In-Reply-To Xref To Newsgroups)]).

Looking at the code, I suspect that there's one real bug here and one
stupid effect of that bug.

I think the SELECT somehow failed, and Gnus somehow came to believe that
there were no articles in the group.  (That's the bug.)  Gnus then
"sanitises" the marks by removing all marks on articles that it now
thinks doesn't exist.  (That's the stupid effect.)

I think the first thing to fix is the marks-sanitation code.  It makes
no sense to send those mark updates to the backend -- if the articles
really don't exist, then there are no marks to sanitise.  If the
articles do exist, then the sanitation is wrong.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen




             reply	other threads:[~2010-12-29 17:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-29 17:27 Lars Magne Ingebrigtsen [this message]
2010-12-30  0:34 ` Dan Christensen
2011-01-02  5:28   ` Lars Magne Ingebrigtsen
2011-01-02 23:53     ` Dan Christensen
2011-01-03  0:03       ` Lars Magne Ingebrigtsen
2011-01-02  5:37 ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3sjxgij6j.fsf@quimbies.gnus.org \
    --to=larsi@gnus.org \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).