Re: [gnus git] branch master updated: Make gnus-group-add-icon work

[Lars Magne Ingebrigtsen <larsi@gnus.org>]

Julien Danjou <julien@danjou.info> writes:

>> I don't think the icon thing should be added to the hook by default...
>
> Why? It does nothing if %E is not used in format, but will not work if
> %E is used.

Hooks are generally for user-enabled stuff.  Even the highlight thing
really shouldn't be in that hook.

And it looks like an expensive function.  It starts with:

  (save-excursion
    (let* ((end (line-end-position))
           ;; now find out where the line starts and leave point there.
           (beg (line-beginning-position)))
      (save-restriction
        (narrow-to-region beg end)
        (goto-char beg)
        (let ((mystart (text-property-any beg end 'gnus-group-icon t)))

And this is run once per line, whether you have %E to or not, isn't it?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen