Re: [gnus git] branch master updated: gnus-start.el (gnus-read-active-for-groups): Run gnus-activate-group for back end that doesn't support request-scan.

Re: [gnus git] branch master updated: gnus-start.el (gnus-read-active-for-groups): Run gnus-activate-group for back end that doesn't support request-scan.

[Lars Magne Ingebrigtsen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> -     ((gnus-check-backend-function 'request-list (car method))
> +     ((gnus-check-backend-function 'request-scan (car method))
>        (gnus-read-active-file-1 method nil infos))
>       (t
>        (dolist (info infos)
> -	(gnus-activate-group (gnus-info-group info) nil nil method t))))))
> +	(gnus-activate-group (gnus-info-group info) nil nil method))))))

No, that can't be right.  Now you're running lock-step group activation
on all backends that don't support request-scan, like nntp, instead of
issuing nntp-request-list.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: [gnus git] branch master updated: gnus-start.el (gnus-read-active-for-groups): Run gnus-activate-group for back end that doesn't support request-scan.

[Katsumi Yamaoka]

Lars Magne Ingebrigtsen <larsi@gnus.org> wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:

> > -     ((gnus-check-backend-function 'request-list (car method))
> > +     ((gnus-check-backend-function 'request-scan (car method))
> >        (gnus-read-active-file-1 method nil infos))
> >       (t
> >        (dolist (info infos)
> > -	(gnus-activate-group (gnus-info-group info) nil nil method t))))))
> > +	(gnus-activate-group (gnus-info-group info) nil nil method))))))

> No, that can't be right.  Now you're running lock-step group activation
> on all backends that don't support request-scan, like nntp, instead of
> issuing nntp-request-list.

(gnus-check-backend-function 'request-list (car method)) is always
true[1], so the previous code never used gnus-activate-group.
Whereas that seems to be the only means for nnrss groups to update.
Do you have an idea?

[1] (info "(gnus)Required Back End Functions")

Re: [gnus git] branch master updated: gnus-start.el (gnus-read-active-for-groups): Run gnus-activate-group for back end that doesn't support request-scan.

[Lars Magne Ingebrigtsen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> (gnus-check-backend-function 'request-list (car method)) is always
> true[1], so the previous code never used gnus-activate-group.

No, nnvirtual doesn't have that one.  :-)  And the dont-subcheck thing
in the last part is also for nnvirtual.

> Whereas that seems to be the only means for nnrss groups to update.
> Do you have an idea?

The request-list thing is supposed to call request-scan, which is what
nnrss needs.  I haven't looked into why that doesn't happen, but I'll do
so tonight.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: [gnus git] branch master updated: gnus-start.el (gnus-read-active-for-groups): Run gnus-activate-group for back end that doesn't support request-scan.

[Lars Magne Ingebrigtsen]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> The request-list thing is supposed to call request-scan, which is what
> nnrss needs.  I haven't looked into why that doesn't happen, but I'll do
> so tonight.

I mean, a request-group with dont-scan set to nil.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: [gnus git] branch master updated: gnus-start.el (gnus-read-active-for-groups): Run gnus-activate-group for back end that doesn't support request-scan.

[Katsumi Yamaoka]

Lars Magne Ingebrigtsen <larsi@gnus.org> wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:

>> (gnus-check-backend-function 'request-list (car method)) is always
>> true[1], so the previous code never used gnus-activate-group.

> No, nnvirtual doesn't have that one.  :-)  And the dont-subcheck thing
> in the last part is also for nnvirtual.

>> Whereas that seems to be the only means for nnrss groups to update.
>> Do you have an idea?

> The request-list thing is supposed to call request-scan, which is what
> nnrss needs.  I haven't looked into why that doesn't happen, but I'll do
> so tonight.

Thanks in advance.  Please note that nnrss-request-list always
makes a question to a user as Dave Goldberg pointed in:

http://article.gmane.org/gmane.emacs.gnus.general/70794

The gnus-group-get-new-news command didn't call it before.

Re: [gnus git] branch master updated: gnus-start.el (gnus-read-active-for-groups): Run gnus-activate-group for back end that doesn't support request-scan.

[Lars Magne Ingebrigtsen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> Thanks in advance.  Please note that nnrss-request-list always
> makes a question to a user as Dave Goldberg pointed in:
>
> http://article.gmane.org/gmane.emacs.gnus.general/70794
>
> The gnus-group-get-new-news command didn't call it before.

Yeah.  I think the nnrss-request-list function should probably just be
removed, and then things will work automatically (with the previous
version of the scanning function), but I haven't tested that.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: [gnus git] branch master updated: gnus-start.el (gnus-read-active-for-groups): Run gnus-activate-group for back end that doesn't support request-scan.

[Lars Magne Ingebrigtsen]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Yeah.  I think the nnrss-request-list function should probably just be
> removed, and then things will work automatically (with the previous
> version of the scanning function), but I haven't tested that.

I hadn't looked at that piece of the code.  Is having a default link to
moreover.com really all that useful?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen