Small article-unsplit-urls fix

Small article-unsplit-urls fix

[Mark Plaksin]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

article-unsplit-urls (W u from the Summary Buffer) turns this:
http://cnn.com
http://ibm.com

into this:
http://cnn.comhttp://ibm.com

Attached is a small patch to fix this.


[-- Attachment #2: gnus-art.el patch --]
[-- Type: text/plain, Size: 504 bytes --]

--- gnus-art.el	2005-11-28 09:37:06.000000000 -0500
+++ gnus-art.el.new	2005-12-01 12:51:02.000000000 -0500
@@ -2494,7 +2494,9 @@
       (goto-char (point-min))
       (while (re-search-forward
 	      "\\(\\(https?\\|ftp\\)://\\S-+\\) *\n\\(\\S-+\\)" nil t)
-	(replace-match "\\1\\3" t)))
+        (if (save-match-data
+              (not (string-match "^\\(https?\\|ftp\\):" (match-string 3))))
+            (replace-match "\\1\\3" t))))
     (when (interactive-p)
       (gnus-treat-article nil))))
 

Re: Small article-unsplit-urls fix

[Mark Plaksin]

Mark Plaksin <happy@usg.edu> writes:

> article-unsplit-urls (W u from the Summary Buffer) turns this:
> http://cnn.com
> http://ibm.com
>
> into this:
> http://cnn.comhttp://ibm.com
>
> Attached is a small patch to fix this.

Hmm, now it fails on this:

Hey you should check out http://cnn.com
really!

On second thought it seems there's nothing to fix--people probably only run
it when it's obvious that it will do the right thing.

Re: Small article-unsplit-urls fix

[Lars Magne Ingebrigtsen]

Mark Plaksin <happy@usg.edu> writes:

> On second thought it seems there's nothing to fix--people probably only run
> it when it's obvious that it will do the right thing.

Yup.  However, I do feel that Gnus should try to do something with
broken URLs automatically.

But I'm not quite sure what.  :-)

When being presented with

<http://www.sfgate.com/cgi-bin/article.cgi?file=/c/a/2006/03/25/
MNG6OHU6RR1.DTL&type=printable>

it doesn't take much logic to find out that that's really a single
URL.

Or even this:

http://www.sfgate.com/cgi-bin/article.cgi?file=/c/a/2006/03/25/
MNG6OHU6RR1.DTL&type=printable

However, this isn't:

http://www.sfgate.com/cgi-bin/article.cgi?file=/c/a/2006/03/25/
doesn't work.

In quoted text it gets marginally more difficult:

>> > <http://www.sfgate.com/cgi-bin/article.cgi?file=/c/a/2006/03/25/
>> > MNG6OHU6RR1.DTL&type=printable>

I think some work in this department would be welcome, but I'm not
quite sure where to start.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen