* ignore-errors in message-do-actions?
@ 2003-12-19 1:09 Jesper Harder
2003-12-31 2:05 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Jesper Harder @ 2003-12-19 1:09 UTC (permalink / raw)
Is there a good reason `ignore-errors' is used in
`message-do-actions'? I can't see any obvious reason why it's needed:
(defun message-do-actions (actions)
"Perform all actions in ACTIONS."
;; Now perform actions on successful sending.
(while actions
(ignore-errors
(cond
;; A simple function.
((functionp (car actions))
(funcall (car actions)))
;; Something to be evaled.
(t
(eval (car actions)))))
(pop actions)))
It was hiding a bug in `gnus-inews-add-send-actions', which would have
been detected much sooner if ignore-errors hadn't been used.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: ignore-errors in message-do-actions?
2003-12-19 1:09 ignore-errors in message-do-actions? Jesper Harder
@ 2003-12-31 2:05 ` Lars Magne Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Magne Ingebrigtsen @ 2003-12-31 2:05 UTC (permalink / raw)
Jesper Harder <harder@ifa.au.dk> writes:
> Is there a good reason `ignore-errors' is used in
> `message-do-actions'? I can't see any obvious reason why it's needed:
Me neither. Perhaps it should be removed in No Gnus.
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-12-31 2:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-12-19 1:09 ignore-errors in message-do-actions? Jesper Harder
2003-12-31 2:05 ` Lars Magne Ingebrigtsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).