From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/55277
Path: main.gmane.org!not-for-mail
From: Jesper Harder <harder@ifa.au.dk>
Newsgroups: gmane.emacs.gnus.general
Subject: ignore-errors in message-do-actions?
Date: Fri, 19 Dec 2003 02:09:26 +0100
Sender: ding-owner@lists.math.uh.edu
Message-ID: <m3u13x396h.fsf@defun.localdomain>
NNTP-Posting-Host: deer.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: sea.gmane.org 1071796847 3933 80.91.224.253 (19 Dec 2003 01:20:47 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Fri, 19 Dec 2003 01:20:47 +0000 (UTC)
Original-X-From: ding-owner+M3817@lists.math.uh.edu Fri Dec 19 02:20:41 2003
Return-path: <ding-owner+M3817@lists.math.uh.edu>
Original-Received: from malifon.math.uh.edu ([129.7.128.13])
	by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AX9Jp-0000tQ-00
	for <ding-account@gmane.org>; Fri, 19 Dec 2003 02:20:41 +0100
Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu)
	by malifon.math.uh.edu with smtp (Exim 3.20 #1)
	id 1AX9JD-0006c2-00; Thu, 18 Dec 2003 19:20:03 -0600
Original-Received: from justine.libertine.org ([66.139.78.221] ident=postfix)
	by malifon.math.uh.edu with esmtp (Exim 3.20 #1)
	id 1AX9J5-0006bl-00
	for ding@lists.math.uh.edu; Thu, 18 Dec 2003 19:19:55 -0600
Original-Received: from pfepa.post.tele.dk (pfepa.post.tele.dk [195.41.46.235])
	by justine.libertine.org (Postfix) with ESMTP id 489F53A0056
	for <ding@gnus.org>; Thu, 18 Dec 2003 19:19:55 -0600 (CST)
Original-Received: from [195.249.82.168] (0xc3f952a8.esnxr1.ras.tele.dk [195.249.82.168])
	by pfepa.post.tele.dk (Postfix) with ESMTP id 75D7747FE64
	for <ding@gnus.org>; Fri, 19 Dec 2003 02:19:53 +0100 (CET)
Original-To: ding@gnus.org
Mail-Followup-To: ding@gnus.org
User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (gnu/linux)
Precedence: bulk
Xref: main.gmane.org gmane.emacs.gnus.general:55277
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:55277

Is there a good reason `ignore-errors' is used in
`message-do-actions'?  I can't see any obvious reason why it's needed:

(defun message-do-actions (actions)
  "Perform all actions in ACTIONS."
  ;; Now perform actions on successful sending.
  (while actions
    (ignore-errors 
      (cond
       ;; A simple function.
       ((functionp (car actions))
	(funcall (car actions)))
       ;; Something to be evaled.
       (t
	(eval (car actions)))))
    (pop actions)))

It was hiding a bug in `gnus-inews-add-send-actions', which would have
been detected much sooner if ignore-errors hadn't been used.