Re: Refactoring of mml1991.el, mml2015.el, mml-smime.el

[Daiki Ueno <ueno@gnu.org>]

Jens Lechtenboerger <jens.lechtenboerger@fsfe.org> writes:

> On 2014-09-21, at 12:08, Jens Lechtenboerger wrote:
>
>> 5. Refactoring
>> mml1991.el, mml2015.el, and mml-smime.el share code, forcing
>> copy-and-paste on updates.
>
> Hi there,
>
> this is a continuation of a one year old thread.  Sorry for the delay.
> Essentially, I proposed a refactoring of mml1991.el, mml2015.el, and
> mml-smime.el such that common code can be maintained in a single file.

Thanks for working on that.  I am afraid I don't have time at the moment
to go through the patch, but maybe you can go ahead and we could fix it
later on if any problem arises?

> In my code, each pair is replaced with a single variable with the prefix
> “mml-epg-openpgp”, e.g., “mml-epg-openpgp-cache-passphrase”.
>
> Concerning S/MIME, I introduced the same variables with prefix
> “mml-epg-smime”.

The prefix "mml-epg" sounds a bit too much implementation detail.  How
about renaming those prefixes to mml{,-secure}-pgpmime /
mml{,-secure}-smime and moving to mml-sec.el?

(I would use the word "pgpmime" to distinguish PGP/MIME signatures from
inline PGP signatures.  I remember there is already a use of the word in
Gnus).

> A tarball with my files is available over there (README.txt explains its
> contents):
> http://informationelle-selbstbestimmung-im-internet.de/emacs/mml-epg-2015-10-16.tar.bz2
> http://informationelle-selbstbestimmung-im-internet.de/emacs/mml-epg-2015-10-16.tar.bz2.asc

I saw a few functions prefixed with "jl-".  Maybe they can be moved to
mm-util.el or gnus-util.el?

Thanks,
-- 
Daiki Ueno