From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/86260 Path: news.gmane.org!not-for-mail From: Daiki Ueno Newsgroups: gmane.emacs.gnus.general Subject: Re: Refactoring of mml1991.el, mml2015.el, mml-smime.el Date: Fri, 06 Nov 2015 11:10:23 +0900 Message-ID: References: <86wq8xffpv.fsf@informationelle-selbstbestimmung-im-internet.de> <87k2qmsrt1.fsf@informationelle-selbstbestimmung-im-internet.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1446775915 11058 80.91.229.3 (6 Nov 2015 02:11:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 6 Nov 2015 02:11:55 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M34494@lists.math.uh.edu Fri Nov 06 03:11:43 2015 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from lists1.math.uh.edu ([129.7.128.208]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZuWVD-0003nM-19 for ding-account@gmane.org; Fri, 06 Nov 2015 03:11:43 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by lists1.math.uh.edu with smtp (Exim 4.85) (envelope-from ) id 1ZuWUJ-0004a2-Lq; Thu, 05 Nov 2015 20:10:47 -0600 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by lists1.math.uh.edu with esmtps (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.85) (envelope-from ) id 1ZuWUF-0004ZQ-Ra for ding@lists.math.uh.edu; Thu, 05 Nov 2015 20:10:43 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtps (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.85) (envelope-from ) id 1ZuWUE-0005e4-9q for ding@lists.math.uh.edu; Thu, 05 Nov 2015 20:10:43 -0600 Original-Received: from eggs.gnu.org ([208.118.235.92]) by quimby.gnus.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1ZuWUC-0006fl-6V for ding@gnus.org; Fri, 06 Nov 2015 03:10:40 +0100 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuWU2-0001Z0-3G for ding@gnus.org; Thu, 05 Nov 2015 21:10:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuWU1-0001Yw-WA for ding@gnus.org; Thu, 05 Nov 2015 21:10:30 -0500 Original-Received: from du-a.org ([219.94.251.20]:45902 helo=dhcp-217-92.nrt.redhat.com) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ZuWU1-000101-62 for ding@gnus.org; Thu, 05 Nov 2015 21:10:29 -0500 In-Reply-To: <87k2qmsrt1.fsf@informationelle-selbstbestimmung-im-internet.de> (Jens Lechtenboerger's message of "Fri, 16 Oct 2015 18:26:34 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:86260 Archived-At: Jens Lechtenboerger writes: > On 2014-09-21, at 12:08, Jens Lechtenboerger wrote: > >> 5. Refactoring >> mml1991.el, mml2015.el, and mml-smime.el share code, forcing >> copy-and-paste on updates. > > Hi there, > > this is a continuation of a one year old thread. Sorry for the delay. > Essentially, I proposed a refactoring of mml1991.el, mml2015.el, and > mml-smime.el such that common code can be maintained in a single file. Thanks for working on that. I am afraid I don't have time at the moment to go through the patch, but maybe you can go ahead and we could fix it later on if any problem arises? > In my code, each pair is replaced with a single variable with the prefix > =E2=80=9Cmml-epg-openpgp=E2=80=9D, e.g., =E2=80=9Cmml-epg-openpgp-cache-p= assphrase=E2=80=9D. > > Concerning S/MIME, I introduced the same variables with prefix > =E2=80=9Cmml-epg-smime=E2=80=9D. The prefix "mml-epg" sounds a bit too much implementation detail. How about renaming those prefixes to mml{,-secure}-pgpmime / mml{,-secure}-smime and moving to mml-sec.el? (I would use the word "pgpmime" to distinguish PGP/MIME signatures from inline PGP signatures. I remember there is already a use of the word in Gnus). > A tarball with my files is available over there (README.txt explains its > contents): > http://informationelle-selbstbestimmung-im-internet.de/emacs/mml-epg-2015= -10-16.tar.bz2 > http://informationelle-selbstbestimmung-im-internet.de/emacs/mml-epg-2015= -10-16.tar.bz2.asc I saw a few functions prefixed with "jl-". Maybe they can be moved to mm-util.el or gnus-util.el? Thanks, --=20 Daiki Ueno