From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/83828 Path: news.gmane.org!not-for-mail From: Daiki Ueno Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH 0/2] Simpler authentication with SASL Date: Mon, 28 Oct 2013 16:02:55 +0900 Message-ID: References: <1382784881-16736-1-git-send-email-tarleb@moltkeplatz.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1382943860 10412 80.91.229.3 (28 Oct 2013 07:04:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Oct 2013 07:04:20 +0000 (UTC) Cc: ding@gnus.org To: Albert Krewinkel Original-X-From: ding-owner+M32084@lists.math.uh.edu Mon Oct 28 08:04:25 2013 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VagsB-0007cx-VI for ding-account@gmane.org; Mon, 28 Oct 2013 08:04:24 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1Vagqz-0001Xq-7Y; Mon, 28 Oct 2013 02:03:09 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1Vagqv-0001XZ-2w for ding@lists.math.uh.edu; Mon, 28 Oct 2013 02:03:05 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtps (TLSv1:AES128-SHA:128) (Exim 4.76) (envelope-from ) id 1Vagqs-0006WF-SG for ding@lists.math.uh.edu; Mon, 28 Oct 2013 02:03:04 -0500 Original-Received: from fencepost.gnu.org ([208.118.235.10] ident=Debian-exim) by quimby.gnus.org with esmtp (Exim 4.80) (envelope-from ) id 1Vagqr-0005FH-4r for ding@gnus.org; Mon, 28 Oct 2013 08:03:01 +0100 Original-Received: from du-a.org ([2001:e41:db5e:fb14::1]:41360 helo=localhost.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1Vagqp-000882-6M; Mon, 28 Oct 2013 03:02:59 -0400 In-Reply-To: <1382784881-16736-1-git-send-email-tarleb@moltkeplatz.de> (Albert Krewinkel's message of "Sat, 26 Oct 2013 12:54:39 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Spam-Score: -8.4 (--------) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:83828 Archived-At: Albert Krewinkel writes: > Please let me know what you think of the proposed changes. The > patches are also available at github (https://github.com/tarleb/gnus). Thanks for the patches. However, as sasl.el is also distributed as part of Emacs (under lisp/net/), you can't simply rename the API functions. Also, the 1/2 patch looks too large to review. I'd suggest to work with Emacs rather than Gnus and do the things step by step: (1) write unit tests so not to break the core functionality (2) refactor the code (without breaking the API), say, using cl-defstruct; you can rename the constructor with :constructor keyword (3) add handy helper functions e.g. sasl-authenticate Regards, -- Daiki Ueno