* Old boundary
@ 1998-11-18 13:49 Lars Magne Ingebrigtsen
1998-11-18 14:58 ` Vladimir Volovich
0 siblings, 1 reply; 9+ messages in thread
From: Lars Magne Ingebrigtsen @ 1998-11-18 13:49 UTC (permalink / raw)
[-- Attachment #1: Type: image/jpeg, Size: 889 bytes --]
[-- Attachment #2.1: Type: text/plain, Size: 19 bytes --]
This is something
[-- Attachment #2.2: Type: text/plain, Size: 18 bytes --]
This is the same
[-- Attachment #2.3.1: Type: image/jpeg, Size: 889 bytes --]
[-- Attachment #3: Type: text/plain, Size: 106 bytes --]
--
(domestic pets only, the antidote for overdose, milk.)
larsi@ifi.uio.no * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Old boundary
1998-11-18 13:49 Old boundary Lars Magne Ingebrigtsen
@ 1998-11-18 14:58 ` Vladimir Volovich
1998-11-18 16:57 ` Shenghuo ZHU
0 siblings, 1 reply; 9+ messages in thread
From: Vladimir Volovich @ 1998-11-18 14:58 UTC (permalink / raw)
"LMI" == Lars Magne Ingebrigtsen writes:
LMI> 3. [ ] text/plain [ ] text/plain [*] multipart/mixed
When clicking on the multipart/mixed and then on any of text/plain, i
get an error (pgnus-0.50):
Signaling: (wrong-type-argument integer-or-marker-p nil)
gnus-mime-display-alternative(((#<buffer *mm*<3>> ("text/plain") nil nil nil nil) (#<buffer *mm*<4>> ("text/plain") nil nil nil nil) ("multipart/mixed" (#<buffer *mm*<5>> ... base64 nil nil nil))) (#<buffer *mm*<3>> ("text/plain") nil nil nil nil) (#<marker at 2112 in *Article*>) 3)
(lambda (handles) (gnus-mime-display-alternative (quote ...) (quote ...) (quote ...) 3))((#<buffer *mm*<3>> ("text/plain") nil nil nil nil))
gnus-article-press-button()
gnus-widget-press-button((link :delete widget-leave-text :action gnus-widget-press-button :button-keymap nil :from #<marker (before-insertion) at 2116 in *Article*> :to #<marker at 2138 in *Article*> :button-overlay #<overlay from 2116 to 2138 in *Article*>) (mouse-2 (#<window 20 on *Article*> 2118 (49 . 193) 62618381)))
widget-apply((link :delete widget-leave-text :action gnus-widget-press-button :button-keymap nil :from #<marker (before-insertion) at 2116 in *Article*> :to #<marker at 2138 in *Article*> :button-overlay #<overlay from 2116 to 2138 in *Article*>) :action (mouse-2 (#<window 20 on *Article*> 2118 (49 . 193) 62618381)))
widget-apply-action((link :delete widget-leave-text :action gnus-widget-press-button :button-keymap nil :from #<marker (before-insertion) at 2116 in *Article*> :to #<marker at 2138 in *Article*> :button-overlay #<overlay from 2116 to 2138 in *Article*>) (mouse-2 (#<window 20 on *Article*> 2118 (49 . 193) 62618381)))
widget-button-click((down-mouse-2 (#<window 20 on *Article*> 2118 (49 . 193) 62618271)))
* call-interactively(widget-button-click)
Best regards, -- Vladimir.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Old boundary
1998-11-18 14:58 ` Vladimir Volovich
@ 1998-11-18 16:57 ` Shenghuo ZHU
1998-11-18 17:32 ` Karl Kleinpaste
1998-11-19 14:25 ` Vladimir Volovich
0 siblings, 2 replies; 9+ messages in thread
From: Shenghuo ZHU @ 1998-11-18 16:57 UTC (permalink / raw)
>>>>> "VVV" == Vladimir Volovich <vvv@vvv.vsu.ru> writes:
VVV> "LMI" == Lars Magne Ingebrigtsen writes:
LMI> 3. [ ] text/plain [ ] text/plain [*] multipart/mixed
VVV> When clicking on the multipart/mixed and then on any of text/plain, i
VVV> get an error (pgnus-0.50):
Fixed.
Another fixed bug is that nothing is displayed when no part is
preferred.
A patch.
--
Shenghuo
:- cut -----
--- ChangeLog 1998/11/18 16:47:54 1.1
+++ ChangeLog 1998/11/18 16:54:51
@@ -1,3 +1,8 @@
+Wed Nov 18 11:52:19 1998 Shenghuo ZHU <zsh@cs.rochester.edu>
+
+ * gnus-art.el (gnus-mime-display-alternative): Set end of
+ multipart and display even when nothing is preferred.
+
Wed Nov 18 05:06:44 1998 Lars Magne Ingebrigtsen <larsi@menja.ifi.uio.no>
* gnus.el: Pterodactyl Gnus v0.50 is released.
--- gnus-art.el 1998/11/18 16:48:51 1.1
+++ gnus-art.el 1998/11/18 16:50:23
@@ -2477,25 +2477,49 @@
(ihandles handles)
(point (point))
handle buffer-read-only from props begend not-pref)
- (when preferred
- (save-restriction
- (when ibegend
- (narrow-to-region (car ibegend) (cdr ibegend))
- (delete-region (point-min) (point-max))
- (mm-remove-parts handles))
- (setq begend (list (point-marker)))
- ;; Do the toggle.
- (unless (setq not-pref (cadr (member preferred ihandles)))
- (setq not-pref (car ihandles)))
+ (save-restriction
+ (when ibegend
+ (narrow-to-region (car ibegend) (cdr ibegend))
+ (delete-region (point-min) (point-max))
+ (mm-remove-parts handles))
+ (setq begend (list (point-marker)))
+ ;; Do the toggle.
+ (unless (setq not-pref (cadr (member preferred ihandles)))
+ (setq not-pref (car ihandles)))
+ (gnus-add-text-properties
+ (setq from (point))
+ (progn
+ (insert (format "%d. " id))
+ (point))
+ `(gnus-callback
+ (lambda (handles)
+ (gnus-mime-display-alternative
+ ',ihandles ',not-pref
+ ',begend ,id))
+ local-map ,gnus-mime-button-map
+ ,gnus-mouse-face-prop ,gnus-article-mouse-face
+ face ,gnus-article-button-face
+ keymap ,gnus-mime-button-map
+ gnus-part ,id
+ gnus-data ,handle))
+ (widget-convert-button 'link from (point)
+ :action 'gnus-widget-press-button
+ :button-keymap gnus-widget-button-keymap)
+ ;; Do the handles
+ (while (setq handle (pop handles))
(gnus-add-text-properties
(setq from (point))
(progn
- (insert (format "%d. " id))
+ (insert (format "[%c] %-18s"
+ (if (equal handle preferred) ?* ? )
+ (if (stringp (car handle))
+ (car handle)
+ (car (mm-handle-type handle)))))
(point))
`(gnus-callback
(lambda (handles)
(gnus-mime-display-alternative
- ',ihandles ',not-pref
+ ',ihandles ',handle
',begend ,id))
local-map ,gnus-mime-button-map
,gnus-mouse-face-prop ,gnus-article-mouse-face
@@ -2506,41 +2530,16 @@
(widget-convert-button 'link from (point)
:action 'gnus-widget-press-button
:button-keymap gnus-widget-button-keymap)
- ;; Do the handles
- (while (setq handle (pop handles))
- (gnus-add-text-properties
- (setq from (point))
- (progn
- (insert (format "[%c] %-18s"
- (if (equal handle preferred) ?* ? )
- (if (stringp (car handle))
- (car handle)
- (car (mm-handle-type handle)))))
- (point))
- `(gnus-callback
- (lambda (handles)
- (gnus-mime-display-alternative
- ',ihandles ',handle
- ',begend ,id))
- local-map ,gnus-mime-button-map
- ,gnus-mouse-face-prop ,gnus-article-mouse-face
- face ,gnus-article-button-face
- keymap ,gnus-mime-button-map
- gnus-part ,id
- gnus-data ,handle))
- (widget-convert-button 'link from (point)
- :action 'gnus-widget-press-button
- :button-keymap gnus-widget-button-keymap)
- (insert " "))
- (insert "\n\n")
- (when preferred
- (if (stringp (car preferred))
- (gnus-display-mime preferred)
- (mm-display-part preferred)
- (goto-char (point-max))
- (setcdr begend (point-marker)))))
- (when ibegend
- (goto-char point)))))
+ (insert " "))
+ (insert "\n\n")
+ (when preferred
+ (if (stringp (car preferred))
+ (gnus-display-mime preferred)
+ (mm-display-part preferred)
+ (goto-char (point-max)))
+ (setcdr begend (point-marker))))
+ (when ibegend
+ (goto-char point))))
(defun gnus-article-wash-status ()
"Return a string which display status of article washing."
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Old boundary
1998-11-18 16:57 ` Shenghuo ZHU
@ 1998-11-18 17:32 ` Karl Kleinpaste
1998-11-19 2:57 ` Lars Magne Ingebrigtsen
1998-11-19 14:25 ` Vladimir Volovich
1 sibling, 1 reply; 9+ messages in thread
From: Karl Kleinpaste @ 1998-11-18 17:32 UTC (permalink / raw)
Vladimir Volovich <vvv@vvv.vsu.ru> writes:
>> When clicking on the multipart/mixed and then on any of text/plain, i
>> get an error (pgnus-0.50):
Shenghuo ZHU <zsh@cs.rochester.edu> writes:
> Fixed.
Thanx much. One other minor point, though: Both before and after the
patch, the 2nd text/plain portion of that multipart segment displays
as *This is the same* (i.e., boldface), and even when one cycles back
around to the 1st text/plain portion, it too redisplays in boldface
(*This is something*). The original non-font-switched text/plain
rendering is gone.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Old boundary
1998-11-18 17:32 ` Karl Kleinpaste
@ 1998-11-19 2:57 ` Lars Magne Ingebrigtsen
0 siblings, 0 replies; 9+ messages in thread
From: Lars Magne Ingebrigtsen @ 1998-11-19 2:57 UTC (permalink / raw)
Karl Kleinpaste <karl@justresearch.com> writes:
> Thanx much. One other minor point, though: Both before and after the
> patch, the 2nd text/plain portion of that multipart segment displays
> as *This is the same* (i.e., boldface), and even when one cycles back
> around to the 1st text/plain portion, it too redisplays in boldface
> (*This is something*). The original non-font-switched text/plain
> rendering is gone.
I think this is a problem with decode-coding-region -- it isn't very
kind to text props. (Or anything else, for that matter.)
Hm. Or perhaps it's a bleed-off from the buttons...
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Old boundary
1998-11-18 16:57 ` Shenghuo ZHU
1998-11-18 17:32 ` Karl Kleinpaste
@ 1998-11-19 14:25 ` Vladimir Volovich
1998-11-20 2:29 ` Lars Magne Ingebrigtsen
1 sibling, 1 reply; 9+ messages in thread
From: Vladimir Volovich @ 1998-11-19 14:25 UTC (permalink / raw)
"ZSH" == Shenghuo ZHU writes:
VVV> When clicking on the multipart/mixed and then on any of
VVV> text/plain, i get an error (pgnus-0.50):
ZSH> Fixed.
Thanks a lot. One more tiny glitch: when switching between the
multipart/mixed and text/plain parts the number assigned to image/jpeg
constantly increases by 1. :-)
And it is numbered incorrectly (should be like 3.1, i guess).
[1. image/jpeg]...
[2. text/plain]
3. [ ] text/plain [ ] text/plain [*] multipart/mixed
[12. image/jpeg]...
[4. text/plain]
Best regards, -- Vladimir.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Old boundary
1998-11-19 14:25 ` Vladimir Volovich
@ 1998-11-20 2:29 ` Lars Magne Ingebrigtsen
1998-11-20 7:48 ` Vladimir Volovich
0 siblings, 1 reply; 9+ messages in thread
From: Lars Magne Ingebrigtsen @ 1998-11-20 2:29 UTC (permalink / raw)
Vladimir Volovich <vvv@vvv.vsu.ru> writes:
> Thanks a lot. One more tiny glitch: when switching between the
> multipart/mixed and text/plain parts the number assigned to image/jpeg
> constantly increases by 1. :-)
Yup. Fix in Pterodactyl Gnus v0.52.
> And it is numbered incorrectly (should be like 3.1, i guess).
No, they are numbered by integers, and not by hierarchy.
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Old boundary
1998-11-20 2:29 ` Lars Magne Ingebrigtsen
@ 1998-11-20 7:48 ` Vladimir Volovich
1998-11-20 15:22 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 9+ messages in thread
From: Vladimir Volovich @ 1998-11-20 7:48 UTC (permalink / raw)
"LMI" == Lars Magne Ingebrigtsen writes:
LMI> Vladimir Volovich <vvv@vvv.vsu.ru> writes:
>> Thanks a lot. One more tiny glitch: when switching between the
>> multipart/mixed and text/plain parts the number assigned to
>> image/jpeg constantly increases by 1. :-)
LMI> Yup. Fix in Pterodactyl Gnus v0.52.
Thanks. Here is how it looks now. A bit strange, --- there is no
number 4 (not shown as a text/plain part, i guess?), but there is
number 5.
[1. image/jpeg]...
3. [ ] text/plain [ ] text/plain [*] multipart/mixed
[5. image/jpeg]...
>> And it is numbered incorrectly (should be like 3.1, i guess).
LMI> No, they are numbered by integers, and not by hierarchy.
But here is how the article looks like after C-d'ing (VERY nice :) :
[ 87: Lars Magne Ingebrigt] <* mixed> Old boundary
[ 18: Lars Magne Ingebrigt] <1 jpeg>
[ 1: Lars Magne Ingebrigt] <2 text>
[ 41: Lars Magne Ingebrigt] <3.* alternative>
[ 2: Lars Magne Ingebrigt] <3.1 text>
[ 2: Lars Magne Ingebrigt] <3.2 text>
[ 25: Lars Magne Ingebrigt] <3.3.* mixed>
[ 18: Lars Magne Ingebrigt] <3.3.1 jpeg>
[ 5: Lars Magne Ingebrigt] <4 text>
The jpeg part is numbered 3.3.1. Or are the numbering systems in those
cases different?
Best regards, -- Vladimir.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Old boundary
1998-11-20 7:48 ` Vladimir Volovich
@ 1998-11-20 15:22 ` Lars Magne Ingebrigtsen
0 siblings, 0 replies; 9+ messages in thread
From: Lars Magne Ingebrigtsen @ 1998-11-20 15:22 UTC (permalink / raw)
Vladimir Volovich <vvv@vvv.vsu.ru> writes:
> Thanks. Here is how it looks now. A bit strange, --- there is no
> number 4 (not shown as a text/plain part, i guess?), but there is
> number 5.
Yes. The numbering is done even if the buttons aren't shown.
> The jpeg part is numbered 3.3.1. Or are the numbering systems in those
> cases different?
The buttons aren't numbered hierarchically.
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~1998-11-20 15:22 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1998-11-18 13:49 Old boundary Lars Magne Ingebrigtsen
1998-11-18 14:58 ` Vladimir Volovich
1998-11-18 16:57 ` Shenghuo ZHU
1998-11-18 17:32 ` Karl Kleinpaste
1998-11-19 2:57 ` Lars Magne Ingebrigtsen
1998-11-19 14:25 ` Vladimir Volovich
1998-11-20 2:29 ` Lars Magne Ingebrigtsen
1998-11-20 7:48 ` Vladimir Volovich
1998-11-20 15:22 ` Lars Magne Ingebrigtsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).