* A Cleaner Build
@ 2011-03-17 18:42 Lars Magne Ingebrigtsen
2011-03-17 18:50 ` David Engster
0 siblings, 1 reply; 8+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-03-17 18:42 UTC (permalink / raw)
To: ding
I've started tackling the warnings in the Gnus build. But here's one I
don't understand:
Compiling /home/larsi/pgnus/lisp/gnus-gravatar.el...
While compiling toplevel forms in file /home/larsi/pgnus/lisp/gnus-gravatar.el:
!! Symbol's function definition is void ((locate-user-emacs-file))
This is with XEmacs 21.4.
Anybody know what's that about? The symbol doesn't seem to exist...
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: A Cleaner Build
2011-03-17 18:42 A Cleaner Build Lars Magne Ingebrigtsen
@ 2011-03-17 18:50 ` David Engster
2011-03-17 18:58 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 8+ messages in thread
From: David Engster @ 2011-03-17 18:50 UTC (permalink / raw)
To: ding
Lars Magne Ingebrigtsen writes:
> I've started tackling the warnings in the Gnus build. But here's one I
> don't understand:
>
> Compiling /home/larsi/pgnus/lisp/gnus-gravatar.el...
> While compiling toplevel forms in file /home/larsi/pgnus/lisp/gnus-gravatar.el:
> !! Symbol's function definition is void ((locate-user-emacs-file))
Isn't that a real error?
Anyway, I don't see that one in the stdio from
http://randomsample.de:4456/builders/xemacs21.4-linux/builds/4/steps/compile/logs/stdio
Instead, there's
While compiling the end of the data in file /var/lib/buildbot/slaves/debian/build-xemacs21.4/build/lisp/gravatar.el:
** the function url-retrieve-synchronously is not known to be defined.
-David
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: A Cleaner Build
2011-03-17 18:50 ` David Engster
@ 2011-03-17 18:58 ` Lars Magne Ingebrigtsen
2011-03-17 19:00 ` Lars Magne Ingebrigtsen
2011-03-17 20:55 ` David Engster
0 siblings, 2 replies; 8+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-03-17 18:58 UTC (permalink / raw)
To: ding
David Engster <deng@randomsample.de> writes:
> Lars Magne Ingebrigtsen writes:
>> I've started tackling the warnings in the Gnus build. But here's one I
>> don't understand:
>>
>> Compiling /home/larsi/pgnus/lisp/gnus-gravatar.el...
>> While compiling toplevel forms in file
>> /home/larsi/pgnus/lisp/gnus-gravatar.el:
>> !! Symbol's function definition is void ((locate-user-emacs-file))
>
> Isn't that a real error?
>
> Anyway, I don't see that one in the stdio from
No, it's from when I'm trying to build Gnus with XEmacs here. :-)
> http://randomsample.de:4456/builders/xemacs21.4-linux/builds/4/steps/compile/logs/stdio
>
> Instead, there's
>
> While compiling the end of the data in file
> /var/lib/buildbot/slaves/debian/build-xemacs21.4/build/lisp/gravatar.el:
> ** the function url-retrieve-synchronously is not known to be defined.
Yup. I don't get that one here, but I've fixed that one, anyway.
In the build log for Emacs 24, I see stuff like:
In end of data:
gnus-group.el:4650:1:Warning: the function `mouse-set-point' is not known to
be defined.
Wrote gnus-group.elc
In end of data:
gnus-html.el:531:1:Warning: the function `image-size' is not known to be
defined.
And I'm not getting that when compiling with Emacs 24 here. Has your
Emacs 24 been built without X support?
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: A Cleaner Build
2011-03-17 18:58 ` Lars Magne Ingebrigtsen
@ 2011-03-17 19:00 ` Lars Magne Ingebrigtsen
2011-03-17 20:55 ` David Engster
1 sibling, 0 replies; 8+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-03-17 19:00 UTC (permalink / raw)
To: ding
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> And I'm not getting that when compiling with Emacs 24 here. Has your
> Emacs 24 been built without X support?
And the same with your Emacs 22.
Your Emacs 23 doesn't have these mouse.el- and image-related warnings,
though.
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: A Cleaner Build
2011-03-17 18:58 ` Lars Magne Ingebrigtsen
2011-03-17 19:00 ` Lars Magne Ingebrigtsen
@ 2011-03-17 20:55 ` David Engster
2011-03-17 21:05 ` Lars Magne Ingebrigtsen
1 sibling, 1 reply; 8+ messages in thread
From: David Engster @ 2011-03-17 20:55 UTC (permalink / raw)
To: ding
Lars Magne Ingebrigtsen writes:
> David Engster <deng@randomsample.de> writes:
>
>> Lars Magne Ingebrigtsen writes:
>>> I've started tackling the warnings in the Gnus build. But here's one I
>>> don't understand:
>>>
>>> Compiling /home/larsi/pgnus/lisp/gnus-gravatar.el...
>>> While compiling toplevel forms in file
>>> /home/larsi/pgnus/lisp/gnus-gravatar.el:
>>> !! Symbol's function definition is void ((locate-user-emacs-file))
>>
>> Isn't that a real error?
>>
>> Anyway, I don't see that one in the stdio from
>
> No, it's from when I'm trying to build Gnus with XEmacs here. :-)
Yes, I figured that from /home/larsi (unless you hacked the buildbot,
that is). :-) locate-user-emacs-file existed in FSF Emacs 21. I have no
idea where that's coming from. But I'm guessing it's some quirk in your
installation.
> And I'm not getting that when compiling with Emacs 24 here. Has your
> Emacs 24 been built without X support?
It's a server; who needs X there? ;-)
Yeah well. That's what I thought. I fixed that now.
The last warning I see is from Emacs22:
In toplevel form:
message.el:1923:20:Warning: `make-variable-buffer-local' should be called at
toplevel
Otherwise it looks nice&clean, at least for the warnings enabled in
dgnushack (the buildbot does a normal 'make', not 'make warn').
-David
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: A Cleaner Build
2011-03-17 20:55 ` David Engster
@ 2011-03-17 21:05 ` Lars Magne Ingebrigtsen
2011-03-17 21:11 ` David Engster
0 siblings, 1 reply; 8+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-03-17 21:05 UTC (permalink / raw)
To: ding
David Engster <deng@randomsample.de> writes:
> Yes, I figured that from /home/larsi (unless you hacked the buildbot,
> that is). :-) locate-user-emacs-file existed in FSF Emacs 21. I have no
> idea where that's coming from. But I'm guessing it's some quirk in your
> installation.
Yup. Hm...
> Yeah well. That's what I thought. I fixed that now.
Great!
> The last warning I see is from Emacs22:
>
> In toplevel form:
> message.el:1923:20:Warning: `make-variable-buffer-local' should be called at
> toplevel
>
> Otherwise it looks nice&clean, at least for the warnings enabled in
> dgnushack (the buildbot does a normal 'make', not 'make warn').
Right. I'll switch on the "fail on warnings" thing in dgnushack. Or
should we have a special build target for that? Like "make warn"? I
guess so. I've now added a "warn" target in the makefile, but it just
does the same as "all" for now. But feel free to switch the target to
"make warn" on the buildbot, and I'll make the "warn" target do the
right thing later.
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: A Cleaner Build
2011-03-17 21:05 ` Lars Magne Ingebrigtsen
@ 2011-03-17 21:11 ` David Engster
2011-03-17 21:30 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 8+ messages in thread
From: David Engster @ 2011-03-17 21:11 UTC (permalink / raw)
To: ding
Lars Magne Ingebrigtsen writes:
>> Otherwise it looks nice&clean, at least for the warnings enabled in
>> dgnushack (the buildbot does a normal 'make', not 'make warn').
>
> Right. I'll switch on the "fail on warnings" thing in dgnushack. Or
> should we have a special build target for that? Like "make warn"? I
> guess so. I've now added a "warn" target in the makefile, but it just
> does the same as "all" for now. But feel free to switch the target to
> "make warn" on the buildbot, and I'll make the "warn" target do the
> right thing later.
Erm, there is already a warn target in the lisp/Makefile which calls
(dgnushack-compile t). This will also output stuff like 'obsolete' and
'might not be defined at runtime'.
Anyway, I also think having an extra target for 'fail on warning' is the
best choice.
-David
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-03-17 21:30 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-17 18:42 A Cleaner Build Lars Magne Ingebrigtsen
2011-03-17 18:50 ` David Engster
2011-03-17 18:58 ` Lars Magne Ingebrigtsen
2011-03-17 19:00 ` Lars Magne Ingebrigtsen
2011-03-17 20:55 ` David Engster
2011-03-17 21:05 ` Lars Magne Ingebrigtsen
2011-03-17 21:11 ` David Engster
2011-03-17 21:30 ` Lars Magne Ingebrigtsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).