Disallow ;;) smileys

Disallow ;;) smileys

[Simon Josefsson]

I've been bugged one too many times that the following line will display
with a smiley when viewed in Gnus:

   for (;;)

It doesn't seem like ;;) is ever a useful smiley, or is there?

So I propose the patch below.  How about it?  I can commit it if you
want.

Thanks,
Simon

2009-03-24  Simon Josefsson  <simon@josefsson.org>

	* smiley.el (smiley-regexp-alist): Disallow ;;) from being treated as a
	blink smiley.

--- smiley.el.~7.25.~	2009-02-03 14:56:15.000000000 +0100
+++ smiley.el	2009-03-24 10:02:13.000000000 +0100
@@ -102,7 +102,8 @@
 
 ;; The XEmacs version has a baroque, if not rococo, set of these.
 (defcustom smiley-regexp-alist
-  '(("\\(;-?)\\)\\W" 1 "blink")
+  '(("\\(;-)\\)\\W" 1 "blink")
+    ("\\([^;];)\\)\\W" 1 "blink")
     ("\\(:-]\\)\\W" 1 "forced")
     ("\\(8-)\\)\\W" 1 "braindamaged")
     ("\\(:-|\\)\\W" 1 "indifferent")

Re: Disallow ;;) smileys

[Miles Bader]

Simon Josefsson <simon@josefsson.org> writes:
> -  '(("\\(;-?)\\)\\W" 1 "blink")
> +  '(("\\(;-)\\)\\W" 1 "blink")
> +    ("\\([^;];)\\)\\W" 1 "blink")

That's going to eat the character before the smiley isn't it?

Shouldn't the second regexp  be "[^;]\\(;)\\)\\W" (moving the [^;]
outside the group)?

-Miles

-- 
Accordion, n. An instrument in harmony with the sentiments of an assassin.

Re: Disallow ;;) smileys

[Lars Magne Ingebrigtsen]

Miles Bader <miles@gnu.org> writes:

>> +  '(("\\(;-)\\)\\W" 1 "blink")
>> +    ("\\([^;];)\\)\\W" 1 "blink")
>
> That's going to eat the character before the smiley isn't it?
>
> Shouldn't the second regexp  be "[^;]\\(;)\\)\\W" (moving the [^;]
> outside the group)?

I've now committed this with your change.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen