Gnus development mailing list
 help / color / mirror / Atom feed
From: Nelson Ferreira <nelson.ferreira@ieee.org>
Subject: [PATCH] Allow topic catch-up with some groups available and some disconnected
Date: Mon, 31 Oct 2005 18:36:56 -0500	[thread overview]
Message-ID: <m3wtjt5kdj.fsf@tuxie.homelinux.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 979 bytes --]



Hi all,

I came across an issue where Gnus would abort topic catchup when some
of the groups where from an unavailable server:

Debugger entered--Lisp error: (wrong-type-argument number-char-or-marker-p nil)
  gnus-sequence-of-unread-articles("nntp+news.optonline.net:comp.software.patterns")
  gnus-group-catchup("nntp+news.optonline.net:comp.software.patterns" nil)
  gnus-group-catchup-current()
  #<compiled-function (topic) "...(32)" [gnus-group-marked buffer-read-only gnus-level-killed topic groups call-interactively gnus-group-catchup-current mapcar #<compiled-function ... "...(5)" ... 2> gnus-topic-find-groups t nil gnus-topic-update-topics-containing-group] 8 ("/usr/lib/sxemacs/site-packages/lisp/gnus/gnus-topic.elc" . 25793) (list (gnus-group-topic-name))>("Engineering")
  call-interactively(gnus-topic-catchup-articles)

The following patch is a naive approach at solving it.
I realize I am just silencing the error, which might be bad, but it
works for me.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus.topic.catchup.patch --]
[-- Type: text/x-patch, Size: 1065 bytes --]

Index: gnus-group.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-group.el,v
retrieving revision 7.55
diff -u -u -b -r7.55 gnus-group.el
--- gnus-group.el	26 Oct 2005 14:53:25 -0000	7.55
+++ gnus-group.el	31 Oct 2005 23:36:13 -0000
@@ -1049,7 +1056,7 @@
     (gnus-group-make-tool-bar))
   (gnus-simplify-mode-line)
   (setq major-mode 'gnus-group-mode)
-  (setq mode-name "Group")
+  (setq mode-name gnus-group-mode-line-string)
   (gnus-group-set-mode-line)
   (setq mode-line-process nil)
   (use-local-map gnus-group-mode-map)
@@ -3176,9 +3183,11 @@
 	     (gnus-group-real-name group) (nth 1 method) all)))
 	(if (>= (gnus-group-level group) gnus-level-zombie)
 	    (gnus-message 2 "Dead groups can't be caught up")
-	  (if (prog1
+	  (if (condition-case nil
+                  (prog1
 		  (gnus-group-goto-group group)
 		(gnus-group-catchup group all))
+                  (t  nil))
 	      (gnus-group-update-group-line)
 	    (setq ret (1+ ret)))))
       (gnus-group-next-unread-group 1)

[-- Attachment #3: Type: text/plain, Size: 22 bytes --]



-- 
Nelson Ferreira

             reply	other threads:[~2005-10-31 23:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-31 23:36 Nelson Ferreira [this message]
2006-04-13  7:26 ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3wtjt5kdj.fsf@tuxie.homelinux.net \
    --to=nelson.ferreira@ieee.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).