From: Mike McEwan <mike@lotusland.demon.co.uk>
Subject: [patch] `gnus-build-all-threads'
Date: 26 Aug 1998 05:33:15 +0100 [thread overview]
Message-ID: <m3yascz7jo.fsf@lotusland.demon.co.uk> (raw)
When conducting an `A T' in a summary buffer to expand a thread,
I've noticed that all so included articles are given
`gnus-ancient-mark', regardless of whether they were read or not. The
problem seems to be in `gnus-build-all-threads' where, having
`set-buffer' to `nntp-server-buffer', it tries to access variables
that are buffer local to `gnus-summary-buffer', namely
`gnus-newsgroup-unselected'. This was always `nil' and hence every
article was regarded as read.
The patch below does it for me.
--
Mike.
--- ChangeLog.orig Wed Aug 26 05:20:31 1998
+++ ChangeLog Wed Aug 26 05:28:51 1998
@@ -1,3 +1,9 @@
+1998-08-26 Mike McEwan <mike@lotusland.demon.co.uk>
+
+ * gnus-sum.el (gnus-build-all-threads): `save-excursion' and
+ `set-buffer' back to `gnus-summary-buffer' in order to access
+ buffer-local variables.
+
Sat Aug 22 10:28:25 1998 Lars Magne Ingebrigtsen <larsi@menja.ifi.uio.no>
* gnus.el: Gnus v5.6.39 is released.
--- gnus-sum.el.orig Wed Aug 26 05:11:16 1998
+++ gnus-sum.el Wed Aug 26 05:13:39 1998
@@ -3129,14 +3129,16 @@
header (gnus-nov-parse-line
article dependencies)))
(when header
- (push header gnus-newsgroup-headers)
- (if (memq (setq article (mail-header-number header))
- gnus-newsgroup-unselected)
- (progn
- (push article gnus-newsgroup-unreads)
- (setq gnus-newsgroup-unselected
- (delq article gnus-newsgroup-unselected)))
- (push article gnus-newsgroup-ancient))
+ (save-excursion
+ (set-buffer gnus-summary-buffer)
+ (push header gnus-newsgroup-headers)
+ (if (memq (setq article (mail-header-number header))
+ gnus-newsgroup-unselected)
+ (progn
+ (push article gnus-newsgroup-unreads)
+ (setq gnus-newsgroup-unselected
+ (delq article gnus-newsgroup-unselected)))
+ (push article gnus-newsgroup-ancient)))
(forward-line 1)))))))
(defun gnus-summary-update-article-line (article header)
reply other threads:[~1998-08-26 4:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3yascz7jo.fsf@lotusland.demon.co.uk \
--to=mike@lotusland.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).