Gnus development mailing list
 help / color / mirror / Atom feed
* [patch] `gnus-build-all-threads'
@ 1998-08-26  4:33 Mike McEwan
  0 siblings, 0 replies; only message in thread
From: Mike McEwan @ 1998-08-26  4:33 UTC (permalink / raw)



 When conducting an `A T' in a summary buffer to expand a thread,
 I've noticed that all so included articles are given
 `gnus-ancient-mark', regardless of whether they were read or not. The 
problem seems to be in `gnus-build-all-threads' where, having
`set-buffer' to `nntp-server-buffer', it tries to access variables
that are buffer local to `gnus-summary-buffer', namely
`gnus-newsgroup-unselected'. This was always `nil' and hence every
article was regarded as read.

  The patch below does it for me.

-- 
Mike.

--- ChangeLog.orig	Wed Aug 26 05:20:31 1998
+++ ChangeLog	Wed Aug 26 05:28:51 1998
@@ -1,3 +1,9 @@
+1998-08-26  Mike McEwan  <mike@lotusland.demon.co.uk>
+
+	* gnus-sum.el (gnus-build-all-threads): `save-excursion' and
+ 	`set-buffer' back to `gnus-summary-buffer' in order to access
+ 	buffer-local variables.
+
 Sat Aug 22 10:28:25 1998  Lars Magne Ingebrigtsen  <larsi@menja.ifi.uio.no>
 
 	* gnus.el: Gnus v5.6.39 is released.
--- gnus-sum.el.orig	Wed Aug 26 05:11:16 1998
+++ gnus-sum.el	Wed Aug 26 05:13:39 1998
@@ -3129,14 +3129,16 @@
 		  header (gnus-nov-parse-line
 			  article dependencies)))
 	  (when header
-	    (push header gnus-newsgroup-headers)
-	    (if (memq (setq article (mail-header-number header))
-		      gnus-newsgroup-unselected)
-		(progn
-		  (push article gnus-newsgroup-unreads)
-		  (setq gnus-newsgroup-unselected
-			(delq article gnus-newsgroup-unselected)))
-	      (push article gnus-newsgroup-ancient))
+	    (save-excursion
+	      (set-buffer gnus-summary-buffer)
+	      (push header gnus-newsgroup-headers)
+	      (if (memq (setq article (mail-header-number header))
+			gnus-newsgroup-unselected)
+		  (progn
+		    (push article gnus-newsgroup-unreads)
+		    (setq gnus-newsgroup-unselected
+			  (delq article gnus-newsgroup-unselected)))
+		(push article gnus-newsgroup-ancient)))
 	    (forward-line 1)))))))
 
 (defun gnus-summary-update-article-line (article header)


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~1998-08-26  4:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1998-08-26  4:33 [patch] `gnus-build-all-threads' Mike McEwan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).