From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/16295 Path: main.gmane.org!not-for-mail From: Mike McEwan Newsgroups: gmane.emacs.gnus.general Subject: [patch] `gnus-build-all-threads' Date: 26 Aug 1998 05:33:15 +0100 Sender: owner-ding@hpc.uh.edu Message-ID: NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 (generated by tm-edit 7.108) Content-Type: text/plain; charset=US-ASCII X-Trace: main.gmane.org 1035155186 26891 80.91.224.250 (20 Oct 2002 23:06:26 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 20 Oct 2002 23:06:26 +0000 (UTC) Return-Path: Original-Received: from gwyn.tux.org (gwyn.tux.org [207.96.122.8]) by altair.xemacs.org (8.9.1/8.9.1) with ESMTP id VAA09115 for ; Tue, 25 Aug 1998 21:47:09 -0700 Original-Received: from sina.hpc.uh.edu (Sina.HPC.UH.EDU [129.7.3.5]) by gwyn.tux.org (8.8.8/8.8.8) with ESMTP id AAA01493 for ; Wed, 26 Aug 1998 00:48:22 -0400 Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5]) by sina.hpc.uh.edu (8.7.3/8.7.3) with ESMTP id XAK27135; Tue, 25 Aug 1998 23:46:57 -0500 (CDT) Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Tue, 25 Aug 1998 23:46:15 -0500 (CDT) Original-Received: from sclp3.sclp.com (root@sclp3.sclp.com [209.195.19.139]) by sina.hpc.uh.edu (8.7.3/8.7.3) with ESMTP id XAA27118 for ; Tue, 25 Aug 1998 23:46:05 -0500 (CDT) Original-Received: from post.mail.demon.net (post-12.mail.demon.net [194.217.242.41]) by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id AAA03364 for ; Wed, 26 Aug 1998 00:46:00 -0400 (EDT) Original-Received: from [158.152.62.156] (helo=lotusland.demon.co.uk) by post.mail.demon.net with smtp (Exim 2.02 #1) id 0zBXT3-0007MC-00 for ding@gnus.org; Wed, 26 Aug 1998 04:45:57 +0000 Original-Received: from mike by lotusland.demon.co.uk with local (Exim 2.02 #1) id 0zBXT1-0000qf-00 for ding@gnus.org; Wed, 26 Aug 1998 05:45:55 +0100 Original-To: ding@gnus.org X-Mailer: Gnus v5.6.39/XEmacs 20.4 - "Emerald" Original-Lines: 54 Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:16295 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:16295 When conducting an `A T' in a summary buffer to expand a thread, I've noticed that all so included articles are given `gnus-ancient-mark', regardless of whether they were read or not. The problem seems to be in `gnus-build-all-threads' where, having `set-buffer' to `nntp-server-buffer', it tries to access variables that are buffer local to `gnus-summary-buffer', namely `gnus-newsgroup-unselected'. This was always `nil' and hence every article was regarded as read. The patch below does it for me. -- Mike. --- ChangeLog.orig Wed Aug 26 05:20:31 1998 +++ ChangeLog Wed Aug 26 05:28:51 1998 @@ -1,3 +1,9 @@ +1998-08-26 Mike McEwan + + * gnus-sum.el (gnus-build-all-threads): `save-excursion' and + `set-buffer' back to `gnus-summary-buffer' in order to access + buffer-local variables. + Sat Aug 22 10:28:25 1998 Lars Magne Ingebrigtsen * gnus.el: Gnus v5.6.39 is released. --- gnus-sum.el.orig Wed Aug 26 05:11:16 1998 +++ gnus-sum.el Wed Aug 26 05:13:39 1998 @@ -3129,14 +3129,16 @@ header (gnus-nov-parse-line article dependencies))) (when header - (push header gnus-newsgroup-headers) - (if (memq (setq article (mail-header-number header)) - gnus-newsgroup-unselected) - (progn - (push article gnus-newsgroup-unreads) - (setq gnus-newsgroup-unselected - (delq article gnus-newsgroup-unselected))) - (push article gnus-newsgroup-ancient)) + (save-excursion + (set-buffer gnus-summary-buffer) + (push header gnus-newsgroup-headers) + (if (memq (setq article (mail-header-number header)) + gnus-newsgroup-unselected) + (progn + (push article gnus-newsgroup-unreads) + (setq gnus-newsgroup-unselected + (delq article gnus-newsgroup-unselected))) + (push article gnus-newsgroup-ancient))) (forward-line 1))))))) (defun gnus-summary-update-article-line (article header)