From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/82129 Path: news.gmane.org!not-for-mail From: Daiki Ueno Newsgroups: gmane.emacs.gnus.general Subject: auth-source regression Date: Fri, 10 Aug 2012 18:37:24 +0900 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1344591538 6079 80.91.229.3 (10 Aug 2012 09:38:58 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 10 Aug 2012 09:38:58 +0000 (UTC) To: Ted Zlatanov , ding@gnus.org Original-X-From: ding-owner+M30397@lists.math.uh.edu Fri Aug 10 11:38:55 2012 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SzlgD-0000pP-Qh for ding-account@gmane.org; Fri, 10 Aug 2012 11:38:54 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1Szlf6-0003GN-TB; Fri, 10 Aug 2012 04:37:44 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1Szlf5-0003GD-LV for ding@lists.math.uh.edu; Fri, 10 Aug 2012 04:37:43 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1Szlf2-0004zV-9l for ding@lists.math.uh.edu; Fri, 10 Aug 2012 04:37:43 -0500 Original-Received: from du-a.org ([219.94.251.20] helo=www6246ue.sakura.ne.jp) by quimby.gnus.org with esmtp (Exim 4.72) (envelope-from ) id 1Szlez-00051H-T8 for ding@gnus.org; Fri, 10 Aug 2012 11:37:38 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-Spam-Score: -1.9 (-) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:82129 Archived-At: --=-=-= Content-Type: text/plain Hi, Today I noticed that the current auth-source-search always returns empty result. It seems that you recently changed auth-source.el to pass :type to search-function, but forgot to filter out the keyword from the search spec in auth-source-secrets-search and auth-sourec-plstore-search. I tested the attached patch with plstore but not with secrets. If it makes sense please apply. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-auth-source-ignore-some-keywords-in-search-spec.patch >From 744fb2a6b7a3b4bfbd822a277ef3672e83309737 Mon Sep 17 00:00:00 2001 From: Daiki Ueno Date: Fri, 10 Aug 2012 18:32:10 +0900 Subject: [PATCH] auth-source: ignore some keywords in search spec --- lisp/auth-source.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/auth-source.el b/lisp/auth-source.el index c8810bc..46fba78 100644 --- a/lisp/auth-source.el +++ b/lisp/auth-source.el @@ -1542,7 +1542,7 @@ authentication tokens: (let* ((coll (oref backend source)) (max (or max 5000)) ; sanity check: default to stop at 5K - (ignored-keys '(:create :delete :max :backend :label)) + (ignored-keys '(:create :delete :max :backend :label :require :type)) (search-keys (loop for i below (length spec) by 2 unless (memq (nth i spec) ignored-keys) collect (nth i spec))) @@ -1797,7 +1797,7 @@ entries for git.gnus.org: "Search the PLSTORE; spec is like `auth-source'." (let* ((store (oref backend data)) (max (or max 5000)) ; sanity check: default to stop at 5K - (ignored-keys '(:create :delete :max :backend :require)) + (ignored-keys '(:create :delete :max :backend :label :require :type)) (search-keys (loop for i below (length spec) by 2 unless (memq (nth i spec) ignored-keys) collect (nth i spec))) -- 1.7.11.2 --=-=-= Content-Type: text/plain Regards, -- Daiki Ueno --=-=-=--