White-space fixup

White-space fixup

[Lars Magne Ingebrigtsen]

Speaking of churn, I was reminded via a discussion in 2006 about
white space issues in Gnus.  Should I just delete all trailing white
space in Gnus in a big swoop?  

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: White-space fixup

[Steinar Bang]

>>>>> Lars Magne Ingebrigtsen <larsi@gnus.org>:

> Speaking of churn, I was reminded via a discussion in 2006 about white
> space issues in Gnus.  Should I just delete all trailing white space
> in Gnus in a big swoop?

Messes up the annotate (or whatever it's called in git).

Or perhaps git annotate is white-space-diff-transparent or something...?

Re: White-space fixup

[Lars Magne Ingebrigtsen]

Steinar Bang <sb@dod.no> writes:

> Or perhaps git annotate is white-space-diff-transparent or something...?

It'd be nice if it were...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: White-space fixup

[Lawrence Mitchell]

Lars Magne Ingebrigtsen wrote:
> Steinar Bang <sb@dod.no> writes:

>> Or perhaps git annotate is white-space-diff-transparent or something...?

> It'd be nice if it were...

git blame -w

 -w
         Ignore whitespace when comparing the parents version and
         the childs to find where the lines came from.

Lawrence
-- 
Lawrence Mitchell <wence@gmx.li>

Re: White-space fixup

[Lars Magne Ingebrigtsen]

Lawrence Mitchell <wence@gmx.li> writes:

> git blame -w
>
>  -w
>          Ignore whitespace when comparing the parents version and
>          the childs to find where the lines came from.

Nice.  Then the only issue is whether white space changes mess up
merging with the Emacs repository.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: White-space fixup

[Lars Magne Ingebrigtsen]

I've now removed all trailing white space.

What's the magical setting for having a hook for .el files in the Gnus
directory to automatically remove white space when I save files?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: White-space fixup

[Leo]

On 2010-09-01 23:02 +0100, Lars Magne Ingebrigtsen wrote:
> I've now removed all trailing white space.
>
> What's the magical setting for having a hook for .el files in the Gnus
> directory to automatically remove white space when I save files?

I only know about delete-trailing-whitespace.

Leo

Re: White-space fixup

[Reiner Steib]

On Thu, Sep 02 2010, Lars Magne Ingebrigtsen wrote:

> I've now removed all trailing white space.
>
> What's the magical setting for having a hook for .el files in the Gnus
> directory to automatically remove white space when I save files?

Please don't.  "drive-by" whitespace changes are annoying IMHO.
Rather use non-nil `show-trailing-whitespace' to avoid adding it.

,----[ <f1> v show-trailing-whitespace RET ]
| show-trailing-whitespace is a variable defined in `frame.el'.
| Its value is nil
| 
| Automatically becomes buffer-local when set in any fashion.
| 
| Documentation:
| *Non-nil means highlight trailing whitespace.
| This is done in the face `trailing-whitespace'.
`----

I use the following...

    (when (facep 'trailing-whitespace)
      (set-face-attribute 'trailing-whitespace nil
    			  :background "pink"))
    (let ((hook (lambda () (setq show-trailing-whitespace t))))
      (mapc (lambda (var) (add-hook var hook))
	    (cons 'lisp-mode-hook
		  '(emacs-lisp-mode-hook change-log-mode-hook))))
    (setq-default show-trailing-whitespace nil)


Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: White-space fixup

[Steinar Bang]

>>>>> Reiner Steib <reinersteib+gmane@imap.cc>:

> On Thu, Sep 02 2010, Lars Magne Ingebrigtsen wrote:
>> I've now removed all trailing white space.
>> 
>> What's the magical setting for having a hook for .el files in the Gnus
>> directory to automatically remove white space when I save files?

> Please don't.  "drive-by" whitespace changes are annoying IMHO.

Of course, if gnus is now trailing-white-space clean, then adding this
to the save hook won't create diff clutter by modifying someone else's
trailing white space.

Of course(2): this only holds until someone else introduces new trailing
white space in the repo.

Re: White-space fixup

[Ted Zlatanov]

On Thu, 02 Sep 2010 09:04:04 +0200 Reiner Steib <reinersteib+gmane@imap.cc> wrote: 

RS> On Thu, Sep 02 2010, Lars Magne Ingebrigtsen wrote:
>> I've now removed all trailing white space.
>> 
>> What's the magical setting for having a hook for .el files in the Gnus
>> directory to automatically remove white space when I save files?

RS> Please don't.  "drive-by" whitespace changes are annoying IMHO.
RS> Rather use non-nil `show-trailing-whitespace' to avoid adding it.

So according to http://www.emacswiki.org/emacs/DirectoryVariables we can
set up lisp/.dir-locals.el like this:

     ((lisp-mode . ((indent-tabs-mode . t)
                    ;; would this work? whitespace.el is in Emacs...
                    ;; (whitespace-style (quote (trailing)))
                    (show-trailing-whitespace t))))

assuming we agree on the tabs.  Should we be explicit about anything
else?

Ted

Re: White-space fixup

[Lars Magne Ingebrigtsen]

Ted Zlatanov <tzz@lifelogs.com> writes:

>      ((lisp-mode . ((indent-tabs-mode . t)
>                     ;; would this work? whitespace.el is in Emacs...
>                     ;; (whitespace-style (quote (trailing)))
>                     (show-trailing-whitespace t))))
>
> assuming we agree on the tabs.  Should we be explicit about anything
> else?

I think the tabs thing might be controversial, so I've checked in just
the trailing space thing.  Seems to work as advertised.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen