Gnus development mailing list
 help / color / mirror / Atom feed
From: Jesper Harder <harder@myrealbox.com>
Subject: Re: Proposed patch
Date: Sat, 01 Mar 2003 23:48:05 +0100	[thread overview]
Message-ID: <m3znoe900q.fsf@defun.localdomain> (raw)
In-Reply-To: <m3el61tiw2.fsf@hamster.pflaesterer.de>

sigurd@12move.de (Karl Pflästerer) writes:

> Before if you wanted to use `gnus-article-refer-article' on message-ids
> *without* »<>« that didn't work (allthough the button worked). That was
> a situation I didn't like as I like to do nearly everything with the
> keyboard. Now message-ids like
>     o news:foo.bar@baz.bat (which is a correct URI)
> can also be searched with `C-c ^'. Try it at the moment it is not
> possible. e.g.
>     o <m3of55tt40.fsf@hamster.pflaesterer.de> against
>     o <news:m3of55tt40.fsf@hamster.pflaesterer.de> against
>     o news:<m3of55tt40.fsf@hamster.pflaesterer.de>
>       (incorrect but can often be seen) against
>     o news:84d6lls5gk.fsf@lucy.is.informatik.uni-duisburg.de

I found a couple of problems with it:

  * I think `gnus-button-mid-or-mail-regexp' is too restrictive.  It's
    okay for automatic buttonizing, but when the user calls
    `gnus-article-refer-article' interactively, we shouldn't insist that
    the TLD is valid.  E.g. these don't work:

      <m3adh6bvr0.fsf@troodon.localdomain>

      <news:m3adh6bvr0.fsf@troodon.localdomain>

      m3adh6bvr0.fsf@troodon.localdomain

   
   * It sometimes fails for a plain msg-id with no brackets or "news:",
     e.g. place point after the "@" and press `C-c ^' there:

      m3of55tt40.fsf@hamster.pflaesterer.de

I've checked in another version.  It appears to work for all the
examples in this message -- but shout up if you find an example where it
fails.



  reply	other threads:[~2003-03-01 22:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-19 21:41 Better definition for `gnus-article-refer-article' Karl Pflästerer
2003-02-20 10:06 ` Kai Großjohann
2003-02-20 13:08   ` Karl Pflästerer
2003-02-21 17:59     ` Proposed patch (was: Better definition for `gnus-article-refer-article') Karl Pflästerer
2003-02-21 21:12       ` Proposed patch Kai Großjohann
2003-02-21 21:58         ` Karl Pflästerer
2003-03-01 22:48           ` Jesper Harder [this message]
2003-02-21 22:02         ` Karl Pflästerer
2003-02-22 10:38           ` Kai Großjohann
2003-02-22 13:31       ` Kai Großjohann
  -- strict thread matches above, loose matches on Subject: below --
1999-02-16 22:20 James H. Cloos Jr.
1999-02-19 13:37 ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3znoe900q.fsf@defun.localdomain \
    --to=harder@myrealbox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).