topic parameters and agent-score

topic parameters and agent-score

[Robert Epprecht]

If I put something in the topic parameters then a group inside
that topic that has 'nil' group parameters will behave like having
the topics parameter as group parameters. Did I get this right?

I'm asking because if I put '((agent-score . file))' in the topic
parameters and it does not seem to work like this. Can't I do that?
(Or maybe I'm misunderstanding this (agent-score . file)-thing...?)

Robert Epprecht

[patch] Re: topic parameters and agent-score

[Mike McEwan]

Robert Epprecht <epprecht@sunweb.ch> writes:

> If I put something in the topic parameters then a group inside
> that topic that has 'nil' group parameters will behave like having
> the topics parameter as group parameters. Did I get this right?
> 
> I'm asking because if I put '((agent-score . file))' in the topic
> parameters and it does not seem to work like this. Can't I do that?
> (Or maybe I'm misunderstanding this (agent-score . file)-thing...?)

  The following should do the trick...

--- pgnus/lisp/ChangeLog~	Sat Jul 10 20:47:05 1999
+++ pgnus/lisp/ChangeLog	Thu Jul 15 13:30:14 1999
@@ -1,3 +1,8 @@
+1999-07-15  Mike McEwan  <mike@lotusland.demon.co.uk>
+
+	* gnus-agent.el (gnus-agent-fetch-group-1): Allow 'agent-score' to 
+	be set in topic parameters.
+
 1999-07-10  Mike McEwan  <mike@lotusland.demon.co.uk>
 
 	* gnus-sum.el (gnus-sort-gathered-threads-function): New variable.
--- pgnus/lisp/gnus-agent.el~	Sat Jul 10 20:36:46 1999
+++ pgnus/lisp/gnus-agent.el	Thu Jul 15 13:28:45 1999
@@ -977,7 +977,7 @@
 	(setq score-param
 	      (let ((score-method
 		     (or
-		      (gnus-group-get-parameter group 'agent-score t)
+		      (gnus-group-find-parameter group 'agent-score t)
 		      (caddr category))))
 		(when score-method
 		  (require 'gnus-score)

-- 
Mike.

Re: [patch] Re: topic parameters and agent-score

[Robert Epprecht]

Hi Mike,

thanks a lot for the patch. Unfortunately I didn't succeed trying it out.
I wanted to check it on gnu.emacs.gnus, put it in my 'high' category and
got an error:
===========*Messages*==============
Fetching headers for gnu.emacs.gnus...
Scoring...
Selecting deleted buffer
===================================
(No backtrace with debug-on-error t.)

No idea if this is related to the patch.
(I *seem* to remember having seen this error before...)

Robert Epprecht

Re: [patch] Re: topic parameters and agent-score

[Robert Epprecht]

I tried it again, and this time I've got a backtrace.
Pterodactyl Gnus v0.95 with patch from Mike McEwan
(Message-ID: <m3zp0yf5wm.fsf@lotusland.demon.co.uk>) 
I have '((agent-score . file))' as topic parameter of the root topic
'nil' as sub topic parameter
'nil' as group parameter

I did 'J j  g  J s' and got the following backtrace
===============================================
Signaling: (error "Selecting deleted buffer")
  gnus-score-followup(((("thread" ... ...) ("subject" ... ... ...) ("from" ... $  gnus-score-thread(((("thread" ... ...) ("subject" ... ... ...) ("from" ... ..$  gnus-score-headers((((... ... ...) (...) (... ...))))
  gnus-agent-fetch-group-1("gnu.emacs.gnus" (nntp "news.sunrise.ch"))
  gnus-agent-fetch-session()
* call-interactively(gnus-agent-fetch-session)
===============================================

To see if I get more information I did (load "gnus-sum.el") and repeated
the procedure, but got no error this time (no new articles in the group?)

I just discovered that it looks like it *did* work with gnu.emacs.help
which is in the same topic and has the same group parameter. Strange...

Robert Epprecht

Re: [patch] Re: topic parameters and agent-score

[Mike McEwan]

Robert Epprecht <epprecht@sunweb.ch> writes:

> I just discovered that it looks like it *did* work with gnu.emacs.help
> which is in the same topic and has the same group parameter. Strange...

  Well, what to do now? The thing is fine with me, particularly given
that my change was of such minor consequence/change. Anyone else
getting this? What's it like at *group* level stuff/scoring?

  This e-mail/newsgroup/list stuff's OK but I'd still like to be
looking over your shoulder when you do what you say your
doing. Language/text can be so unrevealing sometimes eh :-).

-- 
Mike.

Re: [patch] Re: topic parameters and agent-score

[Robert Epprecht]

Mike McEwan <mike@lotusland.demon.co.uk> writes:

>   This e-mail/newsgroup/list stuff's OK but I'd still like to be
> looking over your shoulder when you do what you say your
> doing. Language/text can be so unrevealing sometimes eh :-).

Yes, that would be a good idea. It's very likely that I did something
wrong. I'd guess that my Gnus-agent got ill somehow, the question
remains *how* it got sick. It's very unlikely that it has something
to do with your patch. Maybe I should start a new gnus incarnation
from scratch someday?

BTW: I got a different backtrace this morning, which was caused for
the first time by another group. I attach it, because it might
throw some light on the issue.

================backtrace===================
Signaling: (error "Selecting deleted buffer")
  nntp-retrieve-articles((71810 71809 71774) "de.comp.os.unix.linux.misc" "new$  gnus-retrieve-articles((71810 71809 71774) "de.comp.os.unix.linux.misc")
  gnus-agent-fetch-articles("de.comp.os.unix.linux.misc" (71810 71809 71774))
  gnus-agent-fetch-group-1("de.comp.os.unix.linux.misc" (nntp "news.sunrise.ch$  gnus-agent-fetch-session()
* call-interactively(gnus-agent-fetch-session)
============================================

Robert Epprecht

Re: [patch] Re: topic parameters and agent-score

[Shenghuo ZHU]

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

>>>>> "Robert" == Robert Epprecht <epprecht@sunweb.ch> writes:

Robert> BTW: I got a different backtrace this morning, which was caused for
Robert> the first time by another group. I attach it, because it might
Robert> throw some light on the issue.

Robert> ================backtrace===================
Robert> Signaling: (error "Selecting deleted buffer")
Robert>   nntp-retrieve-articles((71810 71809 71774) "de.comp.os.unix.linux.misc" "new$  gnus-retrieve-articles((71810 71809 71774) "de.comp.os.unix.linux.misc")
Robert>   gnus-agent-fetch-articles("de.comp.os.unix.linux.misc" (71810 71809 71774))
Robert>   gnus-agent-fetch-group-1("de.comp.os.unix.linux.misc" (nntp "news.sunrise.ch$  gnus-agent-fetch-session()
Robert> * call-interactively(gnus-agent-fetch-session)
Robert> ============================================

Although you get different backtrace, the reason is the same.  Read my
article <2nu2r9yvuh.fsf@tiger.jia.vnet>.  The patch in the article
fixes part of this bug. Here is another patch.  You need apply both
patches.  I hope these can fix the bug.

1999-07-17  Shenghuo ZHU  <zsh@cs.rochester.edu>

	* nntp.el (nntp-kill-buffer): New function.
	* nntp.el: Use it to kill process buffer.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 95-zsh11.diff --]
[-- Type: text/x-patch, Size: 2101 bytes --]

--- ../../pgnus-sent/lisp/nntp.el	Tue Jul  6 10:04:38 1999
+++ nntp.el	Sat Jul 17 09:54:23 1999
@@ -292,6 +292,11 @@
       (unless discard
 	(erase-buffer)))))
 
+(defun nntp-kill-buffer (buffer)
+  (when (buffer-name buffer)
+    (kill-buffer buffer)
+    (nnheader-init-server-buffer)))
+
 (defsubst nntp-find-connection (buffer)
   "Find the connection delivering to BUFFER."
   (let ((alist nntp-connection-alist)
@@ -304,8 +309,7 @@
     (when process
       (if (memq (process-status process) '(open run))
 	  process
-	(when (buffer-name (process-buffer process))
-	  (kill-buffer (process-buffer process)))
+	(nntp-kill-buffer (process-buffer process))
 	(setq nntp-connection-alist (delq entry nntp-connection-alist))
 	nil))))
 
@@ -696,8 +700,7 @@
 	    ;; QUIT command actually is sent out before we kill
 	    ;; the process.
 	    (sleep-for 1))))
-      (when (buffer-name (process-buffer process))
-	(kill-buffer (process-buffer process)))
+      (nntp-kill-buffer (process-buffer process))
       (setq process (car (pop nntp-connection-alist))))
     (nnoo-close-server 'nntp)))
 
@@ -713,8 +716,7 @@
 	    ;; QUIT command actually is sent out before we kill
 	    ;; the process.
 	    (sleep-for 1))))
-      (when (buffer-name (process-buffer process))
-	(kill-buffer (process-buffer process))))))
+      (nntp-kill-buffer (process-buffer process)))))
 
 (deffoo nntp-request-list (&optional server)
   (nntp-possibly-change-group nil server)
@@ -846,8 +848,7 @@
 	       (nnheader-run-at-time
 		nntp-connection-timeout nil
 		`(lambda ()
-		   (when (buffer-name ,pbuffer)
-		     (kill-buffer ,pbuffer))))))
+		   (nntp-kill-buffer ,pbuffer)))))
 	 (process
 	  (condition-case ()
 	      (let ((coding-system-for-read nntp-coding-system-for-read)
@@ -873,8 +874,7 @@
 	      (let ((nnheader-callback-function nil))
 		(run-hooks 'nntp-server-opened-hook)
 		(nntp-send-authinfo t))))
-	(when (buffer-name (process-buffer process))
-	  (kill-buffer (process-buffer process)))
+	(nntp-kill-buffer (process-buffer process))
 	nil))))
 
 (defun nntp-open-network-stream (buffer)

[-- Attachment #3: Type: text/plain, Size: 18 bytes --]


-- 
Shenghuo ZHU

Re: [patch] Re: topic parameters and agent-score

[Robert Epprecht]

Shenghuo ZHU <zsh@cs.rochester.edu> writes:

> Although you get different backtrace, the reason is the same.  Read my
> article <2nu2r9yvuh.fsf@tiger.jia.vnet>.  The patch in the article
> fixes part of this bug. Here is another patch.  You need apply both
> patches.  I hope these can fix the bug.

Hmm, sorry to say, but it doesn't look like.
I've got a very similar backtrace like in <m23dyoa6fb.fsf@pc.sunweb.ch>
after applying the two patches.

FYI:
I have only *one* nntp server.

I still see those strange empty articles (see <m27lo826gh.fsf@pc.sunweb.ch>)
in some groups, but the group where the error happend this time does not
have them.

All my score files where exclusively produced by the interface that Gnus
provides, so I didn't mess them up by hand ;-)

Robert Epprecht