Re: Oort doesn't really support XEmacs 21.1

[Steve Youngs <youngs@xemacs.org>]

|--==> "SJ" == Simon Josefsson <jas@extundo.com> writes:

  SJ> Steve Youngs <youngs@xemacs.org> writes:
  >>`open-network-stream' - "PROTOCOL" arg doesn't exist

  SJ> Emacs doesn't have PROTOCOL either.  Where is it used (without a
  SJ> fallback)?

,----[ from dns.el ]
| (defmacro dns-make-network-process (server)
|   (if (featurep 'xemacs)
|       `(let ((coding-system-for-read 'binary)
| 	     (coding-system-for-write 'binary))
| 	 (open-network-stream "dns" (current-buffer) ,server "domain" 'udp))
|     `(let ((server ,server)
| 	   (coding-system-for-read 'binary)
| 	   (coding-system-for-write 'binary))
|        (if (fboundp 'make-network-process)
| 	   (make-network-process
| 	    :name "dns"
| 	    :coding 'binary
| 	    :buffer (current-buffer)
| 	    :host server
| 	    :service "domain"
| 	    :type 'datagram)
| 	 ;; Older versions of Emacs doesn't have
| 	 ;; `make-network-process', so we fall back on opening a TCP
| 	 ;; connection to the DNS server.
| 	 (open-network-stream "dns" (current-buffer) server "domain")))))
`----

It only falls back when _not_ (featurep 'xemacs).


  >>`completing-read'     - "DEFAULT" arg doesn't exist

  SJ> There is gnus-completing-read, perhaps it can be used?

`gnus-completing-read' doesn't have the "DEFAULT" arg either, so if we
use that instead of `completing-read' we'll lose DEFAULT everywhere.
If I condition it so that only XEmacs 21.1 uses `gnus-completing-read'
in these cases I may as well just use `completing-read' because there
doesn't seem to be any benefit to using g-c-r here. (exactly the same)

  >>Do you want me to fix those for 5.10?

  SJ> I vote yes.

OK.

  >>There is also `string-to-multibyte' which doesn't exist on XEmacs
  >>21.1, I could just defalias that to `ignore'.

  SJ> It doesn't exist under Emacs 20 either.  Where is it used
  SJ> (unconditionally)?

That one's OK, it's wrapped in a `fboundp' test, so defalias ignore
should be fine.

  >>I suppose all of this raises the question: "Do we continue to support
  >>XEmacs 21.1 seeing as though it has been retired as the stable
  >>branch?".

  SJ> I vote yes.  The manual still claim to support XEmacs 20.4, dropping
  SJ> two major versions at the same time seems excessive.

When was the last time somebody tested Oort Gnus on XEmacs 20.4?  I'd
say you'd be pushing shit up hill to get it to run there, so I'd
suggest those docs are a little out of date. [1]


Footnotes: 
[1]  I haven't tested on XEmacs 20.4 so I can't say for sure.

-- 
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
|        XEmacs - The only _______ you'll ever need.       |
|          Fill in the blank, yes, it's THAT good!         |
|------------------------------------<youngs@xemacs.org>---|